Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue when attemping to send command after pair. #15896

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

krypton36
Copy link
Contributor

Problem

After pairing is successful, and the chip-tool-darwin is not signed, the command will fail to re-pair and send command.

Change overview

  • Updates the public key generation to have more specific parameters.
  • Create NSData from correct parameters.

Testing

  • Paired
  • Sent commands several times

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

PR #15896: Size comparison from 5e4a98c to 170cb94

Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e4a98c 170cb94 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601546 601546 0 0.0
.app_xip_area 506088 506088 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559522 559522 0 0.0
.app_xip_area 465600 465600 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581718 581718 0 0.0
.app_xip_area 478116 478116 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920508 920508 0 0.0
(read/write) 128840 128840 0 0.0
.bss 126760 126760 0 0.0
.data 2080 2080 0 0.0
.text 920500 920500 0 0.0
BRD4161A+rpc (read only) 949344 949344 0 0.0
(read/write) 144800 144800 0 0.0
.bss 142536 142536 0 0.0
.data 2260 2260 0 0.0
.text 949336 949336 0 0.0
lock-app BRD4161A+wf200 (read only) 988492 988492 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118428 118428 0 0.0
.data 1932 1932 0 0.0
.text 988484 988484 0 0.0
window-app BRD4161A (read only) 853568 853568 0 0.0
(read/write) 126832 126832 0 0.0
.bss 124904 124904 0 0.0
.data 1924 1924 0 0.0
.text 853560 853560 0 0.0
esp32 all-clusters-app c3devkit (read only) 957240 957240 0 0.0
(read/write) 1393570 1393570 0 0.0
.dram0.bss 63424 63424 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957240 957240 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1011955 1011955 0 0.0
(read/write) 460684 460684 0 0.0
.dram0.bss 68952 68952 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006571 1006571 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694556 694556 0 0.0
.bss 77696 77696 0 0.0
.data 1964 1964 0 0.0
.text 609096 609096 0 0.0
lock k32w061+release (read/write) 696144 696144 0 0.0
.bss 77664 77664 0 0.0
.data 1972 1972 0 0.0
.text 610708 610708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9397540 9397540 0 0.0
(read/write) 454017 454017 0 0.0
.bss 43841 43841 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 350904 350904 0 0.0
.dynamic 560 560 0 0.0
.got 54288 54288 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485756 485756 0 0.0
.text 7908500 7908500 0 0.0
thermostat-no-ble arm64 (read only) 2174068 2174068 0 0.0
(read/write) 148513 148513 0 0.0
.bss 65201 65201 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1822672 1822672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186076 186076 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151479 1151479 0 0.0
bss 146784 146784 0 0.0
rodata 144272 144272 0 0.0
text 785228 785228 0 0.0
p6 all-clusters-app default (read/write) 2493680 2493680 0 0.0
.bss 119496 119496 0 0.0
.data 2696 2696 0 0.0
.text 1451944 1451944 0 0.0
light-app default (read/write) 2397128 2397128 0 0.0
.bss 112968 112968 0 0.0
.data 2544 2544 0 0.0
.text 1355392 1355392 0 0.0
lock-app default (read/write) 2360608 2360608 0 0.0
.bss 112712 112712 0 0.0
.data 2504 2504 0 0.0
.text 1318872 1318872 0 0.0
qpg lighting-app qpg6105+debug (read only) 603740 603740 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91072 91072 0 0.0
.data 1164 1164 0 0.0
.text 598420 598420 0 0.0
lock-app qpg6105+debug (read only) 569400 569400 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1116 1116 0 0.0
.text 564080 564080 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888594 888594 0 0.0
bss 86920 86920 0 0.0
noinit 37160 37160 0 0.0
text 627988 627988 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking tooling updates

@woody-apple woody-apple merged commit dde4a8f into project-chip:master Mar 7, 2022
krypton36 pushed a commit to krypton36/connectedhomeip that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants