Add timeout argument to test command #15893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test cluster command in particular is very long and the time
required to run it varies greatly depending on the network setup.
On the M5, we are timing out with the already increased default
value, whereas with a linux device this entire test completes in
less than 10s. Rather than forcing every platform to use the same
default, make the default settable on the command line.
Test: added a log to ensure that the returned GetWaitDuration returns
the value from the command line. It does, log is removed.
|
PR #15893: Size comparison from 5e4a98c to d6e4364 Increases (1 build for linux)
Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Mar 7, 2022
isiu-apple
approved these changes
Mar 7, 2022
| @@ -47,14 +47,17 @@ class TestCommand : public CHIPCommand, | |||
| { | |||
| AddArgument("delayInMs", 0, UINT64_MAX, &mDelayInMs); | |||
| AddArgument("PICS", &mPICSFilePath); | |||
| AddArgument("testTimeoutInS", 0, UINT16_MAX, &mTimeout); | |||
There was a problem hiding this comment.
Fwiw, this can already be set in the YAML file....
mykrupp
referenced
this pull request
in mykrupp/connectedhomeip-1
Mar 8, 2022
The test cluster command in particular is very long and the time
required to run it varies greatly depending on the network setup.
On the M5, we are timing out with the already increased default
value, whereas with a linux device this entire test completes in
less than 10s. Rather than forcing every platform to use the same
default, make the default settable on the command line.
Test: added a log to ensure that the returned GetWaitDuration returns
the value from the command line. It does, log is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The test cluster command in particular is very long and the time
required to run it varies greatly depending on the network setup.
On the M5, we are timing out with the already increased default
value, whereas with a linux device this entire test completes in
less than 10s. Rather than forcing every platform to use the same
default, make the default settable on the command line.
Change overview
Testing
Test: added a log to ensure that the returned GetWaitDuration returns
the value from the command line. It does, log is removed.