Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GN build warnings due to objects with no symbols on Mac #1552

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Fix GN build warnings due to objects with no symbols on Mac #1552

merged 1 commit into from
Jul 10, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 10, 2020

Add support for selecting one of CHIPMem-Malloc.cpp and
CHIPMem-Simple.cpp to avoid warnings from compiling files with no
symbols.

@mspang
Fix GN build warnings due to objects with no symbols on Mac
865517b 
Add support for selecting one of CHIPMem-Malloc.cpp and
CHIPMem-Simple.cpp to avoid warnings from compiling files with no
symbols.
@andy31415 andy31415 merged commit 0c1fc15 into project-chip:master Jul 10, 2020
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @kedars
Fix GN build warnings due to objects with no symbols on Mac (project-…
9f774a8 
…chip#1552)

Add support for selecting one of CHIPMem-Malloc.cpp and
CHIPMem-Simple.cpp to avoid warnings from compiling files with no
symbols.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @kedars
Fix GN build warnings due to objects with no symbols on Mac (project-…
cba95c3 
…chip#1552)

Add support for selecting one of CHIPMem-Malloc.cpp and
CHIPMem-Simple.cpp to avoid warnings from compiling files with no
symbols.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@mspang @kedars
Fix GN build warnings due to objects with no symbols on Mac (project-…
35f2928 
…chip#1552)

Add support for selecting one of CHIPMem-Malloc.cpp and
CHIPMem-Simple.cpp to avoid warnings from compiling files with no
symbols.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@mspang @kedars
Fix GN build warnings due to objects with no symbols on Mac (project-…
cbadd60 
…chip#1552)

Add support for selecting one of CHIPMem-Malloc.cpp and
CHIPMem-Simple.cpp to avoid warnings from compiling files with no
symbols.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@mspang @kedars
Fix GN build warnings due to objects with no symbols on Mac (project-…
fc06418 
…chip#1552)

Add support for selecting one of CHIPMem-Malloc.cpp and
CHIPMem-Simple.cpp to avoid warnings from compiling files with no
symbols.
@mspang mspang deleted the for-chip/malloc-warnings branch August 14, 2020 20:17
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
@bhmanda-silabs @jmartinez-silabs
Pull request project-chip#1552: [MATTER-2763]wifi-917NCP_enabling LCD
4676575 
Merge in WMN_TOOLS/matter from feature/wifi_917ncp_lcd to RC_2.3.0-1.3

Squashed commit of the following:

commit 136a77e165aefb649a8187c5177319e13af0f21a
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Fri Feb 9 22:50:30 2024 +0530

    Resolved review comments

commit 4c2f020a346c3e6e3c12fb72fc4d8691ed12aaec
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:36:25 2024 +0530

    removed commented code

commit a67ada4d9d56dea11e627887e6ee4d431bae22ad
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:29:54 2024 +0530

    Removed special characters

... and 3 more commits
bhmanda-silabs added a commit to bhmanda-silabs/connectedhomeip that referenced this pull request Feb 20, 2024
@bhmanda-silabs
Pull request project-chip#1552: [MATTER-2763]wifi-917NCP_enabling LCD
e8ea4c6 
Merge in WMN_TOOLS/matter from feature/wifi_917ncp_lcd to RC_2.3.0-1.3

Squashed commit of the following:

commit 136a77e165aefb649a8187c5177319e13af0f21a
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Fri Feb 9 22:50:30 2024 +0530

    Resolved review comments

commit 4c2f020a346c3e6e3c12fb72fc4d8691ed12aaec
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:36:25 2024 +0530

    removed commented code

commit a67ada4d9d56dea11e627887e6ee4d431bae22ad
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:29:54 2024 +0530

    Removed special characters

... and 3 more commits
bhmanda-silabs added a commit to bhmanda-silabs/connectedhomeip that referenced this pull request Feb 22, 2024
@bhmanda-silabs
Pull request project-chip#1552: [MATTER-2763]wifi-917NCP_enabling LCD
441feb3 
Merge in WMN_TOOLS/matter from feature/wifi_917ncp_lcd to RC_2.3.0-1.3

Squashed commit of the following:

commit 136a77e165aefb649a8187c5177319e13af0f21a
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Fri Feb 9 22:50:30 2024 +0530

    Resolved review comments

commit 4c2f020a346c3e6e3c12fb72fc4d8691ed12aaec
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:36:25 2024 +0530

    removed commented code

commit a67ada4d9d56dea11e627887e6ee4d431bae22ad
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:29:54 2024 +0530

    Removed special characters

... and 3 more commits
jmartinez-silabs pushed a commit that referenced this pull request Feb 28, 2024
@bhmanda-silabs
[Silabs] Added fixes for hardfault issue with rs9116 when LCD enabled…
13622a3 
… and 917 NCP-LCD enablement (#32209)

* Added fixes for hardfault issue with rs9116 when LCD enabled

* resolved build errors with mg12

* Pull request #1552: [MATTER-2763]wifi-917NCP_enabling LCD

Merge in WMN_TOOLS/matter from feature/wifi_917ncp_lcd to RC_2.3.0-1.3

Squashed commit of the following:

commit 136a77e165aefb649a8187c5177319e13af0f21a
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Fri Feb 9 22:50:30 2024 +0530

    Resolved review comments

commit 4c2f020a346c3e6e3c12fb72fc4d8691ed12aaec
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:36:25 2024 +0530

    removed commented code

commit a67ada4d9d56dea11e627887e6ee4d431bae22ad
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:29:54 2024 +0530

    Removed special characters

... and 3 more commits

* resolved review comments

* Resolved review comments

* Resolved comments and removed ununsed macros

* removed semaphore in header file as it is not being used in this file

* resolved the comments

* Restyled
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@bhmanda-silabs @huangxuyong
[Silabs] Added fixes for hardfault issue with rs9116 when LCD enabled…
ac76f45 
… and 917 NCP-LCD enablement (project-chip#32209)

* Added fixes for hardfault issue with rs9116 when LCD enabled

* resolved build errors with mg12

* Pull request project-chip#1552: [MATTER-2763]wifi-917NCP_enabling LCD

Merge in WMN_TOOLS/matter from feature/wifi_917ncp_lcd to RC_2.3.0-1.3

Squashed commit of the following:

commit 136a77e165aefb649a8187c5177319e13af0f21a
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Fri Feb 9 22:50:30 2024 +0530

    Resolved review comments

commit 4c2f020a346c3e6e3c12fb72fc4d8691ed12aaec
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:36:25 2024 +0530

    removed commented code

commit a67ada4d9d56dea11e627887e6ee4d431bae22ad
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:29:54 2024 +0530

    Removed special characters

... and 3 more commits

* resolved review comments

* Resolved review comments

* Resolved comments and removed ununsed macros

* removed semaphore in header file as it is not being used in this file

* resolved the comments

* Restyled
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@bhmanda-silabs @jmartinez-silabs
Pull request project-chip#1552: [MATTER-2763]wifi-917NCP_enabling LCD
1d21ab1 
Merge in WMN_TOOLS/matter from feature/wifi_917ncp_lcd to RC_2.3.0-1.3

Squashed commit of the following:

commit 136a77e165aefb649a8187c5177319e13af0f21a
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Fri Feb 9 22:50:30 2024 +0530

    Resolved review comments

commit 4c2f020a346c3e6e3c12fb72fc4d8691ed12aaec
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:36:25 2024 +0530

    removed commented code

commit a67ada4d9d56dea11e627887e6ee4d431bae22ad
Author: bhmanda-silabs <bhavani.manda@silabs.com>
Date:   Thu Feb 8 19:29:54 2024 +0530

    Removed special characters

... and 3 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mspang @andy31415 @saurabhst @woody-apple