Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Remove provider and fabric command line options from the requestor application #15287

Merged
merged 1 commit into from
Feb 17, 2022
Merged

[OTA] Remove provider and fabric command line options from the requestor application #15287

merged 1 commit into from
Feb 17, 2022

Conversation

carol-apple
Copy link
Contributor

Problem

The ota-requestor-app still contains command line options for provider and fabric but these values aren't being used at all.

Fixes: #15273

Change overview

  • Removed the -n and -f command line options
  • Update README

Testing

No functional change

@github-actions
Copy link

github-actions bot commented Feb 17, 2022 •
edited
Loading

PR #15287: Size comparison from b03bc9f to 8c18dd6

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b03bc9f 8c18dd6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597578 597578 0 0.0
.app_xip_area 501496 501496 0 0.0
.bss 78780 78780 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555526 555526 0 0.0
.app_xip_area 461012 461012 0 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576630 576630 0 0.0
.app_xip_area 472684 472684 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914580 914580 0 0.0
(read/write) 129524 129524 0 0.0
.bss 127488 127488 0 0.0
.data 2036 2036 0 0.0
.text 914572 914572 0 0.0
BRD4161A+rpc (read only) 943272 943272 0 0.0
(read/write) 146440 146440 0 0.0
.bss 144264 144264 0 0.0
.data 2176 2176 0 0.0
.text 943264 943264 0 0.0
window-app BRD4161A (read only) 848440 848440 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848432 848432 0 0.0
esp32 all-clusters-app c3devkit (read only) 947906 947906 0 0.0
(read/write) 1401178 1401178 0 0.0
.dram0.bss 68296 68296 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199712 199712 0 0.0
.flash.text 947906 947906 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 997671 997671 0 0.0
(read/write) 466420 466420 0 0.0
.dram0.bss 73432 73432 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226796 226796 0 0.0
.flash.text 992287 992287 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691596 691596 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605500 605500 0 0.0
lock k32w061+release (read/write) 694228 694228 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 607876 607876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8333284 8333284 0 0.0
(read/write) 362609 362609 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49272 49272 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435820 435820 0 0.0
.text 7134772 7134772 0 0.0
thermostat-no-ble arm64 (read only) 2163132 2163132 0 0.0
(read/write) 150737 150737 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133596 133596 0 0.0
.text 1810912 1810912 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2428700 2428700 0 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1391272 1391272 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391900 2391900 0 0.0
.bss 188448 188448 0 0.0
.data 5632 5632 0 0.0
.text 1354472 1354472 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327344 2327344 0 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1289944 1289944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2318108 2318108 0 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280680 1280680 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022539 1022539 0 0.0
bss 123548 123548 0 0.0
rodata 120664 120664 0 0.0
text 699328 699328 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 991835 991835 0 0.0
bss 120736 120736 0 0.0
rodata 112192 112192 0 0.0
text 679228 679228 0 0.0
nrf52840dongle_nrf52840 (read/write) 1037359 1037359 0 0.0
bss 124768 124768 0 0.0
rodata 119480 119480 0 0.0
text 703216 703216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929154 929154 0 0.0
bss 120112 120112 0 0.0
rodata 113908 113908 0 0.0
text 614340 614340 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951243 951243 0 0.0
bss 121752 121752 0 0.0
rodata 109360 109360 0 0.0
text 641516 641516 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858706 858706 0 0.0
bss 118344 118344 0 0.0
rodata 102532 102532 0 0.0
text 557308 557308 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949695 949695 0 0.0
bss 121472 121472 0 0.0
rodata 108316 108316 0 0.0
text 641336 641336 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945767 945767 0 0.0
bss 121476 121476 0 0.0
rodata 108012 108012 0 0.0
text 637576 637576 0 0.0
shell nrf52840dk_nrf52840 (read/write) 810767 810767 0 0.0
bss 113324 113324 0 0.0
rodata 79348 79348 0 0.0
text 540444 540444 0 0.0
p6 all-clusters-app default (read/write) 2486304 2486304 0 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1444568 1444568 0 0.0
light-app default (read/write) 2393192 2393192 0 0.0
.bss 113912 113912 0 0.0
.data 2528 2528 0 0.0
.text 1351456 1351456 0 0.0
lock-app default (read/write) 2356656 2356656 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1314920 1314920 0 0.0
qpg lighting-app qpg6105+debug (read only) 599068 599068 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90744 90744 0 0.0
.data 1112 1112 0 0.0
.text 593748 593748 0 0.0
lock-app qpg6105+debug (read only) 564700 564700 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90728 90728 0 0.0
.data 1064 1064 0 0.0
.text 559380 559380 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877890 877890 0 0.0
bss 87520 87520 0 0.0
noinit 37160 37160 0 0.0
text 618302 618302 0 0.0

@carol-apple carol-apple force-pushed the ota_requestor_remove_stale_options branch from 8c18dd6 to c4722ca Compare February 17, 2022 18:24
@boring-cyborg boring-cyborg bot added the github label Feb 17, 2022
@github-actions
Copy link

github-actions bot commented Feb 17, 2022 •
edited
Loading

PR #15287: Size comparison from a248f39 to c4722ca

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a248f39 c4722ca change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598498 598498 0 0.0
.app_xip_area 502440 502440 0 0.0
.bss 78756 78756 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556646 556646 0 0.0
.app_xip_area 462132 462132 0 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577770 577770 0 0.0
.app_xip_area 473824 473824 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914536 914536 0 0.0
(read/write) 129504 129504 0 0.0
.bss 127464 127464 0 0.0
.data 2036 2036 0 0.0
.text 914528 914528 0 0.0
BRD4161A+rpc (read only) 943228 943228 0 0.0
(read/write) 146416 146416 0 0.0
.bss 144240 144240 0 0.0
.data 2176 2176 0 0.0
.text 943220 943220 0 0.0
window-app BRD4161A (read only) 848516 848516 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848508 848508 0 0.0
esp32 all-clusters-app c3devkit (read only) 949808 949808 0 0.0
(read/write) 1401602 1401602 0 0.0
.dram0.bss 68504 68504 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200040 200040 0 0.0
.flash.text 949808 949808 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999271 999271 0 0.0
(read/write) 466832 466832 0 0.0
.dram0.bss 73640 73640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227000 227000 0 0.0
.flash.text 993887 993887 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691784 691784 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605688 605688 0 0.0
lock k32w061+release (read/write) 694384 694384 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 608032 608032 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8650804 8650804 0 0.0
(read/write) 413265 413265 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 298744 298744 0 0.0
.dynamic 560 560 0 0.0
.got 50552 50552 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 450092 450092 0 0.0
.text 7329924 7329924 0 0.0
thermostat-no-ble arm64 (read only) 2162924 2162924 0 0.0
(read/write) 150753 150753 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133692 133692 0 0.0
.text 1810560 1810560 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430164 2430164 0 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1392736 1392736 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391940 2391940 0 0.0
.bss 188424 188424 0 0.0
.data 5632 5632 0 0.0
.text 1354512 1354512 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327568 2327568 0 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1290168 1290168 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2318404 2318404 0 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280976 1280976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022527 1022527 0 0.0
bss 123524 123524 0 0.0
rodata 120636 120636 0 0.0
text 699348 699348 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 991835 991835 0 0.0
bss 120712 120712 0 0.0
rodata 112176 112176 0 0.0
text 679248 679248 0 0.0
nrf52840dongle_nrf52840 (read/write) 1037343 1037343 0 0.0
bss 124744 124744 0 0.0
rodata 119464 119464 0 0.0
text 703216 703216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929138 929138 0 0.0
bss 120084 120084 0 0.0
rodata 113892 113892 0 0.0
text 614372 614372 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951403 951403 0 0.0
bss 121752 121752 0 0.0
rodata 109472 109472 0 0.0
text 641568 641568 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858878 858878 0 0.0
bss 118344 118344 0 0.0
rodata 102640 102640 0 0.0
text 557372 557372 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949851 949851 0 0.0
bss 121472 121472 0 0.0
rodata 108424 108424 0 0.0
text 641388 641388 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945923 945923 0 0.0
bss 121476 121476 0 0.0
rodata 108120 108120 0 0.0
text 637628 637628 0 0.0
shell nrf52840dk_nrf52840 (read/write) 810767 810767 0 0.0
bss 113324 113324 0 0.0
rodata 79348 79348 0 0.0
text 540444 540444 0 0.0
p6 all-clusters-app default (read/write) 2487800 2487800 0 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1446064 1446064 0 0.0
light-app default (read/write) 2393096 2393096 0 0.0
.bss 113888 113888 0 0.0
.data 2528 2528 0 0.0
.text 1351360 1351360 0 0.0
lock-app default (read/write) 2356744 2356744 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1315008 1315008 0 0.0
qpg lighting-app qpg6105+debug (read only) 599388 599388 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90944 90944 0 0.0
.data 1112 1112 0 0.0
.text 594068 594068 0 0.0
lock-app qpg6105+debug (read only) 565192 565192 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1064 1064 0 0.0
.text 559872 559872 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877894 877894 0 0.0
bss 87496 87496 0 0.0
noinit 37160 37160 0 0.0
text 618338 618338 0 0.0

@carol-apple carol-apple merged commit c61251e into project-chip:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrishi dhrishi dhrishi approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTA Requestor command line options for provider/fabric should be removed
4 participants
@carol-apple @dhrishi @bzbarsky-apple @Damian-Nordic