Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CASE Authenticated Tag (CAT) Support To the Commissioner APIs. #15117

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Added CASE Authenticated Tag (CAT) Support To the Commissioner APIs. #15117

merged 1 commit into from
Mar 23, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Current code doesn't support CASE Authenticated Tags in the Operation Certificates generation logic.

Change overview

Added CAT support

Testing

existing tests

@stale
Copy link

stale bot commented Feb 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 24, 2022
@woody-apple
Copy link
Contributor

@emargolis ?

@stale stale bot removed the stale Stale issue or PR label Mar 3, 2022
@emargolis emargolis force-pushed the emargolis/feature/add-cats-support branch from 2f4bbc7 to 98f24a0 Compare March 15, 2022 05:23
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #15117: Size comparison from b18b03a to 98f24a0

Increases (3 builds for linux)
platform target config section b18b03a 98f24a0 change % change
linux chip-tool debug (read only) 10095037 10097277 2240 0.0
.rodata 514997 515093 96 0.0
.text 8798789 8800933 2144 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9730028 1936 0.0
(read/write) 475425 475457 32 0.0
.data.rel.ro 371232 371256 24 0.0
.rodata 492196 492324 128 0.0
.text 8186052 8187828 1776 0.0
tv-app debug (read only) 2656097 2657681 1584 0.1
.rodata 204213 204245 32 0.0
.text 2277826 2279378 1552 0.1
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 98f24a0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602578 0 0.0
.app_xip_area 509756 509756 0 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560430 0 0.0
.app_xip_area 469136 469136 0 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570498 0 0.0
.app_xip_area 469556 469556 0 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919652 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919644 919644 0 0.0
BRD4161A+rpc (read only) 948440 948440 0 0.0
(read/write) 144632 144632 0 0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948432 948432 0 0.0
window-app BRD4161A (read only) 850392 850392 0 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850384 850384 0 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961388 0 0.0
(read/write) 1394938 1394938 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 961388 961388 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017011 0 0.0
(read/write) 462148 462148 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226720 0 0.0
.flash.text 1011627 1011627 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699340 0 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614092 0 0.0
lock k32w061+release (read/write) 699644 699644 0 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614384 0 0.0
linux all-clusters-app debug (read only) 2465225 2465225 0 0.0
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2091298 2091298 0 0.0
bridge-app debug+rpc (read only) 1749757 1749757 0 0.0
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143308 143308 0 0.0
.text 1490901 1490901 0 0.0
chip-tool debug (read only) 10095037 10097277 2240 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514997 515093 96 0.0
.text 8798789 8800933 2144 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9730028 1936 0.0
(read/write) 475425 475457 32 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371256 24 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492324 128 0.0
.text 8186052 8187828 1776 0.0
door-lock-app debug (read only) 1984385 1984385 0 0.0
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178396 178396 0 0.0
.text 1657090 1657090 0 0.0
lighting-app debug+rpc (read only) 2115961 2115961 0 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170940 170940 0 0.0
.text 1789106 1789106 0 0.0
ota-provider-app debug (read only) 1918537 1918537 0 0.0
(read/write) 115536 115536 0 0.0
.bss 50816 50816 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164267 164267 0 0.0
.text 1603266 1603266 0 0.0
ota-requestor-app debug (read only) 1949249 1949249 0 0.0
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160452 160452 0 0.0
.text 1637570 1637570 0 0.0
shell debug (read only) 2411385 2411385 0 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207474 207474 0 0.0
.text 2047762 2047762 0 0.0
thermostat-no-ble arm64 (read only) 2207236 2207236 0 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136756 0 0.0
.text 1851168 1851168 0 0.0
tv-app debug (read only) 2656097 2657681 1584 0.1
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204213 204245 32 0.0
.text 2277826 2279378 1552 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154011 0 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 786976 786976 0 0.0
p6 all-clusters-app default (read/write) 2492152 2492152 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450416 0 0.0
light-app default (read/write) 2396000 2396000 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354264 0 0.0
lock-app default (read/write) 2359544 2359544 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893770 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631868 0 0.0

@emargolis emargolis force-pushed the emargolis/feature/add-cats-support branch from 98f24a0 to 2a315dc Compare March 15, 2022 17:53
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #15117: Size comparison from c2b6479 to 2a315dc

Increases (3 builds for linux)
platform target config section c2b6479 2a315dc change % change
linux chip-tool debug (read only) 10095789 10098045 2256 0.0
.rodata 515189 515285 96 0.0
.text 8799349 8801509 2160 0.0
chip-tool-ipv6only arm64 (read only) 9728724 9730660 1936 0.0
(read/write) 475441 475457 16 0.0
.data.rel.ro 371232 371256 24 0.0
.rodata 492252 492380 128 0.0
.text 8186596 8188388 1792 0.0
tv-app debug (read only) 2656433 2658001 1568 0.1
.rodata 204277 204309 32 0.0
.text 2278098 2279634 1536 0.1
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c2b6479 2a315dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602562 602562 0 0.0
.app_xip_area 509668 509668 0 0.0
.bss 75648 75648 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560422 560422 0 0.0
.app_xip_area 469056 469056 0 0.0
.bss 74152 74152 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570490 570490 0 0.0
.app_xip_area 469476 469476 0 0.0
.bss 83456 83456 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919700 919700 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 919692 919692 0 0.0
BRD4161A+rpc (read only) 948488 948488 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 948480 948480 0 0.0
window-app BRD4161A (read only) 850456 850456 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124848 124848 0 0.0
.data 1864 1864 0 0.0
.text 850448 850448 0 0.0
esp32 all-clusters-app c3devkit (read only) 961466 961466 0 0.0
(read/write) 1394978 1394978 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197816 197816 0 0.0
.flash.text 961466 961466 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1016983 1016983 0 0.0
(read/write) 462188 462188 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226760 226760 0 0.0
.flash.text 1011599 1011599 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699324 699324 0 0.0
.bss 77624 77624 0 0.0
.data 1888 1888 0 0.0
.text 614012 614012 0 0.0
lock k32w061+release (read/write) 699628 699628 0 0.0
.bss 77616 77616 0 0.0
.data 1908 1908 0 0.0
.text 614304 614304 0 0.0
linux all-clusters-app debug (read only) 2465449 2465449 0 0.0
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210757 210757 0 0.0
.text 2091458 2091458 0 0.0
bridge-app debug+rpc (read only) 1750077 1750077 0 0.0
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143372 143372 0 0.0
.text 1491157 1491157 0 0.0
chip-tool debug (read only) 10095789 10098045 2256 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 515189 515285 96 0.0
.text 8799349 8801509 2160 0.0
chip-tool-ipv6only arm64 (read only) 9728724 9730660 1936 0.0
(read/write) 475441 475457 16 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371256 24 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492252 492380 128 0.0
.text 8186596 8188388 1792 0.0
door-lock-app debug (read only) 1984609 1984609 0 0.0
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178460 178460 0 0.0
.text 1657250 1657250 0 0.0
lighting-app debug+rpc (read only) 2116185 2116185 0 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 171004 171004 0 0.0
.text 1789266 1789266 0 0.0
ota-provider-app debug (read only) 1919673 1919673 0 0.0
(read/write) 115568 115568 0 0.0
.bss 50848 50848 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164491 164491 0 0.0
.text 1604178 1604178 0 0.0
ota-requestor-app debug (read only) 1949473 1949473 0 0.0
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160516 160516 0 0.0
.text 1637730 1637730 0 0.0
shell debug (read only) 2411593 2411593 0 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207538 207538 0 0.0
.text 2047906 2047906 0 0.0
thermostat-no-ble arm64 (read only) 2207484 2207484 0 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136828 136828 0 0.0
.text 1851344 1851344 0 0.0
tv-app debug (read only) 2656433 2658001 1568 0.1
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204277 204309 32 0.0
.text 2278098 2279634 1536 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352692 2352692 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315292 1315292 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154071 1154071 0 0.0
bss 146724 146724 0 0.0
rodata 145272 145272 0 0.0
text 786916 786916 0 0.0
p6 all-clusters-app default (read/write) 2492136 2492136 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450400 1450400 0 0.0
light-app default (read/write) 2395984 2395984 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354248 1354248 0 0.0
lock-app default (read/write) 2359528 2359528 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317792 1317792 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893762 893762 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631860 631860 0 0.0

@emargolis emargolis force-pushed the emargolis/feature/add-cats-support branch from 2a315dc to 74bf523 Compare March 15, 2022 23:32
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #15117: Size comparison from 046100b to 74bf523

Increases (1 build for linux)
platform target config section 046100b 74bf523 change % change
linux chip-tool-ipv6only arm64 (read only) 9753668 9755620 1952 0.0
(read/write) 475441 475457 16 0.0
.data.rel.ro 371232 371256 24 0.0
.rodata 492348 492492 144 0.0
.text 8211444 8213236 1792 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 046100b 74bf523 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602866 602866 0 0.0
.app_xip_area 509948 509948 0 0.0
.bss 75672 75672 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560654 560654 0 0.0
.app_xip_area 469264 469264 0 0.0
.bss 74176 74176 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570530 570530 0 0.0
.app_xip_area 469492 469492 0 0.0
.bss 83480 83480 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920068 920068 0 0.0
(read/write) 128768 128768 0 0.0
.bss 126760 126760 0 0.0
.data 2008 2008 0 0.0
.text 920060 920060 0 0.0
BRD4161A+rpc (read only) 948872 948872 0 0.0
(read/write) 144728 144728 0 0.0
.bss 142536 142536 0 0.0
.data 2188 2188 0 0.0
.text 948864 948864 0 0.0
window-app BRD4161A (read only) 850816 850816 0 0.0
(read/write) 126728 126728 0 0.0
.bss 124864 124864 0 0.0
.data 1864 1864 0 0.0
.text 850808 850808 0 0.0
esp32 all-clusters-app c3devkit (read only) 961626 961626 0 0.0
(read/write) 1395066 1395066 0 0.0
.dram0.bss 64064 64064 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197904 197904 0 0.0
.flash.text 961626 961626 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017135 1017135 0 0.0
(read/write) 462284 462284 0 0.0
.dram0.bss 69592 69592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226840 226840 0 0.0
.flash.text 1011751 1011751 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699568 699568 0 0.0
.bss 77640 77640 0 0.0
.data 1888 1888 0 0.0
.text 614240 614240 0 0.0
lock k32w061+release (read/write) 699872 699872 0 0.0
.bss 77632 77632 0 0.0
.data 1908 1908 0 0.0
.text 614532 614532 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9753668 9755620 1952 0.0
(read/write) 475441 475457 16 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371256 24 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492492 144 0.0
.text 8211444 8213236 1792 0.0
thermostat-no-ble arm64 (read only) 2207772 2207772 0 0.0
(read/write) 149409 149409 0 0.0
.bss 65681 65681 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136908 136908 0 0.0
.text 1851552 1851552 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352908 2352908 0 0.0
.bss 186660 186660 0 0.0
.data 5752 5752 0 0.0
.text 1315508 1315508 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154267 1154267 0 0.0
bss 146740 146740 0 0.0
rodata 145356 145356 0 0.0
text 787028 787028 0 0.0
p6 all-clusters-app default (read/write) 2492256 2492256 0 0.0
.bss 120088 120088 0 0.0
.data 2632 2632 0 0.0
.text 1450520 1450520 0 0.0
light-app default (read/write) 2396104 2396104 0 0.0
.bss 113552 113552 0 0.0
.data 2488 2488 0 0.0
.text 1354368 1354368 0 0.0
lock-app default (read/write) 2359648 2359648 0 0.0
.bss 113296 113296 0 0.0
.data 2448 2448 0 0.0
.text 1317912 1317912 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894098 894098 0 0.0
bss 87448 87448 0 0.0
noinit 37160 37160 0 0.0
text 632098 632098 0 0.0

@emargolis emargolis force-pushed the emargolis/feature/add-cats-support branch from 74bf523 to e8aba48 Compare March 17, 2022 00:44
@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #15117: Size comparison from ba133af to e8aba48

Increases (3 builds for linux)
platform target config section ba133af e8aba48 change % change
linux chip-tool debug (read only) 10128093 10129565 1472 0.0
.rodata 515765 515893 128 0.0
.text 8830901 8832245 1344 0.0
chip-tool-ipv6only arm64 (read only) 9754676 9756036 1360 0.0
(read/write) 475505 475537 32 0.0
.data.rel.ro 371288 371312 24 0.0
.rodata 492460 492588 128 0.0
.text 8212228 8213428 1200 0.0
tv-app debug (read only) 2670641 2671425 784 0.0
.rodata 205749 205813 64 0.0
.text 2290066 2290786 720 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ba133af e8aba48 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603418 603418 0 0.0
.app_xip_area 510516 510516 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561206 561206 0 0.0
.app_xip_area 469832 469832 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 469988 469988 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920940 920940 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920932 920932 0 0.0
BRD4161A+rpc (read only) 949744 949744 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949736 949736 0 0.0
window-app BRD4161A (read only) 851692 851692 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851684 851684 0 0.0
esp32 all-clusters-app c3devkit (read only) 961328 961328 0 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961328 961328 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017295 1017295 0 0.0
(read/write) 462484 462484 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227056 227056 0 0.0
.flash.text 1011911 1011911 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700096 700096 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614776 614776 0 0.0
lock k32w061+release (read/write) 700392 700392 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615060 615060 0 0.0
linux all-clusters-app debug (read only) 2471889 2471889 0 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210981 210981 0 0.0
.text 2097458 2097458 0 0.0
bridge-app debug+rpc (read only) 1748173 1748173 0 0.0
(read/write) 92752 92752 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143660 143660 0 0.0
.text 1489301 1489301 0 0.0
chip-tool debug (read only) 10128093 10129565 1472 0.0
(read/write) 357752 357752 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324896 324896 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515765 515893 128 0.0
.text 8830901 8832245 1344 0.0
chip-tool-ipv6only arm64 (read only) 9754676 9756036 1360 0.0
(read/write) 475505 475537 32 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371312 24 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492460 492588 128 0.0
.text 8212228 8213428 1200 0.0
door-lock-app debug (read only) 1999321 1999321 0 0.0
(read/write) 120224 120224 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179836 179836 0 0.0
.text 1669826 1669826 0 0.0
lighting-app debug+rpc (read only) 2130969 2130969 0 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172444 172444 0 0.0
.text 1801842 1801842 0 0.0
ota-provider-app debug (read only) 1934385 1934385 0 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165867 165867 0 0.0
.text 1616754 1616754 0 0.0
ota-requestor-app debug (read only) 1964185 1964185 0 0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161892 161892 0 0.0
.text 1650306 1650306 0 0.0
shell debug (read only) 2422081 2422081 0 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208946 208946 0 0.0
.text 2056434 2056434 0 0.0
thermostat-no-ble arm64 (read only) 2220364 2220364 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137772 137772 0 0.0
.text 1862528 1862528 0 0.0
tv-app debug (read only) 2670641 2671425 784 0.0
(read/write) 251224 251224 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205749 205813 64 0.0
.text 2290066 2290786 720 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352364 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1314964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154799 1154799 0 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787376 787376 0 0.0
p6 all-clusters-app default (read/write) 2491648 2491648 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449912 1449912 0 0.0
light-app default (read/write) 2395512 2395512 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353776 1353776 0 0.0
lock-app default (read/write) 2359056 2359056 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317320 1317320 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894938 894938 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632758 632758 0 0.0

@emargolis
Copy link
Contributor Author

@msandstedt PTAL

@emargolis emargolis merged commit a8dcee4 into project-chip:master Mar 23, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@emargolis @andrei-menzopol
Added CASE Authenticated Tag (CAT) Support To the Commissioner APIs. (p…
0ca6d75 
…roject-chip#15117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller darwin examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emargolis @woody-apple @tcarmelveilleux @msandstedt @bzbarsky-apple