Updated PASEVerifier Format to Match Spec. #15070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current SDK implementation the PASEVerifier format is (w0s, w1s). The spec defines PASEVerifier on the device side should have (w0, L) format. This is also the format that devices should store PASEVerifier in the persisted memory. There are some minor changes to adjust to the new implementation. Also updated test vectors and spake2p tool now generates PASEVerifier in a correct format.
|
PR #15070: Size comparison from e02fd60 to 60565ea Increases (16 builds for esp32, linux, mbed, nrfconnect)
Decreases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
balducci-apple
approved these changes
Feb 11, 2022
andy31415
approved these changes
Feb 11, 2022
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Feb 12, 2022
This reverts commit dabb721.
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
In the current SDK implementation the PASEVerifier format is (w0s, w1s). The spec defines PASEVerifier on the device side should have (w0, L) format. This is also the format that devices should store PASEVerifier in the persisted memory. There are some minor changes to adjust to the new implementation. Also updated test vectors and spake2p tool now generates PASEVerifier in a correct format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the current SDK implementation the PASEVerifier format is (w0s, w1s).
The spec defines PASEVerifier on the device side should have (w0, L) format.
This is also the format that devices should store PASEVerifier in the persisted
memory.
Change overview
There are some minor changes to adjust to the new implementation.
Also updated test vectors and spake2p tool now generates PASEVerifier in a correct
format.
Testing
existing tests