-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[binding] Make binding table an attribute #14952
Conversation
abfd361
to
ea45cf5
Compare
2d59c60
to
ba74eff
Compare
PR #14952: Size comparison from 6103a69 to ba74eff Increases above 0.2%:
Increases (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
Decreases (1 build for linux)
Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
ba74eff
to
6042f44
Compare
PR #14952: Size comparison from 6103a69 to 6042f44 Increases above 0.2%:
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for esp32, linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
4f6fb10
to
bcf8a29
Compare
PR #14952: Size comparison from a314baa to bcf8a29 Increases above 0.2%:
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (5 builds for esp32, linux, qpg)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bcf8a29
to
5a8377f
Compare
PR #14952: Size comparison from 18a6458 to 5a8377f Increases above 0.2%:
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (5 builds for esp32, linux, qpg)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
5a8377f
to
f8c4ba7
Compare
PR #14952: Size comparison from 18a6458 to f8c4ba7 Increases above 0.2%:
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (5 builds for esp32, linux, qpg)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14952: Size comparison from 1072c65 to 3dbb57c Increases above 0.2%:
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (5 builds for esp32, linux, qpg)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #14952: Size comparison from e71be1c to d31aa72 Increases above 0.2%:
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (5 builds for esp32, linux, qpg)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
According to the spec the binding table should be an attribute while it's now exposed as commands.
Change overview
bindings.cpp
Testing
How was this tested? (at least one bullet point required)
Run and pair two linux
all-cluster-app
.The read result is correct.
Type
switch on
in node 2 and the command are received in node 1.The read result is correct and the
switch
command cannot control node 1.With another chip-tool on a different fabric:
The binding table can be manipulated correctly on different fabrics.