Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access control logging #14540

Merged
merged 8 commits into from
Feb 1, 2022
Merged

Add access control logging #14540

merged 8 commits into from
Feb 1, 2022

Conversation

mlepage-google
Copy link
Contributor

@mlepage-google mlepage-google commented Jan 28, 2022 •
edited
Loading

Problem

Need a bit of visibility into what access control is doing before
we turn on enforcement.

Change overview

Add a log statement in AccessControl::Check so we can see what
params are being used to do the check.

This looks like:
AccessControl: checking f=1 a=c s=0x0000000000BC5C01 t= c=0x0000_0030 e=0 p=o

With some CATs:
AccessControl: checking f=1 a=c s=0x0000000000BC5C01 t=0xAAAA0001,0xBBBB0002 c=0x0000_0030 e=0 p=o

Where AccessControl::Check is called, if there's an error,
override it for now (grace period) but log it as an error.

This looks like:
AccessControl: overriding DENY (for now)

Progress toward issue #14454

Testing

  • Built all-clusters-app and ran on Linux with REPL
  • Checked logs for expected output

@mlepage-google
Add access control logging
4b838dc 
Add a log statement in AccessControl::Check so we can see what
params are being used to do the check.

This looks like:
AccessControl: checking f=1 a=c s=0xbc5c01 t= c=0x30 e=0 p=o

With some CATs:
AccessControl: checking f=1 a=c s=0xbc5c01 t=0xaaaa0001,0xbbbb0002 c=0x30 e=0 p=o

Where AccessControl::Check is called, if there's an error,
override it for now (grace period) but log it as an error:

This looks like:
AccessControl: overriding DENY (for now)

Progress toward issue project-chip#14454
@boring-cyborg boring-cyborg bot added the app label Jan 28, 2022
@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

PR #14540: Size comparison from e2faf8f to 4b838dc

Increases (27 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section e2faf8f 4b838dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578126 578582 456 0.1
.app_xip_area 484220 484676 456 0.1
lock-app CYW30739 (read/write) 536154 536610 456 0.1
.app_xip_area 443792 444248 456 0.1
efr32 lighting-app BRD4161A (read only) 842968 843624 656 0.1
.text 842960 843616 656 0.1
BRD4161A+rpc (read only) 830320 830976 656 0.1
.text 830312 830968 656 0.1
window-app BRD4161A (read only) 815576 816248 672 0.1
.text 815568 816240 672 0.1
esp32 all-clusters-app c3devkit (read only) 932936 933366 430 0.0
(read/write) 1397322 1397458 136 0.0
.flash.rodata 194480 194616 136 0.1
.flash.text 932936 933366 430 0.0
m5stack (read only) 980831 981199 368 0.0
(read/write) 461692 461812 120 0.0
.flash.rodata 221108 221228 120 0.1
.flash.text 975447 975815 368 0.0
k32w light k32w061+release (read/write) 662956 663412 456 0.1
.text 578860 579316 456 0.1
lock k32w061+release (read/write) 663860 664316 456 0.1
.text 579476 579932 456 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382472 2382936 464 0.0
.text 1345072 1345536 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338200 2338656 456 0.0
.text 1300800 1301256 456 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302240 2302696 456 0.0
.text 1264840 1265296 456 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2292980 2293436 456 0.0
.text 1255552 1256008 456 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981843 468 0.0
rodata 115684 115816 132 0.1
text 668228 668556 328 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 967375 452 0.0
rodata 107160 107292 132 0.1
text 664672 665000 328 0.0
nrf52840dongle_nrf52840 (read/write) 997443 997915 472 0.0
rodata 114516 114652 136 0.1
text 673652 673980 328 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 891014 468 0.1
rodata 108964 109096 132 0.1
text 584416 584752 336 0.1
lock-app nrf52840dk_nrf52840 (read/write) 913971 914439 468 0.1
rodata 104320 104452 132 0.1
text 614224 614552 328 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 824022 824494 472 0.1
rodata 97528 97664 136 0.1
text 531184 531520 336 0.1
pump-app nrf52840dk_nrf52840 (read/write) 916819 917287 468 0.1
rodata 104832 104964 132 0.1
text 616744 617072 328 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 912019 912487 468 0.1
rodata 103936 104068 132 0.1
text 612800 613128 328 0.1
p6 all-clusters-app default (read/write) 2441736 2442408 672 0.0
.text 1400000 1400672 672 0.0
light-app default (read/write) 2338552 2339216 664 0.0
.text 1296816 1297480 664 0.1
lock-app default (read/write) 2304080 2304760 680 0.0
.text 1262344 1263024 680 0.1
qpg lighting-app qpg6105+debug (read only) 570884 570988 104 0.0
.text 565564 565668 104 0.0
lock-app qpg6105+debug (read only) 517012 517116 104 0.0
.text 511692 511796 104 0.0
telink lighting-app tlsr9518adk80d (read/write) 845786 846322 536 0.1
text 592524 592930 406 0.1
Full report (31 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section e2faf8f 4b838dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578126 578582 456 0.1
.app_xip_area 484220 484676 456 0.1
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536154 536610 456 0.1
.app_xip_area 443792 444248 456 0.1
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842968 843624 656 0.1
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 842960 843616 656 0.1
BRD4161A+rpc (read only) 830320 830976 656 0.1
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830312 830968 656 0.1
window-app BRD4161A (read only) 815576 816248 672 0.1
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815568 816240 672 0.1
esp32 all-clusters-app c3devkit (read only) 932936 933366 430 0.0
(read/write) 1397322 1397458 136 0.0
.dram0.bss 69688 69688 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 194480 194616 136 0.1
.flash.text 932936 933366 430 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980831 981199 368 0.0
(read/write) 461692 461812 120 0.0
.dram0.bss 74432 74432 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221108 221228 120 0.1
.flash.text 975447 975815 368 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662956 663412 456 0.1
.bss 76428 76428 0 0.0
.data 1868 1868 0 0.0
.text 578860 579316 456 0.1
lock k32w061+release (read/write) 663860 664316 456 0.1
.bss 76692 76692 0 0.0
.data 1892 1892 0 0.0
.text 579476 579932 456 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382472 2382936 464 0.0
.bss 188588 188588 0 0.0
.data 5288 5288 0 0.0
.text 1345072 1345536 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338200 2338656 456 0.0
.bss 179304 179304 0 0.0
.data 5584 5584 0 0.0
.text 1300800 1301256 456 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302240 2302696 456 0.0
.bss 179208 179208 0 0.0
.data 5552 5552 0 0.0
.text 1264840 1265296 456 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2293436 456 0.0
.bss 176532 176532 0 0.0
.data 5384 5384 0 0.0
.text 1255552 1256008 456 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981843 468 0.0
bss 119660 119660 0 0.0
rodata 115684 115816 132 0.1
text 668228 668556 328 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 967375 452 0.0
bss 116704 116704 0 0.0
rodata 107160 107292 132 0.1
text 664672 665000 328 0.0
nrf52840dongle_nrf52840 (read/write) 997443 997915 472 0.0
bss 120832 120832 0 0.0
rodata 114516 114652 136 0.1
text 673652 673980 328 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 891014 468 0.1
bss 116448 116448 0 0.0
rodata 108964 109096 132 0.1
text 584416 584752 336 0.1
lock-app nrf52840dk_nrf52840 (read/write) 913971 914439 468 0.1
bss 118040 118040 0 0.0
rodata 104320 104452 132 0.1
text 614224 614552 328 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 824022 824494 472 0.1
bss 114856 114856 0 0.0
rodata 97528 97664 136 0.1
text 531184 531520 336 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 917287 468 0.1
bss 117792 117792 0 0.0
rodata 104832 104964 132 0.1
text 616744 617072 328 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 912019 912487 468 0.1
bss 117816 117816 0 0.0
rodata 103936 104068 132 0.1
text 612800 613128 328 0.1
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2441736 2442408 672 0.0
.bss 116740 116740 0 0.0
.data 2584 2584 0 0.0
.text 1400000 1400672 672 0.0
light-app default (read/write) 2338552 2339216 664 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296816 1297480 664 0.1
lock-app default (read/write) 2304080 2304760 680 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262344 1263024 680 0.1
qpg lighting-app qpg6105+debug (read only) 570884 570988 104 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565564 565668 104 0.0
lock-app qpg6105+debug (read only) 517012 517116 104 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511692 511796 104 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845786 846322 536 0.1
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592524 592930 406 0.1

bzbarsky-apple
bzbarsky-apple approved these changes Jan 29, 2022
View reviewed changes
src/access/AccessControl.cpp Outdated Show resolved Hide resolved
src/access/AccessControl.cpp Outdated Show resolved Hide resolved
@mlepage-google
Change log format specifiers
1092a77 
- Use ChipLogFormatX64/ChipLogValueX64
- Use ChipLogFormatMEI/ChipLogValueMEI
@mlepage-google
Change hex format specifier to uppercase
ac1d88d 
May as well match the other ones.
@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #14540: Size comparison from fb256c5 to f688123

Increases (12 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section fb256c5 f688123 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576082 500 0.1
.app_xip_area 482804 483304 500 0.1
lock-app CYW30739 (read/write) 533602 534094 492 0.1
.app_xip_area 442400 442892 492 0.1
k32w light k32w061+release (read/write) 660276 660760 484 0.1
.text 577412 577896 484 0.1
lock k32w061+release (read/write) 661352 661852 500 0.1
.text 578128 578628 500 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987460 1488 0.0
.rodata 387068 387260 192 0.0
.text 6002436 6003732 1296 0.0
thermostat-no-ble arm64 (read only) 2079596 2081084 1488 0.1
.rodata 130252 130444 192 0.1
.text 1732144 1733440 1296 0.1
p6 all-clusters-app default (read/write) 2442616 2443320 704 0.0
.text 1400880 1401584 704 0.1
light-app default (read/write) 2338192 2338880 688 0.0
.text 1296456 1297144 688 0.1
lock-app default (read/write) 2303664 2304368 704 0.0
.text 1261928 1262632 704 0.1
qpg lighting-app qpg6105+debug (read only) 569648 569752 104 0.0
.text 564328 564432 104 0.0
lock-app qpg6105+debug (read only) 515764 515868 104 0.0
.text 510444 510548 104 0.0
telink lighting-app tlsr9518adk80d (read/write) 843362 843938 576 0.1
text 591236 591658 422 0.1
Full report (13 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section fb256c5 f688123 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576082 500 0.1
.app_xip_area 482804 483304 500 0.1
.bss 75524 75524 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 533602 534094 492 0.1
.app_xip_area 442400 442892 492 0.1
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
k32w light k32w061+release (read/write) 660276 660760 484 0.1
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 577412 577896 484 0.1
lock k32w061+release (read/write) 661352 661852 500 0.1
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 578128 578628 500 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987460 1488 0.0
(read/write) 288945 288945 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 184384 184384 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 387068 387260 192 0.0
.text 6002436 6003732 1296 0.0
thermostat-no-ble arm64 (read only) 2079596 2081084 1488 0.1
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74200 74200 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130252 130444 192 0.1
.text 1732144 1733440 1296 0.1
p6 all-clusters-app default (read/write) 2442616 2443320 704 0.0
.bss 116028 116028 0 0.0
.data 2576 2576 0 0.0
.text 1400880 1401584 704 0.1
light-app default (read/write) 2338192 2338880 688 0.0
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1296456 1297144 688 0.1
lock-app default (read/write) 2303664 2304368 704 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1261928 1262632 704 0.1
qpg lighting-app qpg6105+debug (read only) 569648 569752 104 0.0
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564328 564432 104 0.0
lock-app qpg6105+debug (read only) 515764 515868 104 0.0
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 510444 510548 104 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 843362 843938 576 0.1
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 591236 591658 422 0.1

@mlepage-google
Protect log statement helper variables
89ca5f5 
Otherwise, some platforms without logging complain they are unused.
@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #14540: Size comparison from fb256c5 to 89ca5f5

Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fb256c5 89ca5f5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576082 500 0.1
.app_xip_area 482804 483304 500 0.1
lock-app CYW30739 (read/write) 533602 534094 492 0.1
.app_xip_area 442400 442892 492 0.1
efr32 lighting-app BRD4161A (read only) 841496 842192 696 0.1
.text 841488 842184 696 0.1
BRD4161A+rpc (read only) 828856 829560 704 0.1
.text 828848 829552 704 0.1
window-app BRD4161A (read only) 814108 814804 696 0.1
.text 814100 814796 696 0.1
esp32 all-clusters-app c3devkit (read only) 932520 932960 440 0.0
(read/write) 1397882 1398034 152 0.0
.flash.rodata 195744 195896 152 0.1
.flash.text 932520 932960 440 0.0
m5stack (read only) 980491 980871 380 0.0
(read/write) 462248 462384 136 0.0
.flash.rodata 222368 222504 136 0.1
.flash.text 975107 975487 380 0.0
k32w light k32w061+release (read/write) 660276 660760 484 0.1
.text 577412 577896 484 0.1
lock k32w061+release (read/write) 661352 661852 500 0.1
.text 578128 578628 500 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987460 1488 0.0
.rodata 387068 387260 192 0.0
.text 6002436 6003732 1296 0.0
thermostat-no-ble arm64 (read only) 2079596 2081084 1488 0.1
.rodata 130252 130444 192 0.1
.text 1732144 1733440 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382064 2382552 488 0.0
.text 1344664 1345152 488 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2336632 2337104 472 0.0
.text 1299232 1299704 472 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2300736 2301208 472 0.0
.text 1263336 1263808 472 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2291348 2291812 464 0.0
.text 1253920 1254384 464 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 979459 480 0.0
rodata 115464 115608 144 0.1
text 667216 667552 336 0.1
nrf52840dk_nrf52840+rpc (read/write) 964555 965039 484 0.1
rodata 106936 107084 148 0.1
text 663660 663996 336 0.1
nrf52840dongle_nrf52840 (read/write) 995063 995543 480 0.0
rodata 114296 114440 144 0.1
text 672608 672944 336 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 888178 888674 496 0.1
rodata 108740 108884 144 0.1
text 583400 583748 348 0.1
lock-app nrf52840dk_nrf52840 (read/write) 911623 912107 484 0.1
rodata 104100 104248 148 0.1
text 613248 613584 336 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 821670 822170 500 0.1
rodata 97304 97452 148 0.2
text 530212 530560 348 0.1
pump-app nrf52840dk_nrf52840 (read/write) 914495 914979 484 0.1
rodata 104612 104760 148 0.1
text 615772 616108 336 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 910155 484 0.1
rodata 103716 103864 148 0.1
text 611820 612156 336 0.1
p6 all-clusters-app default (read/write) 2442616 2443320 704 0.0
.text 1400880 1401584 704 0.1
light-app default (read/write) 2338192 2338880 688 0.0
.text 1296456 1297144 688 0.1
lock-app default (read/write) 2303664 2304368 704 0.0
.text 1261928 1262632 704 0.1
qpg lighting-app qpg6105+debug (read only) 569648 569752 104 0.0
.text 564328 564432 104 0.0
lock-app qpg6105+debug (read only) 515764 515868 104 0.0
.text 510444 510548 104 0.0
telink lighting-app tlsr9518adk80d (read/write) 843362 843938 576 0.1
text 591236 591658 422 0.1
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fb256c5 89ca5f5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576082 500 0.1
.app_xip_area 482804 483304 500 0.1
.bss 75524 75524 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 533602 534094 492 0.1
.app_xip_area 442400 442892 492 0.1
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 841496 842192 696 0.1
(read/write) 125056 125056 0 0.0
.bss 123160 123160 0 0.0
.data 1892 1892 0 0.0
.text 841488 842184 696 0.1
BRD4161A+rpc (read only) 828856 829560 704 0.1
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1992 0 0.0
.text 828848 829552 704 0.1
window-app BRD4161A (read only) 814108 814804 696 0.1
(read/write) 123684 123684 0 0.0
.bss 121836 121836 0 0.0
.data 1848 1848 0 0.0
.text 814100 814796 696 0.1
esp32 all-clusters-app c3devkit (read only) 932520 932960 440 0.0
(read/write) 1397882 1398034 152 0.0
.dram0.bss 68968 68968 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195744 195896 152 0.1
.flash.text 932520 932960 440 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980491 980871 380 0.0
(read/write) 462248 462384 136 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222368 222504 136 0.1
.flash.text 975107 975487 380 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660276 660760 484 0.1
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 577412 577896 484 0.1
lock k32w061+release (read/write) 661352 661852 500 0.1
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 578128 578628 500 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987460 1488 0.0
(read/write) 288945 288945 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 184384 184384 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 387068 387260 192 0.0
.text 6002436 6003732 1296 0.0
thermostat-no-ble arm64 (read only) 2079596 2081084 1488 0.1
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74200 74200 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130252 130444 192 0.1
.text 1732144 1733440 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382064 2382552 488 0.0
.bss 187884 187884 0 0.0
.data 5288 5288 0 0.0
.text 1344664 1345152 488 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336632 2337104 472 0.0
.bss 178160 178160 0 0.0
.data 5568 5568 0 0.0
.text 1299232 1299704 472 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300736 2301208 472 0.0
.bss 178040 178040 0 0.0
.data 5544 5544 0 0.0
.text 1263336 1263808 472 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291348 2291812 464 0.0
.bss 175316 175316 0 0.0
.data 5368 5368 0 0.0
.text 1253920 1254384 464 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 979459 480 0.0
bss 118528 118528 0 0.0
rodata 115464 115608 144 0.1
text 667216 667552 336 0.1
nrf52840dk_nrf52840+rpc (read/write) 964555 965039 484 0.1
bss 115572 115572 0 0.0
rodata 106936 107084 148 0.1
text 663660 663996 336 0.1
nrf52840dongle_nrf52840 (read/write) 995063 995543 480 0.0
bss 119700 119700 0 0.0
rodata 114296 114440 144 0.1
text 672608 672944 336 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 888178 888674 496 0.1
bss 115316 115316 0 0.0
rodata 108740 108884 144 0.1
text 583400 583748 348 0.1
lock-app nrf52840dk_nrf52840 (read/write) 911623 912107 484 0.1
bss 116888 116888 0 0.0
rodata 104100 104248 148 0.1
text 613248 613584 336 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 821670 822170 500 0.1
bss 113704 113704 0 0.0
rodata 97304 97452 148 0.2
text 530212 530560 348 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914495 914979 484 0.1
bss 116644 116644 0 0.0
rodata 104612 104760 148 0.1
text 615772 616108 336 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 910155 484 0.1
bss 116652 116652 0 0.0
rodata 103716 103864 148 0.1
text 611820 612156 336 0.1
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2442616 2443320 704 0.0
.bss 116028 116028 0 0.0
.data 2576 2576 0 0.0
.text 1400880 1401584 704 0.1
light-app default (read/write) 2338192 2338880 688 0.0
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1296456 1297144 688 0.1
lock-app default (read/write) 2303664 2304368 704 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1261928 1262632 704 0.1
qpg lighting-app qpg6105+debug (read only) 569648 569752 104 0.0
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564328 564432 104 0.0
lock-app qpg6105+debug (read only) 515764 515868 104 0.0
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 510444 510548 104 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 843362 843938 576 0.1
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 591236 591658 422 0.1

@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #14540: Size comparison from fb256c5 to 24de71e

Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fb256c5 24de71e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576082 500 0.1
.app_xip_area 482804 483304 500 0.1
lock-app CYW30739 (read/write) 533602 534094 492 0.1
.app_xip_area 442400 442892 492 0.1
efr32 lighting-app BRD4161A (read only) 841496 842192 696 0.1
.text 841488 842184 696 0.1
BRD4161A+rpc (read only) 828856 829560 704 0.1
.text 828848 829552 704 0.1
window-app BRD4161A (read only) 814108 814804 696 0.1
.text 814100 814796 696 0.1
esp32 all-clusters-app c3devkit (read only) 932520 932960 440 0.0
(read/write) 1397882 1398034 152 0.0
.flash.rodata 195744 195896 152 0.1
.flash.text 932520 932960 440 0.0
m5stack (read only) 980491 980871 380 0.0
(read/write) 462248 462384 136 0.0
.flash.rodata 222368 222504 136 0.1
.flash.text 975107 975487 380 0.0
k32w light k32w061+release (read/write) 660276 660760 484 0.1
.text 577412 577896 484 0.1
lock k32w061+release (read/write) 661352 661852 500 0.1
.text 578128 578628 500 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987460 1488 0.0
.rodata 387068 387260 192 0.0
.text 6002436 6003732 1296 0.0
thermostat-no-ble arm64 (read only) 2079596 2081084 1488 0.1
.rodata 130252 130444 192 0.1
.text 1732144 1733440 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382064 2382552 488 0.0
.text 1344664 1345152 488 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2336632 2337104 472 0.0
.text 1299232 1299704 472 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2300736 2301208 472 0.0
.text 1263336 1263808 472 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2291348 2291812 464 0.0
.text 1253920 1254384 464 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 979459 480 0.0
rodata 115464 115608 144 0.1
text 667216 667552 336 0.1
nrf52840dk_nrf52840+rpc (read/write) 964555 965039 484 0.1
rodata 106936 107084 148 0.1
text 663660 663996 336 0.1
nrf52840dongle_nrf52840 (read/write) 995063 995543 480 0.0
rodata 114296 114440 144 0.1
text 672608 672944 336 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 888178 888674 496 0.1
rodata 108740 108884 144 0.1
text 583400 583748 348 0.1
lock-app nrf52840dk_nrf52840 (read/write) 911623 912107 484 0.1
rodata 104100 104248 148 0.1
text 613248 613584 336 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 821670 822170 500 0.1
rodata 97304 97452 148 0.2
text 530212 530560 348 0.1
pump-app nrf52840dk_nrf52840 (read/write) 914495 914979 484 0.1
rodata 104612 104760 148 0.1
text 615772 616108 336 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 910155 484 0.1
rodata 103716 103864 148 0.1
text 611820 612156 336 0.1
p6 all-clusters-app default (read/write) 2442616 2443320 704 0.0
.text 1400880 1401584 704 0.1
light-app default (read/write) 2338192 2338880 688 0.0
.text 1296456 1297144 688 0.1
lock-app default (read/write) 2303664 2304368 704 0.0
.text 1261928 1262632 704 0.1
qpg lighting-app qpg6105+debug (read only) 569648 569752 104 0.0
.text 564328 564432 104 0.0
lock-app qpg6105+debug (read only) 515764 515868 104 0.0
.text 510444 510548 104 0.0
telink lighting-app tlsr9518adk80d (read/write) 843362 843938 576 0.1
text 591236 591658 422 0.1
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fb256c5 24de71e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576082 500 0.1
.app_xip_area 482804 483304 500 0.1
.bss 75524 75524 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 533602 534094 492 0.1
.app_xip_area 442400 442892 492 0.1
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 841496 842192 696 0.1
(read/write) 125056 125056 0 0.0
.bss 123160 123160 0 0.0
.data 1892 1892 0 0.0
.text 841488 842184 696 0.1
BRD4161A+rpc (read only) 828856 829560 704 0.1
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1992 0 0.0
.text 828848 829552 704 0.1
window-app BRD4161A (read only) 814108 814804 696 0.1
(read/write) 123684 123684 0 0.0
.bss 121836 121836 0 0.0
.data 1848 1848 0 0.0
.text 814100 814796 696 0.1
esp32 all-clusters-app c3devkit (read only) 932520 932960 440 0.0
(read/write) 1397882 1398034 152 0.0
.dram0.bss 68968 68968 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195744 195896 152 0.1
.flash.text 932520 932960 440 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980491 980871 380 0.0
(read/write) 462248 462384 136 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222368 222504 136 0.1
.flash.text 975107 975487 380 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660276 660760 484 0.1
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 577412 577896 484 0.1
lock k32w061+release (read/write) 661352 661852 500 0.1
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 578128 578628 500 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987460 1488 0.0
(read/write) 288945 288945 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 184384 184384 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 387068 387260 192 0.0
.text 6002436 6003732 1296 0.0
thermostat-no-ble arm64 (read only) 2079596 2081084 1488 0.1
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74200 74200 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130252 130444 192 0.1
.text 1732144 1733440 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382064 2382552 488 0.0
.bss 187884 187884 0 0.0
.data 5288 5288 0 0.0
.text 1344664 1345152 488 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336632 2337104 472 0.0
.bss 178160 178160 0 0.0
.data 5568 5568 0 0.0
.text 1299232 1299704 472 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300736 2301208 472 0.0
.bss 178040 178040 0 0.0
.data 5544 5544 0 0.0
.text 1263336 1263808 472 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291348 2291812 464 0.0
.bss 175316 175316 0 0.0
.data 5368 5368 0 0.0
.text 1253920 1254384 464 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 979459 480 0.0
bss 118528 118528 0 0.0
rodata 115464 115608 144 0.1
text 667216 667552 336 0.1
nrf52840dk_nrf52840+rpc (read/write) 964555 965039 484 0.1
bss 115572 115572 0 0.0
rodata 106936 107084 148 0.1
text 663660 663996 336 0.1
nrf52840dongle_nrf52840 (read/write) 995063 995543 480 0.0
bss 119700 119700 0 0.0
rodata 114296 114440 144 0.1
text 672608 672944 336 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 888178 888674 496 0.1
bss 115316 115316 0 0.0
rodata 108740 108884 144 0.1
text 583400 583748 348 0.1
lock-app nrf52840dk_nrf52840 (read/write) 911623 912107 484 0.1
bss 116888 116888 0 0.0
rodata 104100 104248 148 0.1
text 613248 613584 336 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 821670 822170 500 0.1
bss 113704 113704 0 0.0
rodata 97304 97452 148 0.2
text 530212 530560 348 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914495 914979 484 0.1
bss 116644 116644 0 0.0
rodata 104612 104760 148 0.1
text 615772 616108 336 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 910155 484 0.1
bss 116652 116652 0 0.0
rodata 103716 103864 148 0.1
text 611820 612156 336 0.1
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2442616 2443320 704 0.0
.bss 116028 116028 0 0.0
.data 2576 2576 0 0.0
.text 1400880 1401584 704 0.1
light-app default (read/write) 2338192 2338880 688 0.0
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1296456 1297144 688 0.1
lock-app default (read/write) 2303664 2304368 704 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1261928 1262632 704 0.1
qpg lighting-app qpg6105+debug (read only) 569648 569752 104 0.0
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564328 564432 104 0.0
lock-app qpg6105+debug (read only) 515764 515868 104 0.0
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 510444 510548 104 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 843362 843938 576 0.1
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 591236 591658 422 0.1

@mlepage-google mlepage-google merged commit c25c90d into project-chip:master Feb 1, 2022
@mlepage-google mlepage-google deleted the access-control-logging branch February 1, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlepage-google @andy31415 @msandstedt @bzbarsky-apple