-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend chip-tool to support Bridged Device Basic Information Cluster #14440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Jan 27, 2022
PR #14440: Size comparison from e842eb9 to 93ca54a Increases above 0.2%:
Increases (5 builds for esp32, linux, mbed, p6)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
@pjzander-signify Needs a rebase/merge to tip? |
dhrishi
reviewed
Jan 28, 2022
dhrishi
approved these changes
Jan 28, 2022
93ca54a
to
2882f00
Compare
PR #14440: Size comparison from d2fded9 to 2882f00 Increases above 0.2%:
Increases (5 builds for esp32, linux, mbed, p6)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
lzgrablic02
reviewed
Jan 29, 2022
2882f00
to
56e2651
Compare
PR #14440: Size comparison from 8b503ad to 56e2651 Increases above 0.2%:
Increases (8 builds for esp32, linux, mbed, p6)
Full report (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Feb 1, 2022
andy31415
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #14309
Change overview
Updates 2 zap files and the zap generated file.
Testing
Verified that the attributes are now supported.