Fix for the non-determinism issue on Command handler and Outgoing Commands #13871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #13871: Size comparison from 9f1c7e5 to 7d1ac66 Increases (1 build for linux)
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
Got rid of the incorrect third_party changes.
|
PR #13871: Size comparison from 9fc0d2e to 50d15d5 Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 28, 2022
andy31415
reviewed
Jan 28, 2022
examples/light-switch-app/light-switch-common/light-switch-app.matter
Outdated
Show resolved
Hide resolved
|
PR #13871: Size comparison from 9fc0d2e to 19f684d Decreases (1 build for linux)
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
|
Note that at this point #14581 will remove some (but not all!) of the bits being changed in this PR.... |
andy31415
approved these changes
Feb 1, 2022
Seems like the CHIPCluster and CHIPClientCallback templates are going away. Those are still non deterministic. Should I continue looking into fixing that? |
…oing commands are generated with determinism. Using the upto date helpers in the *.zapt templates Currently pointing to a zap repo which has new helpers as well. These changes have not been merged into the github zap repo gihub#342
…de only. - All commands originating on the server sides are response commands which do not need to be generated here Github#342
…nts_with_structs_expanded - Applying changes to chip_cluster_command_arguments_with_structs_expanded such that it can be used within all_outgoing_commands_for_cluster block helper instead of chip_cluster_command_arguments - Github#342
…t we generated before Github#342
…-mfg specific clusters and commands Github#342
…se there is code which depends on this generated code Github#342
…_commands in CHIPClusters-src.zapt just like we do in CHIPClusters.zapt to maintain consistency Also reverting the changes in helper.js since those are no longer required Github#342
Github#342
…upstream master Github#342
Github#342
…ch that request struct should be defined for all incoming commands from client to server and outgoing commands from client to server Github#342
…uch that response struct should be defined for all incoming commands from server to client and outgoing commands from server to client Github#342
Github#342
|
PR #13871: Size comparison from 8bb93af to a479437 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Feb 2, 2022
| IasZoneType zoneType = 0; | ||
| INT16U manufacturerCode = 1; | ||
| } | ||
|
|
||
| request struct ZoneStatusChangeNotificationRequest { | ||
| response struct ZoneStatusChangeNotification { |
There was a problem hiding this comment.
We seem to have removed ZoneEndrollResponse, however that response is used in the command ZoneEnrollREquest.
Also the name of the command argument is 'ZoneEnrollRequestRequest' and above the struct is defined with the wrong name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pointing to a zap repo which has new helpers as well. These changes have not been merged into the github zap repo
gihub#342
Problem
What is being fixed?
Change overview
Changes to ZAP generation templates: CHIPClusters.*zapt, im-cluster-command-handler.zapt to generate code accurately.
This PR depends on the following ZAP PR:
project-chip/zap#388
Testing
How was this tested? (at least one bullet point required)
Regened multiple times to check that the CHIPClusters and im-cluster-command-handler generated files did not change across regens.