[op-creds] Fix RemoveFabric command #13869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemoveFabric command called for the fabric that is used to process the message crashes in SessionHolder. The reason is that sessions for the removed fabric are expired when the command's exchange is closed after sending the response and that triggers closing all associated session holders. An exchange's session holder closes the exchange which in this case results in an attempt to close an exchange that is in the middle of closing...
|
@bzbarsky-apple Not sure if that can be considered a fix for #9642 or we would actually prefer keeping the MRP for |
|
PR #13869: Size comparison from 1b49aee to bc49db9 Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
No response at all after deletion of the fabric carrying the session should be possible because to respond requires the use of keys after they were supposed to have been removed. From the client side, I would expect this to look like timeout. From the description, it sounds like this PR does result in this behavior. |
bzbarsky-apple
approved these changes
Jan 25, 2022
woody-apple
approved these changes
Jan 26, 2022
yufengwangca
approved these changes
Jan 26, 2022
LuDuda
approved these changes
Jan 26, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
RemoveFabric command called for the fabric that is used to process the message crashes in SessionHolder. The reason is that sessions for the removed fabric are expired when the command's exchange is closed after sending the response and that triggers closing all associated session holders. An exchange's session holder closes the exchange which in this case results in an attempt to close an exchange that is in the middle of closing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RemoveFabric command called for the fabric that is used to process the message crashes in SessionHolder:
The reason is that sessions for the removed fabric are expired when the command's exchange is closed after sending the response and that triggers closing all associated session holders. An exchange's session holder closes the exchange which in this case results in an attempt to close an exchange that is in the middle of closing...
Change overview
Testing
Tested manually on nRF Connect examples that commissioning + RemoveFabric commands don't crash the firmware.