Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mrp] Inline ReliableMessageContext getters and setters #13865

Merged
merged 1 commit into from
Jan 24, 2022
Merged

[mrp] Inline ReliableMessageContext getters and setters #13865

merged 1 commit into from
Jan 24, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

I noticed that inlining ReliableMessgeContext getters & setters reduces the code size a bit.

Change overview

Move ReliableMessgeContext getters & setters to the header.

Testing

CI only.

@Damian-Nordic
[mrp] Inline ReliableMessageContext getters and setters
f4068da 
These are very simple methods, so inlining them reduces the
code size.
@github-actions
Copy link

github-actions bot commented Jan 24, 2022 •
edited
Loading

PR #13865: Size comparison from e25a501 to f4068da

Decreases (28 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section e25a501 f4068da change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574390 574158 -232 -0.0
.app_xip_area 479404 479172 -232 -0.0
efr32 lighting-app BRD4161A (read only) 835916 835756 -160 -0.0
.text 835908 835748 -160 -0.0
BRD4161A+rpc (read only) 823336 823160 -176 -0.0
.text 823328 823152 -176 -0.0
window-app BRD4161A (read only) 806476 806300 -176 -0.0
.text 806468 806292 -176 -0.0
esp32 all-clusters-app c3devkit (read only) 918984 918782 -202 -0.0
.flash.text 918984 918782 -202 -0.0
m5stack (read only) 967431 967103 -328 -0.0
.flash.text 962047 961719 -328 -0.0
k32w light k32w061+release (read/write) 660588 660364 -224 -0.0
.text 576312 576088 -224 -0.0
lock k32w061+release (read/write) 661312 661088 -224 -0.0
.text 576776 576552 -224 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2352184 2351928 -256 -0.0
.text 1314760 1314504 -256 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2334408 2334216 -192 -0.0
.text 1297008 1296816 -192 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304760 2304568 -192 -0.0
.text 1267360 1267168 -192 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054256 2054000 -256 -0.0
.text 1016856 1016600 -256 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942879 942655 -224 -0.0
text 637312 637088 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 928347 928123 -224 -0.0
text 632708 632484 -224 -0.0
nrf52840dongle_nrf52840 (read/write) 993527 993303 -224 -0.0
text 669512 669288 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852706 852482 -224 -0.0
text 554232 554008 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912223 911999 -224 -0.0
text 612756 612532 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822294 822070 -224 -0.0
text 529712 529488 -224 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 915083 914859 -224 -0.0
text 615404 615180 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910267 910043 -224 -0.0
text 611428 611204 -224 -0.0
shell nrf52840dk_nrf52840 (read/write) 798527 798303 -224 -0.0
text 533928 533704 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711342 711118 -224 -0.0
text 451608 451384 -224 -0.0
p6 all-clusters-app default (read/write) 2410664 2410488 -176 -0.0
.text 1368928 1368752 -176 -0.0
light-app default (read/write) 2330736 2330576 -160 -0.0
.text 1289000 1288840 -160 -0.0
lock-app default (read/write) 2299752 2299576 -176 -0.0
.text 1258016 1257840 -176 -0.0
qpg lighting-app qpg6105+debug (read only) 567476 567252 -224 -0.0
.text 562156 561932 -224 -0.0
lock-app qpg6105+debug (read only) 515904 515680 -224 -0.0
.text 510584 510360 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 841718 841494 -224 -0.0
text 588346 588122 -224 -0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e25a501 f4068da change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574390 574158 -232 -0.0
.app_xip_area 479404 479172 -232 -0.0
.bss 77724 77724 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835916 835756 -160 -0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 835908 835748 -160 -0.0
BRD4161A+rpc (read only) 823336 823160 -176 -0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 823328 823152 -176 -0.0
window-app BRD4161A (read only) 806476 806300 -176 -0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 806468 806292 -176 -0.0
esp32 all-clusters-app c3devkit (read only) 918984 918782 -202 -0.0
(read/write) 1383434 1383434 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 179344 179344 0 0.0
.flash.text 918984 918782 -202 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967431 967103 -328 -0.0
(read/write) 449852 449852 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208508 208508 0 0.0
.flash.text 962047 961719 -328 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660588 660364 -224 -0.0
.bss 76608 76608 0 0.0
.data 1868 1868 0 0.0
.text 576312 576088 -224 -0.0
lock k32w061+release (read/write) 661312 661088 -224 -0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576776 576552 -224 -0.0
linux chip-tool-ipv6only arm64 (read only) 8536964 8536964 0 0.0
(read/write) 391009 391009 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261032 261032 0 0.0
.dynamic 560 560 0 0.0
.got 69056 69056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 436908 436908 0 0.0
.text 7261028 7261028 0 0.0
thermostat-no-ble arm64 (read only) 2051916 2051916 0 0.0
(read/write) 145697 145697 0 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130700 130700 0 0.0
.text 1706720 1706720 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352184 2351928 -256 -0.0
.bss 189428 189428 0 0.0
.data 5304 5304 0 0.0
.text 1314760 1314504 -256 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334408 2334216 -192 -0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1297008 1296816 -192 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304760 2304568 -192 -0.0
.bss 179960 179960 0 0.0
.data 5560 5560 0 0.0
.text 1267360 1267168 -192 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054000 -256 -0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016600 -256 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942879 942655 -224 -0.0
bss 119044 119044 0 0.0
rodata 108916 108916 0 0.0
text 637312 637088 -224 -0.0
nrf52840dk_nrf52840+rpc (read/write) 928347 928123 -224 -0.0
bss 116088 116088 0 0.0
rodata 101368 101368 0 0.0
text 632708 632484 -224 -0.0
nrf52840dongle_nrf52840 (read/write) 993527 993303 -224 -0.0
bss 121884 121884 0 0.0
rodata 113672 113672 0 0.0
text 669512 669288 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852706 852482 -224 -0.0
bss 115828 115828 0 0.0
rodata 102092 102092 0 0.0
text 554232 554008 -224 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912223 911999 -224 -0.0
bss 118196 118196 0 0.0
rodata 103884 103884 0 0.0
text 612756 612532 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822294 822070 -224 -0.0
bss 115016 115016 0 0.0
rodata 97112 97112 0 0.0
text 529712 529488 -224 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915083 914859 -224 -0.0
bss 117960 117960 0 0.0
rodata 104248 104248 0 0.0
text 615404 615180 -224 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910267 910043 -224 -0.0
bss 117984 117984 0 0.0
rodata 103400 103400 0 0.0
text 611428 611204 -224 -0.0
shell nrf52840dk_nrf52840 (read/write) 798527 798303 -224 -0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533928 533704 -224 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711342 711118 -224 -0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451608 451384 -224 -0.0
p6 all-clusters-app default (read/write) 2410664 2410488 -176 -0.0
.bss 117772 117772 0 0.0
.data 2584 2584 0 0.0
.text 1368928 1368752 -176 -0.0
light-app default (read/write) 2330736 2330576 -160 -0.0
.bss 105544 105544 0 0.0
.data 2408 2408 0 0.0
.text 1289000 1288840 -160 -0.0
lock-app default (read/write) 2299752 2299576 -176 -0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1258016 1257840 -176 -0.0
qpg lighting-app qpg6105+debug (read only) 567476 567252 -224 -0.0
(read/write) 146940 146940 0 0.0
.bss 89688 89688 0 0.0
.data 1064 1064 0 0.0
.text 562156 561932 -224 -0.0
lock-app qpg6105+debug (read only) 515904 515680 -224 -0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510584 510360 -224 -0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841718 841494 -224 -0.0
bss 87492 87492 0 0.0
noinit 37160 37160 0 0.0
text 588346 588122 -224 -0.0

@andy31415
Copy link
Contributor

fast track: simple refactor with bots reporting size benefits.

@andy31415 andy31415 merged commit 4856390 into project-chip:master Jan 24, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@Damian-Nordic @selissia
[mrp] Inline ReliableMessageContext getters and setters (project-chip…
dd7154d 
…#13865)

These are very simple methods, so inlining them reduces the
code size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@emargolis emargolis emargolis approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Damian-Nordic @andy31415 @msandstedt @emargolis