-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow null NetworkCredentials in commissionDevice() #13655
Merged
andy31415
merged 1 commit into
project-chip:master
from
g-coppock:pr/coppock/allow_null_credentials
Jan 18, 2022
Merged
Allow null NetworkCredentials in commissionDevice() #13655
andy31415
merged 1 commit into
project-chip:master
from
g-coppock:pr/coppock/allow_null_credentials
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For IP commissioning, no credentials should be added, but currently the Java layer requires either a Thread or Wi-Fi network. The underlying commissioner logic already has safeguards to ensure that a network is provided unless we are doing IP commissioning.
e167248
to
2ec4e56
Compare
mspang
approved these changes
Jan 18, 2022
PR #13655: Size comparison from be806bb to 2ec4e56 Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 18, 2022
fast track: platform specific change |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
For IP commissioning, no credentials should be added, but currently the Java layer requires either a Thread or Wi-Fi network. The underlying commissioner logic already has safeguards to ensure that a network is provided unless we are doing IP commissioning.
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
For IP commissioning, no credentials should be added, but currently the Java layer requires either a Thread or Wi-Fi network. The underlying commissioner logic already has safeguards to ensure that a network is provided unless we are doing IP commissioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IP commissioning, no credentials should be added, but currently the
Java layer requires either a Thread or Wi-Fi network. The underlying
commissioner logic already has safeguards to ensure that a network is
provided unless we are doing IP commissioning.
Testing
Tested locally, providing null credentials during IP commissioning on Android