Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean up] Remove unused helper method. #13597

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

turon
Copy link
Contributor

@turon turon commented Jan 14, 2022

Problem

Identified a small unused method

Change overview

Remove unused method

Testing

build and CI

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

PR #13597: Size comparison from 45214cf to c8c1576

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 45214cf c8c1576 change % change
efr32 lighting-app BRD4161A (read only) 832780 832780 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 832772 832772 0 0.0
BRD4161A+rpc (read only) 820200 820200 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 820192 820192 0 0.0
window-app BRD4161A (read only) 805440 805440 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805432 805432 0 0.0
esp32 all-clusters-app c3devkit (read only) 910038 910038 0 0.0
(read/write) 1316506 1316506 0 0.0
.dram0.bss 70504 70504 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178224 178224 0 0.0
.flash.text 910038 910038 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959023 959023 0 0.0
(read/write) 448672 448672 0 0.0
.dram0.bss 74976 74976 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207504 207504 0 0.0
.flash.text 953639 953639 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 657920 657920 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 573132 573132 0 0.0
lock k32w061+release (read/write) 661604 661604 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576500 576500 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8038948 8038948 0 0.0
(read/write) 370497 370497 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245760 245760 0 0.0
.dynamic 560 560 0 0.0
.got 64728 64728 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419292 419292 0 0.0
.text 6830996 6830996 0 0.0
thermostat-no-ble arm64 (read only) 2042108 2042108 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697632 1697632 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347896 2347896 0 0.0
.bss 189204 189204 0 0.0
.data 5320 5320 0 0.0
.text 1310472 1310472 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332480 2332480 0 0.0
.bss 180752 180752 0 0.0
.data 5560 5560 0 0.0
.text 1295080 1295080 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304656 2304656 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267256 1267256 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2054464 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1017064 1017064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941399 941399 0 0.0
bss 119624 119624 0 0.0
rodata 108660 108660 0 0.0
text 635532 635532 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926879 926879 0 0.0
bss 116668 116668 0 0.0
rodata 101108 101108 0 0.0
text 630924 630924 0 0.0
nrf52840dongle_nrf52840 (read/write) 992043 992043 0 0.0
bss 122464 122464 0 0.0
rodata 113412 113412 0 0.0
text 667728 667728 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851222 851222 0 0.0
bss 116412 116412 0 0.0
rodata 101832 101832 0 0.0
text 552452 552452 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912571 912571 0 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612628 612628 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822638 822638 0 0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529592 529592 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913959 913959 0 0.0
bss 118544 118544 0 0.0
rodata 104004 104004 0 0.0
text 613956 613956 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910715 910715 0 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611412 611412 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 798655 0 0.0
bss 109776 109776 0 0.0
rodata 78388 78388 0 0.0
text 533992 533992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711470 711470 0 0.0
bss 107664 107664 0 0.0
rodata 72688 72688 0 0.0
text 451672 451672 0 0.0
p6 all-clusters-app default (read/write) 2402336 2402336 0 0.0
.bss 117484 117484 0 0.0
.data 2592 2592 0 0.0
.text 1360600 1360600 0 0.0
light-app default (read/write) 2327560 2327560 0 0.0
.bss 106064 106064 0 0.0
.data 2392 2392 0 0.0
.text 1285824 1285824 0 0.0
lock-app default (read/write) 2298472 2298472 0 0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256736 1256736 0 0.0
qpg lighting-app qpg6105+debug (read only) 561976 561976 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89952 89952 0 0.0
.data 1044 1044 0 0.0
.text 556656 556656 0 0.0
lock-app qpg6105+debug (read only) 515292 515292 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 509972 509972 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838470 838470 0 0.0
bss 87312 87312 0 0.0
noinit 37160 37160 0 0.0
text 585624 585624 0 0.0

@andy31415 andy31415 merged commit 3354032 into project-chip:master Jan 15, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants