Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current time during CASE session handshake #13462

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Use current time during CASE session handshake #13462

merged 1 commit into from
Jan 11, 2022

Conversation

pan-apple
Copy link
Contributor

Problem

Change overview

Use SystemClock to get the current time. If the API is not supported for the platform, it'll currently print an error log, but use the hardcoded time.

Testing

Ran TestCASESession to ensure the CASE session setup continues to work.

@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

PR #13462: Size comparison from 5b5d6c1 to d86e226

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5b5d6c1 d86e226 change % change
efr32 lighting-app BRD4161A (read only) 830240 830468 228 0.0
.text 830232 830460 228 0.0
BRD4161A+rpc (read only) 817644 817872 228 0.0
(read/write) 143960 143964 4 0.0
.text 817636 817864 228 0.0
window-app BRD4161A (read only) 804184 804412 228 0.0
.text 804176 804404 228 0.0
esp32 all-clusters-app c3devkit (read only) 898316 898450 134 0.0
(read/write) 1316082 1316202 120 0.0
.flash.rodata 178200 178320 120 0.1
.flash.text 898316 898450 134 0.0
m5stack (read only) 959427 959543 116 0.0
(read/write) 448536 448656 120 0.0
.flash.rodata 207688 207808 120 0.1
.flash.text 954043 954159 116 0.0
k32w light k32w061+release (read/write) 656348 656588 240 0.0
.text 571872 572112 240 0.0
lock k32w061+release (read/write) 660688 660928 240 0.0
.text 575896 576136 240 0.0
linux chip-tool-ipv6only arm64 (read only) 7114060 7114748 688 0.0
.rodata 390148 390276 128 0.0
.text 6026020 6026580 560 0.0
thermostat-no-ble arm64 (read only) 2037468 2038140 672 0.0
.rodata 129276 129388 112 0.1
.text 1693888 1694448 560 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348912 2349160 248 0.0
.text 1311488 1311736 248 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330560 2330800 240 0.0
.text 1293160 1293400 240 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2303784 2303960 176 0.0
.text 1266384 1266560 176 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939279 939507 228 0.0
rodata 108332 108448 116 0.1
text 634088 634204 116 0.0
nrf52840dk_nrf52840+rpc (read/write) 924747 924971 224 0.0
rodata 100784 100896 112 0.1
text 629440 629556 116 0.0
nrf52840dongle_nrf52840 (read/write) 989939 990183 244 0.0
rodata 113084 113200 116 0.1
text 666284 666400 116 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849138 849366 228 0.0
rodata 101508 101624 116 0.1
text 551008 551124 116 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911551 911779 228 0.0
rodata 103604 103720 116 0.1
text 612080 612196 116 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821590 821814 224 0.0
rodata 96832 96944 112 0.1
text 529040 529156 116 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912831 913059 228 0.0
rodata 103820 103936 116 0.1
text 613340 613456 116 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909631 909859 228 0.0
rodata 103076 103192 116 0.1
text 610828 610944 116 0.0
p6 all-clusters-app default (read/write) 2403200 2403424 224 0.0
.text 1361464 1361688 224 0.0
light-app default (read/write) 2325088 2325336 248 0.0
.text 1283352 1283600 248 0.0
lock-app default (read/write) 2297320 2297544 224 0.0
.text 1255584 1255808 224 0.0
qpg lighting-app qpg6105+debug (read only) 534060 534284 224 0.0
.text 528740 528964 224 0.0
lock-app qpg6105+debug (read only) 505980 506204 224 0.0
.text 500660 500884 224 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 836122 244 0.0
text 583752 583880 128 0.0
Decreases (1 build for efr32)
platform target config section 5b5d6c1 d86e226 change % change
efr32 window-app BRD4161A (read/write) 126008 126004 -4 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5b5d6c1 d86e226 change % change
efr32 lighting-app BRD4161A (read only) 830240 830468 228 0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830232 830460 228 0.0
BRD4161A+rpc (read only) 817644 817872 228 0.0
(read/write) 143960 143964 4 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817636 817864 228 0.0
window-app BRD4161A (read only) 804184 804412 228 0.0
(read/write) 126008 126004 -4 -0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804176 804404 228 0.0
esp32 all-clusters-app c3devkit (read only) 898316 898450 134 0.0
(read/write) 1316082 1316202 120 0.0
.dram0.bss 70168 70168 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 178200 178320 120 0.1
.flash.text 898316 898450 134 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959427 959543 116 0.0
(read/write) 448536 448656 120 0.0
.dram0.bss 74656 74656 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207688 207808 120 0.1
.flash.text 954043 954159 116 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656348 656588 240 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571872 572112 240 0.0
lock k32w061+release (read/write) 660688 660928 240 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575896 576136 240 0.0
linux chip-tool-ipv6only arm64 (read only) 7114060 7114748 688 0.0
(read/write) 327473 327473 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209624 209624 0 0.0
.dynamic 560 560 0 0.0
.got 58208 58208 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390148 390276 128 0.0
.text 6026020 6026580 560 0.0
thermostat-no-ble arm64 (read only) 2037468 2038140 672 0.0
(read/write) 145505 145505 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 72912 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129276 129388 112 0.1
.text 1693888 1694448 560 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348912 2349160 248 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1311488 1311736 248 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330560 2330800 240 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293160 1293400 240 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303784 2303960 176 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266384 1266560 176 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054232 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939279 939507 228 0.0
bss 119284 119284 0 0.0
rodata 108332 108448 116 0.1
text 634088 634204 116 0.0
nrf52840dk_nrf52840+rpc (read/write) 924747 924971 224 0.0
bss 116328 116328 0 0.0
rodata 100784 100896 112 0.1
text 629440 629556 116 0.0
nrf52840dongle_nrf52840 (read/write) 989939 990183 244 0.0
bss 122128 122128 0 0.0
rodata 113084 113200 116 0.1
text 666284 666400 116 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849138 849366 228 0.0
bss 116072 116072 0 0.0
rodata 101508 101624 116 0.1
text 551008 551124 116 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911551 911779 228 0.0
bss 118472 118472 0 0.0
rodata 103604 103720 116 0.1
text 612080 612196 116 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821590 821814 224 0.0
bss 115288 115288 0 0.0
rodata 96832 96944 112 0.1
text 529040 529156 116 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912831 913059 228 0.0
bss 118232 118232 0 0.0
rodata 103820 103936 116 0.1
text 613340 613456 116 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909631 909859 228 0.0
bss 118260 118260 0 0.0
rodata 103076 103192 116 0.1
text 610828 610944 116 0.0
shell nrf52840dk_nrf52840 (read/write) 798391 798391 0 0.0
bss 109776 109776 0 0.0
rodata 78284 78284 0 0.0
text 533832 533832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711206 711206 0 0.0
bss 107664 107664 0 0.0
rodata 72584 72584 0 0.0
text 451512 451512 0 0.0
p6 all-clusters-app default (read/write) 2403200 2403424 224 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361464 1361688 224 0.0
light-app default (read/write) 2325088 2325336 248 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283352 1283600 248 0.0
lock-app default (read/write) 2297320 2297544 224 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255584 1255808 224 0.0
qpg lighting-app qpg6105+debug (read only) 534060 534284 224 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528740 528964 224 0.0
lock-app qpg6105+debug (read only) 505980 506204 224 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500660 500884 224 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835878 836122 244 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583752 583880 128 0.0

@pan-apple pan-apple marked this pull request as ready for review January 11, 2022 20:24
@pan-apple pan-apple merged commit 56ddde0 into project-chip:master Jan 11, 2022
@pan-apple pan-apple deleted the issue5871 branch January 11, 2022 22:56
@wqx6 wqx6 mentioned this pull request Jan 12, 2022
Closed
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@pan-apple @selissia
Use current time during CASE session handshake (project-chip#13462)
72e4c37
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@pan-apple @step0035
Use current time during CASE session handshake (project-chip#13462)
2ffd476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emargolis emargolis emargolis approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove this and replace with system method to retrieve current time
3 participants
@pan-apple @emargolis @bzbarsky-apple