Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: Fixed dns resolve and browse commands #13451

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

Currently the dns resolve and dns browse commands don't work, as after adding ResolverProxy the shell Dns module uses wrong Resolver instance and operations fail due to delegate set to null.

Change overview

Utilized ResolverProxy instead of Resolve Instace().

Testing

Tested manually that dns resolve and dns browse commands work properly.

Currently the dns resolve and dns browse commands don't work,
as after adding ResolverProxy the shell Dns module uses wrong
Resolver instance and operations fail due to delegate set to null.

Utilized ResolverProxy instead of Resolve Instace().
@github-actions
Copy link

github-actions bot commented Jan 11, 2022

PR #13451: Size comparison from a841e21 to 7adb005

Increases (5 builds for esp32, linux, mbed, nrfconnect)
platform target config section a841e21 7adb005 change % change
esp32 all-clusters-app m5stack (read only) 952483 952511 28 0.0
(read/write) 446360 446368 8 0.0
.dram0.bss 74304 74312 8 0.0
.flash.text 947099 947127 28 0.0
linux thermostat-no-ble arm64 (read only) 2036572 2036652 80 0.0
(read/write) 145377 145409 32 0.0
.bss 64721 64737 16 0.0
.got 4008 4016 8 0.2
.text 1693360 1693424 64 0.0
mbed shell CY8CPROTO_062_4343W+release (read/write) 2054432 2054880 448 0.0
.bss 157060 157068 8 0.0
.text 1017032 1017480 448 0.0
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798063 798127 64 0.0
bss 109768 109776 8 0.0
text 533608 533668 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 710946 64 0.0
bss 107656 107664 8 0.0
text 451288 451348 60 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a841e21 7adb005 change % change
efr32 lighting-app BRD4161A (read only) 829972 829972 0 0.0
(read/write) 127056 127056 0 0.0
.bss 125176 125176 0 0.0
.data 1880 1880 0 0.0
.text 829964 829964 0 0.0
BRD4161A+rpc (read only) 817168 817168 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141736 141736 0 0.0
.data 1980 1980 0 0.0
.text 817160 817160 0 0.0
window-app BRD4161A (read only) 803436 803436 0 0.0
(read/write) 125996 125996 0 0.0
.bss 124160 124160 0 0.0
.data 1836 1836 0 0.0
.text 803428 803428 0 0.0
esp32 all-clusters-app c3devkit (read only) 892608 892608 0 0.0
(read/write) 1314786 1314786 0 0.0
.dram0.bss 69824 69824 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 177656 177656 0 0.0
.flash.text 892608 892608 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 952483 952511 28 0.0
(read/write) 446360 446368 8 0.0
.dram0.bss 74304 74312 8 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206984 206984 0 0.0
.flash.text 947099 947127 28 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 656148 656148 0 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 571672 571672 0 0.0
lock k32w061+release (read/write) 660488 660488 0 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 575696 575696 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7113260 7113260 0 0.0
(read/write) 327377 327377 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209544 209544 0 0.0
.dynamic 560 560 0 0.0
.got 58184 58184 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 390132 390132 0 0.0
.text 6025556 6025556 0 0.0
thermostat-no-ble arm64 (read only) 2036572 2036652 80 0.0
(read/write) 145377 145409 32 0.0
.bss 64721 64737 16 0.0
.data 880 880 0 0.0
.data.rel.ro 72832 72832 0 0.0
.dynamic 560 560 0 0.0
.got 4008 4016 8 0.2
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129244 129244 0 0.0
.text 1693360 1693424 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349496 2349496 0 0.0
.bss 189068 189068 0 0.0
.data 5320 5320 0 0.0
.text 1312072 1312072 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331144 2331144 0 0.0
.bss 180600 180600 0 0.0
.data 5552 5552 0 0.0
.text 1293744 1293744 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304432 2304432 0 0.0
.bss 179648 179648 0 0.0
.data 5544 5544 0 0.0
.text 1267032 1267032 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054432 2054880 448 0.0
.bss 157060 157068 8 0.0
.data 4864 4864 0 0.0
.text 1017032 1017480 448 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939003 939003 0 0.0
bss 119284 119284 0 0.0
rodata 108232 108232 0 0.0
text 633916 633916 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 924467 924467 0 0.0
bss 116328 116328 0 0.0
rodata 100680 100680 0 0.0
text 629268 629268 0 0.0
nrf52840dongle_nrf52840 (read/write) 989679 989679 0 0.0
bss 122128 122128 0 0.0
rodata 112984 112984 0 0.0
text 666112 666112 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848858 848858 0 0.0
bss 116072 116072 0 0.0
rodata 101404 101404 0 0.0
text 550836 550836 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911275 911275 0 0.0
bss 118472 118472 0 0.0
rodata 103504 103504 0 0.0
text 611912 611912 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821310 821310 0 0.0
bss 115288 115288 0 0.0
rodata 96728 96728 0 0.0
text 528872 528872 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912567 912567 0 0.0
bss 118232 118232 0 0.0
rodata 103716 103716 0 0.0
text 613172 613172 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909355 909355 0 0.0
bss 118260 118260 0 0.0
rodata 102976 102976 0 0.0
text 610660 610660 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798063 798127 64 0.0
bss 109768 109776 8 0.0
rodata 78180 78180 0 0.0
text 533608 533668 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710882 710946 64 0.0
bss 107656 107664 8 0.0
rodata 72484 72484 0 0.0
text 451288 451348 60 0.0
p6 all-clusters-app default (read/write) 2402808 2402808 0 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1361072 1361072 0 0.0
light-app default (read/write) 2324800 2324800 0 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283064 1283064 0 0.0
lock-app default (read/write) 2297024 2297024 0 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255288 1255288 0 0.0
qpg lighting-app qpg6105+debug (read only) 533852 533852 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86672 86672 0 0.0
.data 1008 1008 0 0.0
.text 528532 528532 0 0.0
lock-app qpg6105+debug (read only) 505772 505772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 85808 85808 0 0.0
.data 956 956 0 0.0
.text 500452 500452 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 835562 835562 0 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583540 583540 0 0.0

@andy31415 andy31415 merged commit ad6c1a0 into project-chip:master Jan 11, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
Currently the dns resolve and dns browse commands don't work,
as after adding ResolverProxy the shell Dns module uses wrong
Resolver instance and operations fail due to delegate set to null.

Utilized ResolverProxy instead of Resolve Instace().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants