[Inet] Split off per-implementation parts of InetInterface #13228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #13228: Size comparison from d023a8b to 6aed2ff Increases above 0.2%:
Increases (15 builds for efr32, esp32, linux, mbed, p6, telink)
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This stale pull request has been automatically closed. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
6aed2ff to
72a7f77
Compare
#### Problem Part of project-chip#7715 _Virtualize System and Inet interfaces_ #### Change overview - Convert `InterfaceId`, which is relatively heavily used and stored, to be platform-independent. Platform-specific parts move to a namespace `PlaformNetworkInterface` (since this includes a type and compile-time constant, it can't practically be made an abstract class). - Convert `InterfaceIterator` and `InterfaceAddressIterator` to use abstract base classes, for mockability. At present, the concrete implementation is fixed at compile time under the original name. - Split the three implementations into separate files. #### Testing CI; no change to outside functionality.
72a7f77 to
ab0c41b
Compare
|
PR #13228: Size comparison from 4ac926a to ab0c41b Increases above 0.2%:
Increases (12 builds for efr32, linux, mbed, p6, telink)
Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
|
Holding off on submitting this because virtualizing |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This stale pull request has been automatically closed. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #7715 Virtualize System and Inet interfaces
Change overview
InterfaceId, which is relatively heavily used and stored,to be platform-independent. Platform-specific parts move to a
namespace
PlaformNetworkInterface(since this includes a type andcompile-time constant, it can't practically be made an abstract class).
InterfaceIteratorandInterfaceAddressIteratorto useabstract base classes, for mockability. At present, the concrete
implementation is fixed at compile time under the original name.
Testing
CI; no change to outside functionality.