-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix octetStringEscapedForCLiteral to handle non-ASCII better. #13138
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-octet-string-escapes
Dec 18, 2021
Merged
Fix octetStringEscapedForCLiteral to handle non-ASCII better. #13138
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-octet-string-escapes
Dec 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several bugs in octetStringEscapedForCLiteral: 1. It used \x escapes, but decimal charcode numbers. Since it was only tested for charcode 0, this was not obvious. 2. It did not escape '"', which could break things. 3. It did not escape non-control non-ASCII characters (anything with charcode > 127). As a result the string "\r\n\xff\"\xa0" in YAML would get represented in the C++ as: "\x13\x10ÿ" " and after this change is represented as: "\x0d\x0a\xff\x22\xa0"
rcasallas-silabs
approved these changes
Dec 17, 2021
PR #13138: Size comparison from 7283e3a to 5e8be22 Increases (1 build for linux)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several bugs in octetStringEscapedForCLiteral:
only tested for charcode 0, this was not obvious.
charcode > 127).
As a result the string "\r\n\xff"\xa0" in YAML would get represented
in the C++ as:
and after this change is represented as:
Problem
See above.
Change overview
See above.
Testing
Hard to test the test harness.... Manual inspection of the generated code, plus the fact that the embedded
"
now doesn't cause compiler errors.