Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestCluster] Test cluster use negative defaults for ints types #13117

Merged
merged 2 commits into from
Dec 26, 2021
Merged

[TestCluster] Test cluster use negative defaults for ints types #13117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71d0d39
[TestCluster] Use negative defaults after ZAP PR 356
vivien-apple Dec 17, 2021
12e2394
Update generated code
vivien-apple Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15748,7 +15748,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"defaultValue": "-20",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
Expand Down Expand Up @@ -15778,7 +15778,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"defaultValue": "-100",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
Expand Down Expand Up @@ -16288,7 +16288,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"defaultValue": "-20",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
Expand Down Expand Up @@ -16318,7 +16318,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"defaultValue": "-100",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
Expand Down Expand Up @@ -19580,5 +19580,6 @@
"endpointVersion": 1,
"deviceIdentifier": 22
}
]
],
"log": []
}
16 changes: 8 additions & 8 deletions src/app/tests/suites/TestCluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3010,7 +3010,7 @@ tests:
command: "readAttribute"
attribute: "range_restricted_int8s"
response:
value: 0 # ZAP won't allow setting a negative default!
value: -20

- label: "Write min value to a range-restricted signed 8-bit integer"
command: "writeAttribute"
Expand Down Expand Up @@ -3053,7 +3053,7 @@ tests:
command: "readAttribute"
attribute: "range_restricted_int8s"
response:
value: 0
value: -20

- label: "Write min valid value to a range-restricted signed 8-bit integer"
command: "writeAttribute"
Expand Down Expand Up @@ -3099,7 +3099,7 @@ tests:
command: "readAttribute"
attribute: "range_restricted_int16s"
response:
value: 0 # ZAP won't allow setting a negative default!
value: -100

- label: "Write min value to a range-restricted signed 16-bit integer"
command: "writeAttribute"
Expand Down Expand Up @@ -3142,7 +3142,7 @@ tests:
command: "readAttribute"
attribute: "range_restricted_int16s"
response:
value: 0
value: -100

- label: "Write min valid value to a range-restricted signed 16-bit integer"
command: "writeAttribute"
Expand Down Expand Up @@ -3422,7 +3422,7 @@ tests:
command: "readAttribute"
attribute: "nullable_range_restricted_int8s"
response:
value: 0 # ZAP won't allow setting a negative default!
value: -20

- label:
"Write min value to a nullable range-restricted signed 8-bit integer"
Expand Down Expand Up @@ -3468,7 +3468,7 @@ tests:
command: "readAttribute"
attribute: "nullable_range_restricted_int8s"
response:
value: 0
value: -20

- label:
"Write min valid value to a nullable range-restricted signed 8-bit
Expand Down Expand Up @@ -3537,7 +3537,7 @@ tests:
command: "readAttribute"
attribute: "nullable_range_restricted_int16s"
response:
value: 0 # ZAP won't allow setting a negative default!
value: -100

- label:
"Write min value to a nullable range-restricted signed 16-bit integer"
Expand Down Expand Up @@ -3583,7 +3583,7 @@ tests:
command: "readAttribute"
attribute: "nullable_range_restricted_int16s"
response:
value: 0
value: -100

- label:
"Write min valid value to a nullable range-restricted signed 16-bit
Expand Down
16 changes: 8 additions & 8 deletions src/darwin/Framework/CHIPTests/CHIPClustersTests.m
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions zzz_generated/all-clusters-app/zap-generated/endpoint_config.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions zzz_generated/chip-tool/zap-generated/test/Commands.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.