-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the watchdog in QEMU builds. #13103
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
andy31415:disable_watchdog_qemu
Dec 17, 2021
Merged
Disable the watchdog in QEMU builds. #13103
bzbarsky-apple
merged 1 commit into
project-chip:master
from
andy31415:disable_watchdog_qemu
Dec 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The watchdog triggers during crypto tests (long running, full CPU tests) and the warnings it shows both look scary and are not really actionable. We know those tests take a long time, especially in emulation.
PR #13103: Size comparison from 2ddefed to 261923f Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
gjc13
approved these changes
Dec 17, 2021
bzbarsky-apple
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The watchdog triggers during crypto tests (long running, full CPU tests)
and the warnings it shows both look scary and are not really actionable.
We know those tests take a long time, especially in emulation.
Change overview
Disable the watchdog when compiling for qemu.
Testing
Locally ran crypto tests and saw no more watchdog complains. CI should also show this.