Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TV channel cluster to channel cluster #12999

Merged
merged 6 commits into from
Dec 16, 2021
Merged

Rename TV channel cluster to channel cluster #12999

merged 6 commits into from
Dec 16, 2021

Conversation

lazarkov
Copy link
Contributor

Problem

TV channel cluster is renamed to Channel cluster and code is not updated.

  • Updated all the references of TV channel cluster to Channel Cluster.

Change overview

see above

Testing

Run ./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "

@boring-cyborg boring-cyborg bot added app documentation Improvements or additions to documentation examples labels Dec 14, 2021
@restyled-io restyled-io bot mentioned this pull request Dec 14, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #12999: Size comparison from f40044e to 62c5e57

Increases (1 build for esp32)
platform target config section f40044e 62c5e57 change % change
esp32 all-clusters-app m5stack (read only) 964659 964663 4 0.0
.flash.text 959275 959279 4 0.0
Decreases (1 build for linux)
platform target config section f40044e 62c5e57 change % change
linux chip-tool-ipv6only arm64 (read only) 6880588 6880556 -32 -0.0
.rodata 366140 366108 -32 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f40044e 62c5e57 change % change
efr32 lighting-app BRD4161A (read only) 833464 833464 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126744 126744 0 0.0
.data 1864 1864 0 0.0
.text 833456 833456 0 0.0
BRD4161A+rpc (read only) 821052 821052 0 0.0
(read/write) 145284 145284 0 0.0
.bss 143320 143320 0 0.0
.data 1964 1964 0 0.0
.text 821044 821044 0 0.0
window-app BRD4161A (read only) 810688 810688 0 0.0
(read/write) 127560 127560 0 0.0
.bss 125728 125728 0 0.0
.data 1828 1828 0 0.0
.text 810680 810680 0 0.0
esp32 all-clusters-app c3devkit (read only) 876720 876720 0 0.0
(read/write) 1313266 1313266 0 0.0
.dram0.bss 71056 71056 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 174960 174960 0 0.0
.flash.text 876720 876720 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964659 964663 4 0.0
(read/write) 454564 454564 0 0.0
.dram0.bss 77528 77528 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211200 211200 0 0.0
.flash.text 959275 959279 4 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 687400 687400 0 0.0
.bss 79328 79328 0 0.0
.data 1896 1896 0 0.0
.text 600376 600376 0 0.0
lock-app k32w061+debug (read/write) 637324 637324 0 0.0
.bss 77480 77480 0 0.0
.data 1856 1856 0 0.0
.text 552188 552188 0 0.0
shell k32w061+debug (read/write) 642728 642728 0 0.0
.bss 79788 79788 0 0.0
.data 1836 1836 0 0.0
.text 555304 555304 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6880588 6880556 -32 -0.0
(read/write) 323585 323585 0 0.0
.bss 56001 56001 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208880 208880 0 0.0
.dynamic 560 560 0 0.0
.got 53776 53776 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366140 366108 -32 -0.0
.text 5832148 5832148 0 0.0
thermostat-no-ble arm64 (read only) 1998508 1998508 0 0.0
(read/write) 145073 145073 0 0.0
.bss 65601 65601 0 0.0
.data 832 832 0 0.0
.data.rel.ro 71912 71912 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 127852 127852 0 0.0
.text 1659328 1659328 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334712 2334712 0 0.0
.bss 190316 190316 0 0.0
.data 5240 5240 0 0.0
.heap 840888 840888 0 0.0
.text 1297288 1297288 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330304 2330304 0 0.0
.bss 182176 182176 0 0.0
.data 5536 5536 0 0.0
.heap 848736 848736 0 0.0
.text 1292904 1292904 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303416 2303416 0 0.0
.bss 181216 181216 0 0.0
.data 5520 5520 0 0.0
.heap 849712 849712 0 0.0
.text 1266016 1266016 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 922887 922887 0 0.0
bss 119832 119832 0 0.0
rodata 103544 103544 0 0.0
text 623928 623928 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 885943 885943 0 0.0
bss 116180 116180 0 0.0
rodata 94840 94840 0 0.0
text 598668 598668 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848902 848902 0 0.0
bss 121208 121208 0 0.0
rodata 98800 98800 0 0.0
text 554368 554368 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 897675 897675 0 0.0
bss 119012 119012 0 0.0
rodata 99660 99660 0 0.0
text 603572 603572 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823934 823934 0 0.0
bss 120420 120420 0 0.0
rodata 94952 94952 0 0.0
text 534100 534100 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 902615 902615 0 0.0
bss 118924 118924 0 0.0
rodata 101016 101016 0 0.0
text 607172 607172 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 895823 895823 0 0.0
bss 118800 118800 0 0.0
rodata 99152 99152 0 0.0
text 602372 602372 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2387432 2387432 0 0.0
.bss 118516 118516 0 0.0
.data 2528 2528 0 0.0
.heap 912296 912296 0 0.0
.text 1345696 1345696 0 0.0
light-app default (read/write) 2327792 2327792 0 0.0
.bss 107432 107432 0 0.0
.data 2368 2368 0 0.0
.heap 923544 923544 0 0.0
.text 1286056 1286056 0 0.0
lock-app default (read/write) 2303856 2303856 0 0.0
.bss 106312 106312 0 0.0
.data 2336 2336 0 0.0
.heap 924696 924696 0 0.0
.text 1262120 1262120 0 0.0
qpg lighting-app qpg6105+debug (read only) 532120 532120 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88080 88080 0 0.0
.data 992 992 0 0.0
.text 526800 526800 0 0.0
lock-app qpg6105+debug (read only) 506464 506464 0 0.0
(read/write) 146936 146936 0 0.0
.bss 87216 87216 0 0.0
.data 948 948 0 0.0
.text 501144 501144 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832126 832126 0 0.0
bss 88320 88320 0 0.0
noinit 37160 37160 0 0.0
text 579914 579914 0 0.0

@lazarkov lazarkov changed the title RenameTV channel cluster to channel cluster Rename TV channel cluster to channel cluster Dec 14, 2021
@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch 2 times, most recently from 2d1ca79 to f97b37a Compare December 14, 2021 19:40
@lazarkov lazarkov self-assigned this Dec 14, 2021
@pullapprove pullapprove bot requested a review from yufengwangca December 14, 2021 19:42
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #12999: Size comparison from c9bc5ae to f97b37a

Full report (8 builds for esp32, mbed, telink)
platform target config section c9bc5ae f97b37a change % change
esp32 all-clusters-app c3devkit (read only) 877284 877284 0 0.0
(read/write) 1313434 1313434 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175096 175096 0 0.0
.flash.text 877284 877284 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965191 965191 0 0.0
(read/write) 454720 454720 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211332 211332 0 0.0
.flash.text 959807 959807 0 0.0
.iram0.text 123451 123451 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335416 2335416 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1297992 1297992 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330952 2330952 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293552 1293552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304072 2304072 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266672 1266672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832822 832822 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 580510 580510 0 0.0

@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch from f97b37a to 5841ec3 Compare December 15, 2021 16:20
@boring-cyborg boring-cyborg bot added the github label Dec 15, 2021
@restyled-io restyled-io bot mentioned this pull request Dec 15, 2021
Closed
@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch from 5841ec3 to 08c0f1f Compare December 15, 2021 16:22
@github-actions
Copy link

PR #12999: Size comparison from 8f15eea to 08c0f1f

Full report (1 build for telink)
platform target config section 8f15eea 08c0f1f change % change
telink lighting-app tlsr9518adk80d (read/write) 833650 833650 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 581342 581342 0 0.0

@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch from 08c0f1f to 3838c19 Compare December 15, 2021 16:54
@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12999: Size comparison from 8f15eea to 3838c19

Decreases (1 build for linux)
platform target config section 8f15eea 3838c19 change % change
linux chip-tool-ipv6only arm64 (read only) 6978884 6978836 -48 -0.0
.rodata 376292 376244 -48 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8f15eea 3838c19 change % change
efr32 lighting-app BRD4161A (read only) 836648 836648 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 836640 836640 0 0.0
BRD4161A+rpc (read only) 824236 824236 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 824228 824228 0 0.0
window-app BRD4161A (read only) 813872 813872 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 813864 813864 0 0.0
esp32 all-clusters-app c3devkit (read only) 878096 878096 0 0.0
(read/write) 1313442 1313442 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 175104 175104 0 0.0
.flash.text 878096 878096 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 966023 966023 0 0.0
(read/write) 454720 454720 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211332 211332 0 0.0
.flash.text 960639 960639 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688692 688692 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601648 601648 0 0.0
lock-app k32w061+debug (read/write) 638616 638616 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 553460 553460 0 0.0
shell k32w061+debug (read/write) 644020 644020 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 556576 556576 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6978884 6978836 -48 -0.0
(read/write) 324593 324593 0 0.0
.bss 55889 55889 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55512 55512 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376292 376244 -48 -0.0
.text 5916548 5916548 0 0.0
thermostat-no-ble arm64 (read only) 2007996 2007996 0 0.0
(read/write) 145281 145281 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128012 128012 0 0.0
.text 1668448 1668448 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336048 2336048 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1298624 1298624 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331592 2331592 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1294192 1294192 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304648 2304648 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1267248 1267248 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 924271 924271 0 0.0
bss 119852 119852 0 0.0
rodata 103616 103616 0 0.0
text 625200 625200 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 887311 887311 0 0.0
bss 116200 116200 0 0.0
rodata 94912 94912 0 0.0
text 599940 599940 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850286 850286 0 0.0
bss 121224 121224 0 0.0
rodata 98872 98872 0 0.0
text 555640 555640 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 899011 899011 0 0.0
bss 119028 119028 0 0.0
rodata 99732 99732 0 0.0
text 604844 604844 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 825270 825270 0 0.0
bss 120440 120440 0 0.0
rodata 95024 95024 0 0.0
text 535372 535372 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903967 903967 0 0.0
bss 118940 118940 0 0.0
rodata 101088 101088 0 0.0
text 608444 608444 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 897207 897207 0 0.0
bss 118820 118820 0 0.0
rodata 99224 99224 0 0.0
text 603644 603644 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2390680 2390680 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1348944 1348944 0 0.0
light-app default (read/write) 2330968 2330968 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1289232 1289232 0 0.0
lock-app default (read/write) 2307032 2307032 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1265296 1265296 0 0.0
qpg lighting-app qpg6105+debug (read only) 533384 533384 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 528064 528064 0 0.0
lock-app qpg6105+debug (read only) 507752 507752 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 502432 502432 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 833650 833650 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 581342 581342 0 0.0

@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch from 3838c19 to d1aabf3 Compare December 15, 2021 22:48
@github-actions
Copy link

PR #12999: Size comparison from fc5be12 to d1aabf3

Decreases (4 builds for k32w, linux, qpg, telink)
platform target config section fc5be12 d1aabf3 change % change
k32w lighting-app k32w061+se05x+release (read/write) 686412 684976 -1436 -0.2
.text 600680 599244 -1436 -0.2
linux chip-tool-ipv6only arm64 (read only) 6911556 6911524 -32 -0.0
.rodata 377636 377604 -32 -0.0
qpg lighting-app qpg6105+debug (read only) 532768 531344 -1424 -0.3
.bss 86800 86792 -8 -0.0
.text 527448 526024 -1424 -0.3
telink lighting-app tlsr9518adk80d (read/write) 831110 829446 -1664 -0.2
text 579422 577984 -1438 -0.2
Full report (9 builds for k32w, linux, qpg, telink)
platform target config section fc5be12 d1aabf3 change % change
k32w lock-app k32w061+debug (read/write) 633976 633976 0 0.0
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550140 550140 0 0.0
shell k32w061+debug (read/write) 639720 639720 0 0.0
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553396 553396 0 0.0
lighting-app k32w061+se05x+release (read/write) 686412 684976 -1436 -0.2
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600680 599244 -1436 -0.2
linux chip-tool-ipv6only arm64 (read only) 6911556 6911524 -32 -0.0
(read/write) 322993 322993 0 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 207752 207752 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 377636 377604 -32 -0.0
.text 5847924 5847924 0 0.0
thermostat-no-ble arm64 (read only) 1994052 1994052 0 0.0
(read/write) 143937 143937 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654672 1654672 0 0.0
qpg lighting-app qpg6105+debug (read only) 532768 531344 -1424 -0.3
(read/write) 146936 146936 0 0.0
.bss 86800 86792 -8 -0.0
.data 1004 1004 0 0.0
.text 527448 526024 -1424 -0.3
lock-app qpg6105+debug (read only) 504456 504456 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499136 499136 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831110 829446 -1664 -0.2
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579422 577984 -1438 -0.2

@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch from d1aabf3 to c3a20f5 Compare December 15, 2021 23:27
@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12999: Size comparison from fc5be12 to c3a20f5

Decreases (1 build for linux)
platform target config section fc5be12 c3a20f5 change % change
linux chip-tool-ipv6only arm64 (read only) 6911556 6911524 -32 -0.0
.rodata 377636 377604 -32 -0.0
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fc5be12 c3a20f5 change % change
efr32 lighting-app BRD4161A (read only) 835748 835748 0 0.0
(read/write) 127324 127324 0 0.0
.bss 125448 125448 0 0.0
.data 1876 1876 0 0.0
.text 835740 835740 0 0.0
BRD4161A+rpc (read only) 823352 823352 0 0.0
(read/write) 143992 143992 0 0.0
.bss 142016 142016 0 0.0
.data 1976 1976 0 0.0
.text 823344 823344 0 0.0
window-app BRD4161A (read only) 809108 809108 0 0.0
(read/write) 126264 126264 0 0.0
.bss 124432 124432 0 0.0
.data 1832 1832 0 0.0
.text 809100 809100 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 686412 686412 0 0.0
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600680 600680 0 0.0
lock-app k32w061+debug (read/write) 633976 633976 0 0.0
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550140 550140 0 0.0
shell k32w061+debug (read/write) 639720 639720 0 0.0
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553396 553396 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6911556 6911524 -32 -0.0
(read/write) 322993 322993 0 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 207752 207752 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 377636 377604 -32 -0.0
.text 5847924 5847924 0 0.0
thermostat-no-ble arm64 (read only) 1994052 1994052 0 0.0
(read/write) 143937 143937 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654672 1654672 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333776 2333776 0 0.0
.bss 189020 189020 0 0.0
.data 5256 5256 0 0.0
.text 1296352 1296352 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329344 2329344 0 0.0
.bss 180872 180872 0 0.0
.data 5544 5544 0 0.0
.text 1291944 1291944 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302376 2302376 0 0.0
.bss 179920 179920 0 0.0
.data 5536 5536 0 0.0
.text 1264976 1264976 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936579 936579 0 0.0
bss 118376 118376 0 0.0
rodata 107952 107952 0 0.0
text 632668 632668 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 918531 918531 0 0.0
bss 114708 114708 0 0.0
rodata 99864 99864 0 0.0
text 625804 625804 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860294 860294 0 0.0
bss 116660 116660 0 0.0
rodata 102876 102876 0 0.0
text 560100 560100 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908675 908675 0 0.0
bss 117564 117564 0 0.0
rodata 103256 103256 0 0.0
text 610484 610484 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832622 832622 0 0.0
bss 115876 115876 0 0.0
rodata 98220 98220 0 0.0
text 537956 537956 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913555 913555 0 0.0
bss 117472 117472 0 0.0
rodata 104600 104600 0 0.0
text 614036 614036 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906787 906787 0 0.0
bss 117352 117352 0 0.0
rodata 102728 102728 0 0.0
text 609232 609232 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796959 796959 0 0.0
bss 109472 109472 0 0.0
rodata 78032 78032 0 0.0
text 532996 532996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709594 709594 0 0.0
bss 107360 107360 0 0.0
rodata 72336 72336 0 0.0
text 450484 450484 0 0.0
p6 all-clusters-app default (read/write) 2389688 2389688 0 0.0
.bss 117212 117212 0 0.0
.data 2536 2536 0 0.0
.text 1347952 1347952 0 0.0
light-app default (read/write) 2330000 2330000 0 0.0
.bss 106128 106128 0 0.0
.data 2384 2384 0 0.0
.text 1288264 1288264 0 0.0
lock-app default (read/write) 2302192 2302192 0 0.0
.bss 105008 105008 0 0.0
.data 2336 2336 0 0.0
.text 1260456 1260456 0 0.0
qpg lighting-app qpg6105+debug (read only) 532768 532768 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86800 86800 0 0.0
.data 1004 1004 0 0.0
.text 527448 527448 0 0.0
lock-app qpg6105+debug (read only) 504456 504456 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499136 499136 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831110 831110 0 0.0
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579422 579422 0 0.0

@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch 2 times, most recently from 923aebf to 8115672 Compare December 16, 2021 01:07
@lazarkov lazarkov force-pushed the feature/rename-tv-channel-cluster-to-channel-cluster branch from 8115672 to cd1ff1c Compare December 16, 2021 01:29
@github-actions
Copy link

github-actions bot commented Dec 16, 2021 •
edited
Loading

PR #12999: Size comparison from 5988375 to cd1ff1c

Decreases (1 build for linux)
platform target config section 5988375 cd1ff1c change % change
linux chip-tool-ipv6only arm64 (read only) 6929412 6929380 -32 -0.0
.rodata 378356 378324 -32 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5988375 cd1ff1c change % change
efr32 lighting-app BRD4161A (read only) 835684 835684 0 0.0
(read/write) 127324 127324 0 0.0
.bss 125448 125448 0 0.0
.data 1876 1876 0 0.0
.text 835676 835676 0 0.0
BRD4161A+rpc (read only) 823304 823304 0 0.0
(read/write) 143992 143992 0 0.0
.bss 142016 142016 0 0.0
.data 1976 1976 0 0.0
.text 823296 823296 0 0.0
window-app BRD4161A (read only) 809060 809060 0 0.0
(read/write) 126264 126264 0 0.0
.bss 124432 124432 0 0.0
.data 1832 1832 0 0.0
.text 809052 809052 0 0.0
esp32 all-clusters-app c3devkit (read only) 876694 876694 0 0.0
(read/write) 1312954 1312954 0 0.0
.dram0.bss 69776 69776 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 175920 175920 0 0.0
.flash.text 876694 876694 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962575 962575 0 0.0
(read/write) 453688 453688 0 0.0
.dram0.bss 76096 76096 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 211748 211748 0 0.0
.flash.text 957191 957191 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 686396 686396 0 0.0
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600664 600664 0 0.0
lock-app k32w061+debug (read/write) 633960 633960 0 0.0
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550124 550124 0 0.0
shell k32w061+debug (read/write) 639688 639688 0 0.0
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553364 553364 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6929412 6929380 -32 -0.0
(read/write) 323377 323377 0 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208016 208016 0 0.0
.dynamic 560 560 0 0.0
.got 55992 55992 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 378356 378324 -32 -0.0
.text 5864180 5864180 0 0.0
thermostat-no-ble arm64 (read only) 1993972 1993972 0 0.0
(read/write) 143937 143937 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654592 1654592 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334696 2334696 0 0.0
.bss 189044 189044 0 0.0
.data 5264 5264 0 0.0
.text 1297272 1297272 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329280 2329280 0 0.0
.bss 180872 180872 0 0.0
.data 5544 5544 0 0.0
.text 1291880 1291880 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302376 2302376 0 0.0
.bss 179920 179920 0 0.0
.data 5536 5536 0 0.0
.text 1264976 1264976 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936531 936531 0 0.0
bss 118376 118376 0 0.0
rodata 107952 107952 0 0.0
text 632628 632628 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 918483 918483 0 0.0
bss 114708 114708 0 0.0
rodata 99864 99864 0 0.0
text 625764 625764 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860246 860246 0 0.0
bss 116660 116660 0 0.0
rodata 102876 102876 0 0.0
text 560064 560064 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908627 908627 0 0.0
bss 117564 117564 0 0.0
rodata 103256 103256 0 0.0
text 610444 610444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832574 832574 0 0.0
bss 115876 115876 0 0.0
rodata 98220 98220 0 0.0
text 537920 537920 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913507 913507 0 0.0
bss 117472 117472 0 0.0
rodata 104600 104600 0 0.0
text 613996 613996 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906739 906739 0 0.0
bss 117352 117352 0 0.0
rodata 102728 102728 0 0.0
text 609192 609192 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796959 796959 0 0.0
bss 109472 109472 0 0.0
rodata 78032 78032 0 0.0
text 532996 532996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709594 709594 0 0.0
bss 107360 107360 0 0.0
rodata 72336 72336 0 0.0
text 450484 450484 0 0.0
p6 all-clusters-app default (read/write) 2390552 2390552 0 0.0
.bss 117236 117236 0 0.0
.data 2544 2544 0 0.0
.text 1348816 1348816 0 0.0
light-app default (read/write) 2329936 2329936 0 0.0
.bss 106128 106128 0 0.0
.data 2384 2384 0 0.0
.text 1288200 1288200 0 0.0
lock-app default (read/write) 2302144 2302144 0 0.0
.bss 105008 105008 0 0.0
.data 2336 2336 0 0.0
.text 1260408 1260408 0 0.0
qpg lighting-app qpg6105+debug (read only) 532752 532752 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86800 86800 0 0.0
.data 1004 1004 0 0.0
.text 527432 527432 0 0.0
lock-app qpg6105+debug (read only) 504424 504424 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499104 499104 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831078 831078 0 0.0
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579390 579390 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 161cd14 into project-chip:master Dec 16, 2021
@lazarkov lazarkov deleted the feature/rename-tv-channel-cluster-to-channel-cluster branch December 23, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

@lazarkov lazarkov

Labels
app documentation Improvements or additions to documentation examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazarkov @andy31415 @bzbarsky-apple