-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it harder to misuse Clusters. #12914
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:safer-clusters-helper
Dec 13, 2021
Merged
Make it harder to misuse Clusters. #12914
vivien-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:safer-clusters-helper
Dec 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we throw on any attempt to use Clusters without calling init on it, which can end up waiting forever on promises that never resolve.
yunhanw-google
approved these changes
Dec 10, 2021
krypton36
approved these changes
Dec 10, 2021
PR #12914: Size comparison from e76d65b to 0ff68ee Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
vivien-apple
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we throw on any attempt to use Clusters without
calling init on it, which can end up waiting forever on promises that
never resolve.
Problem
See #12826 for the sort of things that can fail in non-obvious ways.
Change overview
Make things fail in loud obvious ways when they fail, with stacks. Fix all the "false positives" that were not failing due to kicking off init after starting async tasks that depend on init. Now we just kick off init up front.
Testing
Ran codegen, everything worked.