Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path expanded flag #12820

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Add path expanded flag #12820

merged 3 commits into from
Dec 10, 2021

Conversation

mlepage-google
Copy link
Contributor

Problem

When processing concrete attribute paths, it's not known if they were originally
concrete, or if they were expanded (from a wildcard or group path). This is necessary
because handling may need to differ based on whether the concrete path was
expanded or not (e.g. if access is denied).

Change overview

Add an expanded flag to ConcreteAttributePath. It can be a boolean fit in between
other larger member variables, so alignment means it shouldn't typically use more
space.

The expanded flag defaults to false. It's effectively "optional". (Only some code will
care what it's set to.)

It's set to true by the AttributeExpandPathIterator based on the ClusterInfo it's currently
iterating.

It's logged in the log statement in ReadSingleClusterData.

Testing

How was this tested? (at least one bullet point required)

  • Build and run chip-all-clusters-app using chip-repl
  • Test reading specific endpoint specific cluster logs expanded=0
  • Test reading any endpoint specific cluster logs expanded=1
  • Test reading specific endpoint any cluster logs expanded=1

@boring-cyborg boring-cyborg bot added the app label Dec 9, 2021
bzbarsky-apple
bzbarsky-apple approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me if codesize is fine with this!

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12820: Size comparison from b6297f3 to fd0a81c

Increases (19 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section b6297f3 fd0a81c change % change
efr32 lighting-app BRD4161A (read only) 806260 806356 96 0.0
.text 806252 806348 96 0.0
BRD4161A+rpc (read only) 793896 794008 112 0.0
.text 793888 794000 112 0.0
window-app BRD4161A (read only) 783004 783084 80 0.0
.text 782996 783076 80 0.0
esp32 all-clusters-app c3devkit (read only) 860210 860288 78 0.0
(read/write) 1307002 1307018 16 0.0
.flash.rodata 172232 172248 16 0.0
.flash.text 860210 860288 78 0.0
m5stack (read only) 964195 964319 124 0.0
(read/write) 451300 451316 16 0.0
.flash.rodata 210480 210496 16 0.0
.flash.text 958811 958935 124 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667732 667812 80 0.0
.text 586336 586416 80 0.0
lock-app k32w061+debug (read/write) 617324 617388 64 0.0
.text 537808 537872 64 0.0
shell k32w061+debug (read/write) 622400 622480 80 0.0
.text 540684 540764 80 0.0
linux chip-tool-ipv6only arm64 (read only) 6784428 6784460 32 0.0
.rodata 363612 363628 16 0.0
.text 5743124 5743140 16 0.0
thermostat-no-ble arm64 .rodata 124996 125012 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2321272 2321416 144 0.0
.text 1283848 1283992 144 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2307128 2307200 72 0.0
.text 1269728 1269800 72 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2279856 2279928 72 0.0
.text 1242456 1242528 72 0.0
p6 all-clusters-app default (read/write) 2357456 2357568 112 0.0
.text 1315720 1315832 112 0.0
light-app default (read/write) 2291752 2291848 96 0.0
.text 1250016 1250112 96 0.0
lock-app default (read/write) 2267616 2267712 96 0.0
.text 1225880 1225976 96 0.0
qpg lighting-app qpg6100+debug (read only) 519472 519528 56 0.0
.text 514152 514208 56 0.0
lock-app qpg6100+debug (read only) 493464 493544 80 0.0
.text 488144 488224 80 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 808806 104 0.0
text 564470 564558 88 0.0
Decreases (1 build for linux)
platform target config section b6297f3 fd0a81c change % change
linux thermostat-no-ble arm64 (read only) 1935204 1935188 -16 -0.0
.text 1604304 1604272 -32 -0.0
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section b6297f3 fd0a81c change % change
efr32 lighting-app BRD4161A (read only) 806260 806356 96 0.0
(read/write) 122980 122980 0 0.0
.bss 121160 121160 0 0.0
.data 1820 1820 0 0.0
.text 806252 806348 96 0.0
BRD4161A+rpc (read only) 793896 794008 112 0.0
(read/write) 139664 139664 0 0.0
.bss 137736 137736 0 0.0
.data 1928 1928 0 0.0
.text 793888 794000 112 0.0
window-app BRD4161A (read only) 783004 783084 80 0.0
(read/write) 121112 121112 0 0.0
.bss 119328 119328 0 0.0
.data 1784 1784 0 0.0
.text 782996 783076 80 0.0
esp32 all-clusters-app c3devkit (read only) 860210 860288 78 0.0
(read/write) 1307002 1307018 16 0.0
.dram0.bss 67616 67616 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172232 172248 16 0.0
.flash.text 860210 860288 78 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964195 964319 124 0.0
(read/write) 451300 451316 16 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210480 210496 16 0.0
.flash.text 958811 958935 124 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667732 667812 80 0.0
.bss 73744 73744 0 0.0
.data 1852 1852 0 0.0
.text 586336 586416 80 0.0
lock-app k32w061+debug (read/write) 617324 617388 64 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 537808 537872 64 0.0
shell k32w061+debug (read/write) 622400 622480 80 0.0
.bss 74124 74124 0 0.0
.data 1792 1792 0 0.0
.text 540684 540764 80 0.0
linux chip-tool-ipv6only arm64 (read only) 6784428 6784460 32 0.0
(read/write) 317777 317777 0 0.0
.bss 51681 51681 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 208360 208360 0 0.0
.dynamic 560 560 0 0.0
.got 52992 52992 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363612 363628 16 0.0
.text 5743124 5743140 16 0.0
thermostat-no-ble arm64 (read only) 1935204 1935188 -16 -0.0
(read/write) 136353 136353 0 0.0
.bss 59409 59409 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69800 69800 0 0.0
.dynamic 560 560 0 0.0
.got 3512 3512 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124996 125012 16 0.0
.text 1604304 1604272 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321272 2321416 144 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1283848 1283992 144 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307128 2307200 72 0.0
.bss 175688 175688 0 0.0
.data 5488 5488 0 0.0
.heap 855272 855272 0 0.0
.text 1269728 1269800 72 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279856 2279928 72 0.0
.bss 174728 174728 0 0.0
.data 5488 5488 0 0.0
.heap 856232 856232 0 0.0
.text 1242456 1242528 72 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
p6 all-clusters-app default (read/write) 2357456 2357568 112 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1315720 1315832 112 0.0
light-app default (read/write) 2291752 2291848 96 0.0
.bss 100880 100880 0 0.0
.data 2328 2328 0 0.0
.heap 930136 930136 0 0.0
.text 1250016 1250112 96 0.0
lock-app default (read/write) 2267616 2267712 96 0.0
.bss 99760 99760 0 0.0
.data 2288 2288 0 0.0
.heap 931296 931296 0 0.0
.text 1225880 1225976 96 0.0
qpg lighting-app qpg6100+debug (read only) 519472 519528 56 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 514152 514208 56 0.0
lock-app qpg6100+debug (read only) 493464 493544 80 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 488144 488224 80 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 808806 104 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 564470 564558 88 0.0

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12820: Size comparison from b6297f3 to 550d24d

Increases above 0.2%:

platform target config section b6297f3 550d24d change % change
efr32 lighting-app BRD4161A .data 1820 1848 28 1.5
BRD4161A+rpc .data 1928 1956 28 1.5
window-app BRD4161A .data 1784 1812 28 1.6
k32w lighting-app k32w061+se05x+release .data 1852 1880 28 1.5
lock-app k32w061+debug .data 1820 1848 28 1.5
shell k32w061+debug .data 1792 1820 28 1.6
linux chip-tool-ipv6only arm64 .data 1048 1096 48 4.6
.init_array 160 168 8 5.0
thermostat-no-ble arm64 (read only) 1935204 1943044 7840 0.4
(read/write) 136353 136865 512 0.4
.data 776 824 48 6.2
.data.rel.ro 69800 70160 360 0.5
.got 3512 3568 56 1.6
.init_array 256 264 8 3.1
.rodata 124996 125316 320 0.3
.text 1604304 1610576 6272 0.4
p6 all-clusters-app default .text 1315720 1318448 2728 0.2
light-app default .data 2328 2352 24 1.0
lock-app default .data 2288 2320 32 1.4
qpg lighting-app qpg6100+debug .data 956 984 28 2.9
lock-app qpg6100+debug (read only) 493464 494724 1260 0.3
.data 912 940 28 3.1
.text 488144 489404 1260 0.3
Increases (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section b6297f3 550d24d change % change
efr32 lighting-app BRD4161A (read only) 806260 807484 1224 0.2
(read/write) 122980 123008 28 0.0
.data 1820 1848 28 1.5
.text 806252 807476 1224 0.2
BRD4161A+rpc (read only) 793896 795104 1208 0.2
(read/write) 139664 139696 32 0.0
.data 1928 1956 28 1.5
.text 793888 795096 1208 0.2
window-app BRD4161A (read only) 783004 784460 1456 0.2
(read/write) 121112 121140 28 0.0
.data 1784 1812 28 1.6
.text 782996 784452 1456 0.2
k32w lighting-app k32w061+se05x+release (read/write) 667732 668548 816 0.1
.data 1852 1880 28 1.5
.text 586336 587124 788 0.1
lock-app k32w061+debug (read/write) 617324 618508 1184 0.2
.data 1820 1848 28 1.5
.text 537808 538964 1156 0.2
shell k32w061+debug (read/write) 622400 623584 1184 0.2
.data 1792 1820 28 1.6
.text 540684 541840 1156 0.2
linux chip-tool-ipv6only arm64 (read only) 6784428 6792140 7712 0.1
(read/write) 317777 318273 496 0.2
.bss 51681 51713 32 0.1
.data 1048 1096 48 4.6
.data.rel.ro 208360 208720 360 0.2
.got 52992 53048 56 0.1
.init_array 160 168 8 5.0
.rodata 363612 363900 288 0.1
.text 5743124 5749300 6176 0.1
thermostat-no-ble arm64 (read only) 1935204 1943044 7840 0.4
(read/write) 136353 136865 512 0.4
.bss 59409 59441 32 0.1
.data 776 824 48 6.2
.data.rel.ro 69800 70160 360 0.5
.got 3512 3568 56 1.6
.init_array 256 264 8 3.1
.rodata 124996 125316 320 0.3
.text 1604304 1610576 6272 0.4
p6 all-clusters-app default (read/write) 2357456 2360184 2728 0.1
.text 1315720 1318448 2728 0.2
light-app default (read/write) 2291752 2292968 1216 0.1
.data 2328 2352 24 1.0
.text 1250016 1251232 1216 0.1
lock-app default (read/write) 2267616 2269032 1416 0.1
.data 2288 2320 32 1.4
.text 1225880 1227296 1416 0.1
qpg lighting-app qpg6100+debug (read only) 519472 520340 868 0.2
(read/write) 122332 122336 4 0.0
.data 956 984 28 2.9
.text 514152 515020 868 0.2
lock-app qpg6100+debug (read only) 493464 494724 1260 0.3
.data 912 940 28 3.1
.text 488144 489404 1260 0.3
telink lighting-app tlsr9518adk80d (read/write) 808702 809762 1060 0.1
text 564470 565252 782 0.1
Decreases (3 builds for p6, qpg)
platform target config section b6297f3 550d24d change % change
p6 light-app default .heap 930136 930112 -24 -0.0
lock-app default .heap 931296 931264 -32 -0.0
qpg lock-app qpg6100+debug (read/write) 122336 122332 -4 -0.0
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section b6297f3 550d24d change % change
efr32 lighting-app BRD4161A (read only) 806260 807484 1224 0.2
(read/write) 122980 123008 28 0.0
.bss 121160 121160 0 0.0
.data 1820 1848 28 1.5
.text 806252 807476 1224 0.2
BRD4161A+rpc (read only) 793896 795104 1208 0.2
(read/write) 139664 139696 32 0.0
.bss 137736 137736 0 0.0
.data 1928 1956 28 1.5
.text 793888 795096 1208 0.2
window-app BRD4161A (read only) 783004 784460 1456 0.2
(read/write) 121112 121140 28 0.0
.bss 119328 119328 0 0.0
.data 1784 1812 28 1.6
.text 782996 784452 1456 0.2
k32w lighting-app k32w061+se05x+release (read/write) 667732 668548 816 0.1
.bss 73744 73744 0 0.0
.data 1852 1880 28 1.5
.text 586336 587124 788 0.1
lock-app k32w061+debug (read/write) 617324 618508 1184 0.2
.bss 71896 71896 0 0.0
.data 1820 1848 28 1.5
.text 537808 538964 1156 0.2
shell k32w061+debug (read/write) 622400 623584 1184 0.2
.bss 74124 74124 0 0.0
.data 1792 1820 28 1.6
.text 540684 541840 1156 0.2
linux chip-tool-ipv6only arm64 (read only) 6784428 6792140 7712 0.1
(read/write) 317777 318273 496 0.2
.bss 51681 51713 32 0.1
.data 1048 1096 48 4.6
.data.rel.ro 208360 208720 360 0.2
.dynamic 560 560 0 0.0
.got 52992 53048 56 0.1
.init 24 24 0 0.0
.init_array 160 168 8 5.0
.rodata 363612 363900 288 0.1
.text 5743124 5749300 6176 0.1
thermostat-no-ble arm64 (read only) 1935204 1943044 7840 0.4
(read/write) 136353 136865 512 0.4
.bss 59409 59441 32 0.1
.data 776 824 48 6.2
.data.rel.ro 69800 70160 360 0.5
.dynamic 560 560 0 0.0
.got 3512 3568 56 1.6
.init 24 24 0 0.0
.init_array 256 264 8 3.1
.rodata 124996 125316 320 0.3
.text 1604304 1610576 6272 0.4
p6 all-clusters-app default (read/write) 2357456 2360184 2728 0.1
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1315720 1318448 2728 0.2
light-app default (read/write) 2291752 2292968 1216 0.1
.bss 100880 100880 0 0.0
.data 2328 2352 24 1.0
.heap 930136 930112 -24 -0.0
.text 1250016 1251232 1216 0.1
lock-app default (read/write) 2267616 2269032 1416 0.1
.bss 99760 99760 0 0.0
.data 2288 2320 32 1.4
.heap 931296 931264 -32 -0.0
.text 1225880 1227296 1416 0.1
qpg lighting-app qpg6100+debug (read only) 519472 520340 868 0.2
(read/write) 122332 122336 4 0.0
.bss 82616 82616 0 0.0
.data 956 984 28 2.9
.text 514152 515020 868 0.2
lock-app qpg6100+debug (read only) 493464 494724 1260 0.3
(read/write) 122336 122332 -4 -0.0
.bss 81752 81752 0 0.0
.data 912 940 28 3.1
.text 488144 489404 1260 0.3
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 809762 1060 0.1
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 564470 565252 782 0.1

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12820: Size comparison from 0089995 to f9b8638

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0089995 f9b8638 change % change
efr32 lighting-app BRD4161A (read only) 807484 807596 112 0.0
.text 807476 807588 112 0.0
BRD4161A+rpc (read only) 795120 795216 96 0.0
.text 795112 795208 96 0.0
window-app BRD4161A (read only) 784460 784572 112 0.0
.text 784452 784564 112 0.0
esp32 all-clusters-app c3devkit (read only) 862060 862138 78 0.0
(read/write) 1305602 1305618 16 0.0
.flash.rodata 172752 172768 16 0.0
.flash.text 862060 862138 78 0.0
m5stack (read only) 965247 965371 124 0.0
(read/write) 451296 451312 16 0.0
.flash.rodata 210468 210484 16 0.0
.flash.text 959863 959987 124 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668612 80 0.0
.text 587108 587188 80 0.0
lock-app k32w061+debug (read/write) 618492 618572 80 0.0
.text 538948 539028 80 0.0
shell k32w061+debug (read/write) 623584 623648 64 0.0
.text 541840 541904 64 0.0
linux chip-tool-ipv6only arm64 .rodata 363884 363900 16 0.0
thermostat-no-ble arm64 .rodata 125300 125316 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2323376 2323456 80 0.0
.text 1285952 1286032 80 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308008 2308080 72 0.0
.text 1270608 1270680 72 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2281120 2281192 72 0.0
.text 1243720 1243792 72 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905659 905751 92 0.0
rodata 101676 101688 12 0.0
text 612212 612292 80 0.0
nrf52840dk_nrf52840+rpc (read/write) 868683 868775 92 0.0
rodata 92972 92984 12 0.0
text 586940 587020 80 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831650 831746 96 0.0
rodata 96932 96948 16 0.0
text 542640 542720 80 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878271 878367 96 0.0
rodata 97792 97808 16 0.0
text 591656 591736 80 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804518 804614 96 0.0
rodata 93080 93096 16 0.0
text 522176 522256 80 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883199 883295 96 0.0
rodata 99144 99160 16 0.0
text 595244 595324 80 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876443 876535 92 0.0
rodata 97284 97296 12 0.0
text 590444 590524 80 0.0
p6 all-clusters-app default (read/write) 2360184 2360296 112 0.0
.text 1318448 1318560 112 0.0
light-app default (read/write) 2292984 2293080 96 0.0
.text 1251248 1251344 96 0.0
lock-app default (read/write) 2269048 2269144 96 0.0
.text 1227312 1227408 96 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520404 80 0.0
.text 515004 515084 80 0.0
lock-app qpg6100+debug (read only) 494700 494788 88 0.0
.text 489380 489468 88 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809874 104 0.0
text 565274 565362 88 0.0
Decreases (2 builds for linux)
platform target config section 0089995 f9b8638 change % change
linux chip-tool-ipv6only arm64 .text 5749972 5749956 -16 -0.0
thermostat-no-ble arm64 (read only) 1943364 1943348 -16 -0.0
.text 1610912 1610880 -32 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0089995 f9b8638 change % change
efr32 lighting-app BRD4161A (read only) 807484 807596 112 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807476 807588 112 0.0
BRD4161A+rpc (read only) 795120 795216 96 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795112 795208 96 0.0
window-app BRD4161A (read only) 784460 784572 112 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784452 784564 112 0.0
esp32 all-clusters-app c3devkit (read only) 862060 862138 78 0.0
(read/write) 1305602 1305618 16 0.0
.dram0.bss 65696 65696 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172752 172768 16 0.0
.flash.text 862060 862138 78 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965247 965371 124 0.0
(read/write) 451296 451312 16 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210468 210484 16 0.0
.flash.text 959863 959987 124 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668612 80 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587108 587188 80 0.0
lock-app k32w061+debug (read/write) 618492 618572 80 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538948 539028 80 0.0
shell k32w061+debug (read/write) 623584 623648 64 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541840 541904 64 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6792796 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363900 16 0.0
.text 5749972 5749956 -16 -0.0
thermostat-no-ble arm64 (read only) 1943364 1943348 -16 -0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125316 16 0.0
.text 1610912 1610880 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323376 2323456 80 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285952 1286032 80 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308008 2308080 72 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270608 1270680 72 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281120 2281192 72 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243720 1243792 72 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905659 905751 92 0.0
bss 116168 116168 0 0.0
rodata 101676 101688 12 0.0
text 612212 612292 80 0.0
nrf52840dk_nrf52840+rpc (read/write) 868683 868775 92 0.0
bss 112516 112516 0 0.0
rodata 92972 92984 12 0.0
text 586940 587020 80 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831650 831746 96 0.0
bss 117544 117544 0 0.0
rodata 96932 96948 16 0.0
text 542640 542720 80 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878271 878367 96 0.0
bss 113432 113432 0 0.0
rodata 97792 97808 16 0.0
text 591656 591736 80 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804518 804614 96 0.0
bss 114840 114840 0 0.0
rodata 93080 93096 16 0.0
text 522176 522256 80 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883199 883295 96 0.0
bss 113344 113344 0 0.0
rodata 99144 99160 16 0.0
text 595244 595324 80 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876443 876535 92 0.0
bss 113220 113220 0 0.0
rodata 97284 97296 12 0.0
text 590444 590524 80 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2360184 2360296 112 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318448 1318560 112 0.0
light-app default (read/write) 2292984 2293080 96 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251248 1251344 96 0.0
lock-app default (read/write) 2269048 2269144 96 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227312 1227408 96 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520404 80 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 515004 515084 80 0.0
lock-app qpg6100+debug (read only) 494700 494788 88 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489380 489468 88 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809874 104 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565274 565362 88 0.0

@woody-apple
Copy link
Contributor

/rebase

@mlepage-google @woody-apple
Add expanded flag to ConcreteAttributePath
7aa979a 
And set it from the AttributePathExpandIterator.
@mlepage-google @woody-apple
Ensure expanded flag is not sliced
37a05e8 
Derived "copy" constructors that take the base can slice it. Fix that.
@mlepage-google @woody-apple
Remove expanded flag from equality test
3057b4e 
It's more of a metadata thing anyways.
@woody-apple woody-apple force-pushed the add-path-expanded-flag branch from f9b8638 to 3057b4e Compare December 10, 2021 05:31
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12820: Size comparison from 2400884 to 3057b4e

Increases (16 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 2400884 3057b4e change % change
efr32 lighting-app BRD4161A (read only) 809204 809300 96 0.0
.text 809196 809292 96 0.0
BRD4161A+rpc (read only) 796824 796936 112 0.0
.text 796816 796928 112 0.0
window-app BRD4161A (read only) 786180 786276 96 0.0
.text 786172 786268 96 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669560 669640 80 0.0
.text 587996 588076 80 0.0
lock-app k32w061+debug (read/write) 619508 619588 80 0.0
.text 539832 539912 80 0.0
shell k32w061+debug (read/write) 624608 624688 80 0.0
.text 542724 542804 80 0.0
linux thermostat-no-ble arm64 .rodata 125508 125524 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324328 2324408 80 0.0
.text 1286904 1286984 80 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308944 2309024 80 0.0
.text 1271544 1271624 80 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282064 2282136 72 0.0
.text 1244664 1244736 72 0.0
p6 all-clusters-app default (read/write) 2361904 2362000 96 0.0
.text 1320168 1320264 96 0.0
light-app default (read/write) 2294704 2294800 96 0.0
.text 1252968 1253064 96 0.0
lock-app default (read/write) 2270784 2270864 80 0.0
.text 1229048 1229128 80 0.0
qpg lighting-app qpg6100+debug (read only) 521320 521384 64 0.0
.text 516000 516064 64 0.0
lock-app qpg6100+debug (read only) 495688 495760 72 0.0
.text 490368 490440 72 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 811058 104 0.0
text 566006 566094 88 0.0
Decreases (2 builds for linux)
platform target config section 2400884 3057b4e change % change
linux chip-tool-ipv6only arm64 (read only) 6864988 6864956 -32 -0.0
.text 5820564 5820532 -32 -0.0
thermostat-no-ble arm64 (read only) 1947444 1947428 -16 -0.0
.text 1614432 1614400 -32 -0.0
Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 2400884 3057b4e change % change
efr32 lighting-app BRD4161A (read only) 809204 809300 96 0.0
(read/write) 123148 123148 0 0.0
.bss 121288 121288 0 0.0
.data 1860 1860 0 0.0
.text 809196 809292 96 0.0
BRD4161A+rpc (read only) 796824 796936 112 0.0
(read/write) 139824 139824 0 0.0
.bss 137864 137864 0 0.0
.data 1960 1960 0 0.0
.text 796816 796928 112 0.0
window-app BRD4161A (read only) 786180 786276 96 0.0
(read/write) 121280 121280 0 0.0
.bss 119456 119456 0 0.0
.data 1824 1824 0 0.0
.text 786172 786268 96 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669560 669640 80 0.0
.bss 73872 73872 0 0.0
.data 1892 1892 0 0.0
.text 587996 588076 80 0.0
lock-app k32w061+debug (read/write) 619508 619588 80 0.0
.bss 72024 72024 0 0.0
.data 1852 1852 0 0.0
.text 539832 539912 80 0.0
shell k32w061+debug (read/write) 624608 624688 80 0.0
.bss 74252 74252 0 0.0
.data 1832 1832 0 0.0
.text 542724 542804 80 0.0
linux chip-tool-ipv6only arm64 (read only) 6864988 6864956 -32 -0.0
(read/write) 318785 318785 0 0.0
.bss 51985 51985 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208776 208776 0 0.0
.dynamic 560 560 0 0.0
.got 53096 53096 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364764 364764 0 0.0
.text 5820564 5820532 -32 -0.0
thermostat-no-ble arm64 (read only) 1947444 1947428 -16 -0.0
(read/write) 137201 137201 0 0.0
.bss 59601 59601 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 125524 16 0.0
.text 1614432 1614400 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2324408 80 0.0
.bss 185108 185108 0 0.0
.data 5240 5240 0 0.0
.heap 846096 846096 0 0.0
.text 1286904 1286984 80 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2309024 80 0.0
.bss 175824 175824 0 0.0
.data 5528 5528 0 0.0
.heap 855096 855096 0 0.0
.text 1271544 1271624 80 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282136 72 0.0
.bss 174864 174864 0 0.0
.data 5520 5520 0 0.0
.heap 856064 856064 0 0.0
.text 1244664 1244736 72 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
p6 all-clusters-app default (read/write) 2361904 2362000 96 0.0
.bss 113244 113244 0 0.0
.data 2520 2520 0 0.0
.heap 917576 917576 0 0.0
.text 1320168 1320264 96 0.0
light-app default (read/write) 2294704 2294800 96 0.0
.bss 101016 101016 0 0.0
.data 2360 2360 0 0.0
.heap 929968 929968 0 0.0
.text 1252968 1253064 96 0.0
lock-app default (read/write) 2270784 2270864 80 0.0
.bss 99896 99896 0 0.0
.data 2328 2328 0 0.0
.heap 931120 931120 0 0.0
.text 1229048 1229128 80 0.0
qpg lighting-app qpg6100+debug (read only) 521320 521384 64 0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82712 0 0.0
.data 992 992 0 0.0
.text 516000 516064 64 0.0
lock-app qpg6100+debug (read only) 495688 495760 72 0.0
(read/write) 122332 122332 0 0.0
.bss 81848 81848 0 0.0
.data 948 948 0 0.0
.text 490368 490440 72 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 811058 104 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 566006 566094 88 0.0

@andy31415 andy31415 merged commit d27ac43 into project-chip:master Dec 10, 2021
@mlepage-google mlepage-google deleted the add-path-expanded-flag branch December 10, 2021 15:15
@mlepage-google mlepage-google mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mlepage-google @woody-apple @mrjerryjohns @bzbarsky-apple @Damian-Nordic @andy31415