Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup IM #12716

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Cleanup IM #12716

merged 3 commits into from
Dec 8, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Dec 8, 2021 •
edited
Loading

Problem

-- All core logic for Command class have been relocated toward CommandSender and CommandHandler in previous several PRs, the rest of logic is very minimal, now this PR would relocate the rest of Command logic to CommandSender and CommandHandler and remove Command class, and update the codegen as well
-- Deleting the ctor that takes non-const ref as arg in IM Builder

Change overview

See above

Testing

The existing test cover

@yunhanw-google yunhanw-google force-pushed the feature/remove_command_cpp branch from 66f77a9 to fb9c554 Compare December 8, 2021 08:26
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12716: Size comparison from b9d8ef1 to fb9c554

Increases (23 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b9d8ef1 fb9c554 change % change
efr32 lighting-app BRD4161A (read only) 794704 794792 88 0.0
.text 794696 794784 88 0.0
BRD4161A+rpc (read only) 782316 782404 88 0.0
.text 782308 782396 88 0.0
esp32 all-clusters-app c3devkit (read only) 855576 856244 668 0.1
.flash.text 855576 856244 668 0.1
m5stack (read only) 958283 959107 824 0.1
.flash.text 952899 953723 824 0.1
k32w lighting-app k32w061+se05x+release (read/write) 731932 732052 120 0.0
.text 643040 643176 136 0.0
linux all-clusters-app debug (read only) 1903833 1904553 720 0.0
.text 1602258 1603810 1552 0.1
lighting-app debug+rpc .text 1447954 1448354 400 0.0
tv-app debug (read only) 2044049 2044905 856 0.0
.text 1712450 1713986 1536 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2316008 2316464 456 0.0
.heap 844320 844336 16 0.0
.text 1278584 1279040 456 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2298656 2298800 144 0.0
.heap 855256 855272 16 0.0
.text 1261256 1261400 144 0.0
lock-app CY8CPROTO_062_4343W+release .heap 856216 856232 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896763 896895 132 0.0
text 604900 605104 204 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 859935 132 0.0
text 579628 579832 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822838 132 0.0
text 535272 535476 204 0.0
lock-app nrf52840dk_nrf52840 text 584156 584164 8 0.0
nrf5340dk_nrf5340_cpuapp text 514620 514632 12 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874103 4 0.0
text 587672 587756 84 0.0
pump-controller-app nrf52840dk_nrf52840 text 582892 582916 24 0.0
p6 all-clusters-app default (read/write) 2349776 2350248 472 0.0
.heap 917704 917720 16 0.0
.text 1308040 1308512 472 0.0
light-app default (read/write) 2281080 2281152 72 0.0
.heap 930120 930136 16 0.0
.text 1239344 1239416 72 0.0
lock-app default .heap 931280 931296 16 0.0
qpg lighting-app qpg6100+debug (read only) 511764 511884 120 0.0
.text 506444 506564 120 0.0
telink lighting-app tlsr9518adk80d (read/write) 800086 800418 332 0.0
text 557192 557582 390 0.1
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b9d8ef1 fb9c554 change % change
efr32 lighting-app BRD4161A (read/write) 122992 122976 -16 -0.0
.bss 121168 121152 -16 -0.0
BRD4161A+rpc (read/write) 139672 139656 -16 -0.0
.bss 137744 137728 -16 -0.0
window-app BRD4161A (read only) 771640 771488 -152 -0.0
(read/write) 121128 121112 -16 -0.0
.bss 119344 119328 -16 -0.0
.text 771632 771480 -152 -0.0
esp32 all-clusters-app c3devkit (read/write) 1305994 1305938 -56 -0.0
.dram0.bss 67640 67624 -16 -0.0
.flash.rodata 171192 171152 -40 -0.0
m5stack (read/write) 450236 450140 -96 -0.0
.dram0.bss 75000 74984 -16 -0.0
.flash.rodata 209400 209320 -80 -0.0
k32w lighting-app k32w061+se05x+release .bss 81240 81224 -16 -0.0
lock-app k32w061+debug (read/write) 622516 622444 -72 -0.0
.bss 71904 71888 -16 -0.0
.text 542992 542936 -56 -0.0
shell k32w061+debug (read/write) 685608 685536 -72 -0.0
.bss 81604 81588 -16 -0.0
.text 596412 596356 -56 -0.0
linux all-clusters-app debug (read/write) 131584 131488 -96 -0.1
.bss 56688 56656 -32 -0.1
.data.rel.ro 68240 68160 -80 -0.1
.rodata 155812 155172 -640 -0.4
bridge-app debug+rpc (read only) 1447629 1447021 -608 -0.0
(read/write) 77712 77616 -96 -0.1
.bss 39120 39088 -32 -0.1
.data.rel.ro 31800 31720 -80 -0.3
.rodata 123580 123292 -288 -0.2
.text 1218837 1218709 -128 -0.0
chip-tool debug (read only) 6689749 6687277 -2472 -0.0
(read/write) 202336 202144 -192 -0.1
.bss 35272 35240 -32 -0.1
.data.rel.ro 160360 160208 -152 -0.1
.rodata 335753 335337 -416 -0.1
.text 5944901 5943205 -1696 -0.0
lighting-app debug+rpc (read only) 1735377 1735041 -336 -0.0
(read/write) 110776 110680 -96 -0.1
.bss 44816 44784 -32 -0.1
.data.rel.ro 59312 59232 -80 -0.1
.rodata 144444 143900 -544 -0.4
ota-provider-app debug (read only) 1412041 1411001 -1040 -0.1
(read/write) 75688 75560 -128 -0.2
.bss 41600 41568 -32 -0.1
.data.rel.ro 28008 27928 -80 -0.3
.rodata 124990 124702 -288 -0.2
.text 1182146 1181586 -560 -0.0
ota-requestor-app debug (read only) 1516793 1516081 -712 -0.0
(read/write) 80704 80512 -192 -0.2
.bss 44768 44736 -32 -0.1
.data.rel.ro 29768 29608 -160 -0.5
.rodata 137711 137423 -288 -0.2
.text 1270274 1270210 -64 -0.0
tv-app debug (read/write) 324120 323928 -192 -0.1
.bss 251160 251128 -32 -0.0
.data.rel.ro 64408 64248 -160 -0.2
.rodata 176572 176252 -320 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 186892 186876 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release .bss 175704 175688 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2271568 2271520 -48 -0.0
.bss 174744 174728 -16 -0.0
.text 1234168 1234120 -48 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116176 116160 -16 -0.0
rodata 100132 100088 -44 -0.0
nrf52840dk_nrf52840+rpc bss 112524 112508 -16 -0.0
rodata 91428 91384 -44 -0.0
nrf5340dk_nrf5340_cpuapp bss 117552 117536 -16 -0.0
rodata 95388 95344 -44 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 869199 869171 -28 -0.0
bss 113440 113424 -16 -0.0
rodata 96248 96204 -44 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795386 795358 -28 -0.0
bss 114848 114832 -16 -0.0
rodata 91540 91496 -44 -0.0
pump-app nrf52840dk_nrf52840 bss 113352 113336 -16 -0.0
rodata 97604 97560 -44 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867263 -60 -0.0
bss 113228 113212 -16 -0.0
rodata 95740 95696 -44 -0.0
p6 all-clusters-app default .bss 113124 113108 -16 -0.0
light-app default .bss 100896 100880 -16 -0.0
lock-app default (read/write) 2257168 2257016 -152 -0.0
.bss 99776 99760 -16 -0.0
.text 1215432 1215280 -152 -0.0
qpg lighting-app qpg6100+debug .bss 82616 82608 -8 -0.0
lock-app qpg6100+debug (read only) 485948 485892 -56 -0.0
.bss 81752 81744 -8 -0.0
.text 480628 480572 -56 -0.0
telink lighting-app tlsr9518adk80d bss 82756 82740 -16 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b9d8ef1 fb9c554 change % change
efr32 lighting-app BRD4161A (read only) 794704 794792 88 0.0
(read/write) 122992 122976 -16 -0.0
.bss 121168 121152 -16 -0.0
.data 1820 1820 0 0.0
.text 794696 794784 88 0.0
BRD4161A+rpc (read only) 782316 782404 88 0.0
(read/write) 139672 139656 -16 -0.0
.bss 137744 137728 -16 -0.0
.data 1928 1928 0 0.0
.text 782308 782396 88 0.0
window-app BRD4161A (read only) 771640 771488 -152 -0.0
(read/write) 121128 121112 -16 -0.0
.bss 119344 119328 -16 -0.0
.data 1784 1784 0 0.0
.text 771632 771480 -152 -0.0
esp32 all-clusters-app c3devkit (read only) 855576 856244 668 0.1
(read/write) 1305994 1305938 -56 -0.0
.dram0.bss 67640 67624 -16 -0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171192 171152 -40 -0.0
.flash.text 855576 856244 668 0.1
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958283 959107 824 0.1
(read/write) 450236 450140 -96 -0.0
.dram0.bss 75000 74984 -16 -0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209400 209320 -80 -0.0
.flash.text 952899 953723 824 0.1
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731932 732052 120 0.0
.bss 81240 81224 -16 -0.0
.data 1852 1852 0 0.0
.text 643040 643176 136 0.0
lock-app k32w061+debug (read/write) 622516 622444 -72 -0.0
.bss 71904 71888 -16 -0.0
.data 1820 1820 0 0.0
.text 542992 542936 -56 -0.0
shell k32w061+debug (read/write) 685608 685536 -72 -0.0
.bss 81604 81588 -16 -0.0
.data 1792 1792 0 0.0
.text 596412 596356 -56 -0.0
linux all-clusters-app debug (read only) 1903833 1904553 720 0.0
(read/write) 131584 131488 -96 -0.1
.bss 56688 56656 -32 -0.1
.data 1200 1200 0 0.0
.data.rel.ro 68240 68160 -80 -0.1
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155812 155172 -640 -0.4
.text 1602258 1603810 1552 0.1
bridge-app debug+rpc (read only) 1447629 1447021 -608 -0.0
(read/write) 77712 77616 -96 -0.1
.bss 39120 39088 -32 -0.1
.data 1712 1712 0 0.0
.data.rel.ro 31800 31720 -80 -0.3
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123580 123292 -288 -0.2
.text 1218837 1218709 -128 -0.0
chip-tool debug (read only) 6689749 6687277 -2472 -0.0
(read/write) 202336 202144 -192 -0.1
.bss 35272 35240 -32 -0.1
.data 1024 1024 0 0.0
.data.rel.ro 160360 160208 -152 -0.1
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335753 335337 -416 -0.1
.text 5944901 5943205 -1696 -0.0
lighting-app debug+rpc (read only) 1735377 1735041 -336 -0.0
(read/write) 110776 110680 -96 -0.1
.bss 44816 44784 -32 -0.1
.data 1264 1264 0 0.0
.data.rel.ro 59312 59232 -80 -0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144444 143900 -544 -0.4
.text 1447954 1448354 400 0.0
ota-provider-app debug (read only) 1412041 1411001 -1040 -0.1
(read/write) 75688 75560 -128 -0.2
.bss 41600 41568 -32 -0.1
.data 896 896 0 0.0
.data.rel.ro 28008 27928 -80 -0.3
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124990 124702 -288 -0.2
.text 1182146 1181586 -560 -0.0
ota-requestor-app debug (read only) 1516793 1516081 -712 -0.0
(read/write) 80704 80512 -192 -0.2
.bss 44768 44736 -32 -0.1
.data 960 960 0 0.0
.data.rel.ro 29768 29608 -160 -0.5
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137711 137423 -288 -0.2
.text 1270274 1270210 -64 -0.0
shell debug (read only) 828497 828497 0 0.0
(read/write) 60608 60608 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39000 39000 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 86226 86226 0 0.0
.text 635170 635170 0 0.0
tv-app debug (read only) 2044049 2044905 856 0.0
(read/write) 324120 323928 -192 -0.1
.bss 251160 251128 -32 -0.0
.data 2736 2736 0 0.0
.data.rel.ro 64408 64248 -160 -0.2
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176572 176252 -320 -0.2
.text 1712450 1713986 1536 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316008 2316464 456 0.0
.bss 186892 186876 -16 -0.0
.data 5232 5232 0 0.0
.heap 844320 844336 16 0.0
.text 1278584 1279040 456 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298656 2298800 144 0.0
.bss 175704 175688 -16 -0.0
.data 5488 5488 0 0.0
.heap 855256 855272 16 0.0
.text 1261256 1261400 144 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271568 2271520 -48 -0.0
.bss 174744 174728 -16 -0.0
.data 5488 5488 0 0.0
.heap 856216 856232 16 0.0
.text 1234168 1234120 -48 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896763 896895 132 0.0
bss 116176 116160 -16 -0.0
rodata 100132 100088 -44 -0.0
text 604900 605104 204 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 859935 132 0.0
bss 112524 112508 -16 -0.0
rodata 91428 91384 -44 -0.0
text 579628 579832 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822838 132 0.0
bss 117552 117536 -16 -0.0
rodata 95388 95344 -44 -0.0
text 535272 535476 204 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869199 869171 -28 -0.0
bss 113440 113424 -16 -0.0
rodata 96248 96204 -44 -0.0
text 584156 584164 8 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795386 795358 -28 -0.0
bss 114848 114832 -16 -0.0
rodata 91540 91496 -44 -0.0
text 514620 514632 12 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874103 4 0.0
bss 113352 113336 -16 -0.0
rodata 97604 97560 -44 -0.0
text 587672 587756 84 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867263 -60 -0.0
bss 113228 113212 -16 -0.0
rodata 95740 95696 -44 -0.0
text 582892 582916 24 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2349776 2350248 472 0.0
.bss 113124 113108 -16 -0.0
.data 2512 2512 0 0.0
.heap 917704 917720 16 0.0
.text 1308040 1308512 472 0.0
light-app default (read/write) 2281080 2281152 72 0.0
.bss 100896 100880 -16 -0.0
.data 2328 2328 0 0.0
.heap 930120 930136 16 0.0
.text 1239344 1239416 72 0.0
lock-app default (read/write) 2257168 2257016 -152 -0.0
.bss 99776 99760 -16 -0.0
.data 2288 2288 0 0.0
.heap 931280 931296 16 0.0
.text 1215432 1215280 -152 -0.0
qpg lighting-app qpg6100+debug (read only) 511764 511884 120 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82608 -8 -0.0
.data 956 956 0 0.0
.text 506444 506564 120 0.0
lock-app qpg6100+debug (read only) 485948 485892 -56 -0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81744 -8 -0.0
.data 912 912 0 0.0
.text 480628 480572 -56 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800086 800418 332 0.0
bss 82756 82740 -16 -0.0
noinit 37160 37160 0 0.0
text 557192 557582 390 0.1

@yunhanw-google yunhanw-google force-pushed the feature/remove_command_cpp branch from fb9c554 to a1b7cd5 Compare December 8, 2021 19:14
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

PR #12716: Size comparison from b1d7073 to a1b7cd5

Increases (2 builds for qpg, telink)
platform target config section b1d7073 a1b7cd5 change % change
qpg lighting-app qpg6100+debug (read only) 517744 517848 104 0.0
.text 512424 512528 104 0.0
telink lighting-app tlsr9518adk80d (read/write) 807090 807390 300 0.0
text 563090 563454 364 0.1
Decreases (3 builds for qpg, telink)
platform target config section b1d7073 a1b7cd5 change % change
qpg lighting-app qpg6100+debug .bss 82624 82616 -8 -0.0
lock-app qpg6100+debug (read only) 491944 491848 -96 -0.0
.bss 81760 81752 -8 -0.0
.text 486624 486528 -96 -0.0
telink lighting-app tlsr9518adk80d bss 82764 82748 -16 -0.0
Full report (4 builds for qpg, telink)
platform target config section b1d7073 a1b7cd5 change % change
qpg lighting-app qpg6100+debug (read only) 517744 517848 104 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82616 -8 -0.0
.data 956 956 0 0.0
.text 512424 512528 104 0.0
lock-app qpg6100+debug (read only) 491944 491848 -96 -0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81752 -8 -0.0
.data 912 912 0 0.0
.text 486624 486528 -96 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807090 807390 300 0.0
bss 82764 82748 -16 -0.0
noinit 37160 37160 0 0.0
text 563090 563454 364 0.1

@yunhanw-google yunhanw-google changed the title Relocate the Command logic to CommandSender and CommandHandler Cleanup IM Dec 8, 2021
@yunhanw-google yunhanw-google force-pushed the feature/remove_command_cpp branch 2 times, most recently from aaa3168 to ecb9b4d Compare December 8, 2021 19:55
@restyled-io restyled-io bot mentioned this pull request Dec 8, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

PR #12716: Size comparison from e4f3246 to ecb9b4d

Increases (1 build for telink)
platform target config section e4f3246 ecb9b4d change % change
telink lighting-app tlsr9518adk80d (read/write) 807090 807302 212 0.0
text 563090 563362 272 0.0
Decreases (8 builds for k32w, linux, qpg, telink)
platform target config section e4f3246 ecb9b4d change % change
k32w lock-app k32w061+debug (read/write) 615868 615652 -216 -0.0
.bss 71912 71896 -16 -0.0
.text 536336 536136 -200 -0.0
shell k32w061+debug (read/write) 679124 678892 -232 -0.0
.bss 81612 81596 -16 -0.0
.text 589920 589704 -216 -0.0
lighting-app k32w061+se05x+release (read/write) 724516 724476 -40 -0.0
.bss 81248 81232 -16 -0.0
.text 635616 635592 -24 -0.0
linux chip-tool-ipv6only arm64 (read only) 6732084 6729308 -2776 -0.0
(read/write) 310977 310721 -256 -0.1
.bss 51665 51633 -32 -0.1
.data.rel.ro 206592 206368 -224 -0.1
.got 48040 48032 -8 -0.0
.rodata 341796 341628 -168 -0.0
.text 5731988 5729828 -2160 -0.0
thermostat-no-ble arm64 (read only) 1932044 1931500 -544 -0.0
(read/write) 136465 136321 -144 -0.1
.bss 59457 59425 -32 -0.1
.data.rel.ro 69840 69736 -104 -0.1
.got 3528 3520 -8 -0.2
.rodata 124988 124828 -160 -0.1
.text 1601088 1600944 -144 -0.0
qpg lighting-app qpg6100+debug (read only) 517744 517736 -8 -0.0
.bss 82624 82616 -8 -0.0
.text 512424 512416 -8 -0.0
lock-app qpg6100+debug (read only) 491944 491736 -208 -0.0
.bss 81760 81752 -8 -0.0
.text 486624 486416 -208 -0.0
telink lighting-app tlsr9518adk80d bss 82764 82748 -16 -0.0
Full report (9 builds for k32w, linux, qpg, telink)
platform target config section e4f3246 ecb9b4d change % change
k32w lock-app k32w061+debug (read/write) 615868 615652 -216 -0.0
.bss 71912 71896 -16 -0.0
.data 1820 1820 0 0.0
.text 536336 536136 -200 -0.0
shell k32w061+debug (read/write) 679124 678892 -232 -0.0
.bss 81612 81596 -16 -0.0
.data 1792 1792 0 0.0
.text 589920 589704 -216 -0.0
lighting-app k32w061+se05x+release (read/write) 724516 724476 -40 -0.0
.bss 81248 81232 -16 -0.0
.data 1852 1852 0 0.0
.text 635616 635592 -24 -0.0
linux chip-tool-ipv6only arm64 (read only) 6732084 6729308 -2776 -0.0
(read/write) 310977 310721 -256 -0.1
.bss 51665 51633 -32 -0.1
.data 1048 1048 0 0.0
.data.rel.ro 206592 206368 -224 -0.1
.dynamic 560 560 0 0.0
.got 48040 48032 -8 -0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 341796 341628 -168 -0.0
.text 5731988 5729828 -2160 -0.0
thermostat-no-ble arm64 (read only) 1932044 1931500 -544 -0.0
(read/write) 136465 136321 -144 -0.1
.bss 59457 59425 -32 -0.1
.data 776 776 0 0.0
.data.rel.ro 69840 69736 -104 -0.1
.dynamic 560 560 0 0.0
.got 3528 3520 -8 -0.2
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124988 124828 -160 -0.1
.text 1601088 1600944 -144 -0.0
qpg lighting-app qpg6100+debug (read only) 517744 517736 -8 -0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82616 -8 -0.0
.data 956 956 0 0.0
.text 512424 512416 -8 -0.0
lock-app qpg6100+debug (read only) 491944 491736 -208 -0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81752 -8 -0.0
.data 912 912 0 0.0
.text 486624 486416 -208 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807090 807302 212 0.0
bss 82764 82748 -16 -0.0
noinit 37160 37160 0 0.0
text 563090 563362 272 0.0

@yunhanw-google yunhanw-google force-pushed the feature/remove_command_cpp branch from ecb9b4d to aa82cf4 Compare December 8, 2021 20:32
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12716: Size comparison from e4f3246 to aa82cf4

Increases (12 builds for esp32, mbed, nrfconnect, p6, telink)
platform target config section e4f3246 aa82cf4 change % change
esp32 all-clusters-app c3devkit (read only) 858566 859084 518 0.1
.flash.text 858566 859084 518 0.1
m5stack (read only) 961835 962235 400 0.0
.flash.text 956451 956851 400 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2319536 2319720 184 0.0
.heap 844312 844328 16 0.0
.text 1282112 1282296 184 0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855248 855264 16 0.0
lock-app CY8CPROTO_062_4343W+release .heap 856208 856224 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903055 903059 4 0.0
text 610104 610156 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 866079 866083 4 0.0
text 584832 584884 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829046 829050 4 0.0
text 540532 540584 52 0.0
p6 all-clusters-app default (read/write) 2355624 2355952 328 0.0
.heap 917696 917712 16 0.0
.text 1313888 1314216 328 0.0
light-app default .heap 930112 930128 16 0.0
lock-app default .heap 931272 931288 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 807090 807302 212 0.0
text 563090 563362 272 0.0
Decreases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e4f3246 aa82cf4 change % change
efr32 lighting-app BRD4161A (read only) 803900 803812 -88 -0.0
(read/write) 122996 122980 -16 -0.0
.bss 121176 121160 -16 -0.0
.text 803892 803804 -88 -0.0
BRD4161A+rpc (read only) 791512 791424 -88 -0.0
(read/write) 139680 139664 -16 -0.0
.bss 137752 137736 -16 -0.0
.text 791504 791416 -88 -0.0
window-app BRD4161A (read only) 780852 780540 -312 -0.0
(read/write) 121136 121120 -16 -0.0
.bss 119352 119336 -16 -0.0
.text 780844 780532 -312 -0.0
esp32 all-clusters-app c3devkit (read/write) 1306658 1306602 -56 -0.0
.dram0.bss 67648 67632 -16 -0.0
.flash.rodata 171856 171816 -40 -0.0
m5stack (read/write) 450948 450860 -88 -0.0
.dram0.bss 75000 74984 -16 -0.0
.flash.rodata 210112 210040 -72 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 724516 724476 -40 -0.0
.bss 81248 81232 -16 -0.0
.text 635616 635592 -24 -0.0
lock-app k32w061+debug (read/write) 615868 615652 -216 -0.0
.bss 71912 71896 -16 -0.0
.text 536336 536136 -200 -0.0
shell k32w061+debug (read/write) 679124 678892 -232 -0.0
.bss 81612 81596 -16 -0.0
.text 589920 589704 -216 -0.0
linux chip-tool-ipv6only arm64 (read only) 6732084 6729308 -2776 -0.0
(read/write) 310977 310721 -256 -0.1
.bss 51665 51633 -32 -0.1
.data.rel.ro 206592 206368 -224 -0.1
.got 48040 48032 -8 -0.0
.rodata 341796 341628 -168 -0.0
.text 5731988 5729828 -2160 -0.0
thermostat-no-ble arm64 (read only) 1932044 1931500 -544 -0.0
(read/write) 136465 136321 -144 -0.1
.bss 59457 59425 -32 -0.1
.data.rel.ro 69840 69736 -104 -0.1
.got 3528 3520 -8 -0.2
.rodata 124988 124828 -160 -0.1
.text 1601088 1600944 -144 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 186900 186884 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2305736 2305616 -120 -0.0
.bss 175712 175696 -16 -0.0
.text 1268336 1268216 -120 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2278720 2278344 -376 -0.0
.bss 174752 174736 -16 -0.0
.text 1241320 1240944 -376 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116184 116168 -16 -0.0
rodata 101208 101164 -44 -0.0
nrf52840dk_nrf52840+rpc bss 112532 112516 -16 -0.0
rodata 92504 92460 -44 -0.0
nrf5340dk_nrf5340_cpuapp bss 117560 117544 -16 -0.0
rodata 96464 96420 -44 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 875523 875303 -220 -0.0
bss 113448 113432 -16 -0.0
rodata 97324 97280 -44 -0.0
text 589364 589224 -140 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801754 801550 -204 -0.0
bss 114856 114840 -16 -0.0
rodata 92612 92568 -44 -0.0
text 519884 519744 -140 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 880371 880231 -140 -0.0
bss 113360 113344 -16 -0.0
rodata 98676 98632 -44 -0.0
text 592880 592812 -68 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873599 873443 -156 -0.0
bss 113236 113220 -16 -0.0
rodata 96816 96772 -44 -0.0
text 588100 587976 -124 -0.0
p6 all-clusters-app default .bss 113132 113116 -16 -0.0
light-app default (read/write) 2290408 2290336 -72 -0.0
.bss 100904 100888 -16 -0.0
.text 1248672 1248600 -72 -0.0
lock-app default (read/write) 2266512 2266184 -328 -0.0
.bss 99784 99768 -16 -0.0
.text 1224776 1224448 -328 -0.0
qpg lighting-app qpg6100+debug (read only) 517744 517736 -8 -0.0
.bss 82624 82616 -8 -0.0
.text 512424 512416 -8 -0.0
lock-app qpg6100+debug (read only) 491944 491736 -208 -0.0
.bss 81760 81752 -8 -0.0
.text 486624 486416 -208 -0.0
telink lighting-app tlsr9518adk80d bss 82764 82748 -16 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e4f3246 aa82cf4 change % change
efr32 lighting-app BRD4161A (read only) 803900 803812 -88 -0.0
(read/write) 122996 122980 -16 -0.0
.bss 121176 121160 -16 -0.0
.data 1820 1820 0 0.0
.text 803892 803804 -88 -0.0
BRD4161A+rpc (read only) 791512 791424 -88 -0.0
(read/write) 139680 139664 -16 -0.0
.bss 137752 137736 -16 -0.0
.data 1928 1928 0 0.0
.text 791504 791416 -88 -0.0
window-app BRD4161A (read only) 780852 780540 -312 -0.0
(read/write) 121136 121120 -16 -0.0
.bss 119352 119336 -16 -0.0
.data 1784 1784 0 0.0
.text 780844 780532 -312 -0.0
esp32 all-clusters-app c3devkit (read only) 858566 859084 518 0.1
(read/write) 1306658 1306602 -56 -0.0
.dram0.bss 67648 67632 -16 -0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171856 171816 -40 -0.0
.flash.text 858566 859084 518 0.1
.iram0.text 62076 62076 0 0.0
m5stack (read only) 961835 962235 400 0.0
(read/write) 450948 450860 -88 -0.0
.dram0.bss 75000 74984 -16 -0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210112 210040 -72 -0.0
.flash.text 956451 956851 400 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724516 724476 -40 -0.0
.bss 81248 81232 -16 -0.0
.data 1852 1852 0 0.0
.text 635616 635592 -24 -0.0
lock-app k32w061+debug (read/write) 615868 615652 -216 -0.0
.bss 71912 71896 -16 -0.0
.data 1820 1820 0 0.0
.text 536336 536136 -200 -0.0
shell k32w061+debug (read/write) 679124 678892 -232 -0.0
.bss 81612 81596 -16 -0.0
.data 1792 1792 0 0.0
.text 589920 589704 -216 -0.0
linux chip-tool-ipv6only arm64 (read only) 6732084 6729308 -2776 -0.0
(read/write) 310977 310721 -256 -0.1
.bss 51665 51633 -32 -0.1
.data 1048 1048 0 0.0
.data.rel.ro 206592 206368 -224 -0.1
.dynamic 560 560 0 0.0
.got 48040 48032 -8 -0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 341796 341628 -168 -0.0
.text 5731988 5729828 -2160 -0.0
thermostat-no-ble arm64 (read only) 1932044 1931500 -544 -0.0
(read/write) 136465 136321 -144 -0.1
.bss 59457 59425 -32 -0.1
.data 776 776 0 0.0
.data.rel.ro 69840 69736 -104 -0.1
.dynamic 560 560 0 0.0
.got 3528 3520 -8 -0.2
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124988 124828 -160 -0.1
.text 1601088 1600944 -144 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319536 2319720 184 0.0
.bss 186900 186884 -16 -0.0
.data 5232 5232 0 0.0
.heap 844312 844328 16 0.0
.text 1282112 1282296 184 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305736 2305616 -120 -0.0
.bss 175712 175696 -16 -0.0
.data 5488 5488 0 0.0
.heap 855248 855264 16 0.0
.text 1268336 1268216 -120 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278344 -376 -0.0
.bss 174752 174736 -16 -0.0
.data 5488 5488 0 0.0
.heap 856208 856224 16 0.0
.text 1241320 1240944 -376 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903055 903059 4 0.0
bss 116184 116168 -16 -0.0
rodata 101208 101164 -44 -0.0
text 610104 610156 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 866079 866083 4 0.0
bss 112532 112516 -16 -0.0
rodata 92504 92460 -44 -0.0
text 584832 584884 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829046 829050 4 0.0
bss 117560 117544 -16 -0.0
rodata 96464 96420 -44 -0.0
text 540532 540584 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875523 875303 -220 -0.0
bss 113448 113432 -16 -0.0
rodata 97324 97280 -44 -0.0
text 589364 589224 -140 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801754 801550 -204 -0.0
bss 114856 114840 -16 -0.0
rodata 92612 92568 -44 -0.0
text 519884 519744 -140 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880371 880231 -140 -0.0
bss 113360 113344 -16 -0.0
rodata 98676 98632 -44 -0.0
text 592880 592812 -68 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873599 873443 -156 -0.0
bss 113236 113220 -16 -0.0
rodata 96816 96772 -44 -0.0
text 588100 587976 -124 -0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2355624 2355952 328 0.0
.bss 113132 113116 -16 -0.0
.data 2512 2512 0 0.0
.heap 917696 917712 16 0.0
.text 1313888 1314216 328 0.0
light-app default (read/write) 2290408 2290336 -72 -0.0
.bss 100904 100888 -16 -0.0
.data 2328 2328 0 0.0
.heap 930112 930128 16 0.0
.text 1248672 1248600 -72 -0.0
lock-app default (read/write) 2266512 2266184 -328 -0.0
.bss 99784 99768 -16 -0.0
.data 2288 2288 0 0.0
.heap 931272 931288 16 0.0
.text 1224776 1224448 -328 -0.0
qpg lighting-app qpg6100+debug (read only) 517744 517736 -8 -0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82616 -8 -0.0
.data 956 956 0 0.0
.text 512424 512416 -8 -0.0
lock-app qpg6100+debug (read only) 491944 491736 -208 -0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81752 -8 -0.0
.data 912 912 0 0.0
.text 486624 486416 -208 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807090 807302 212 0.0
bss 82764 82748 -16 -0.0
noinit 37160 37160 0 0.0
text 563090 563362 272 0.0

@yunhanw-google yunhanw-google merged commit 4584707 into project-chip:master Dec 8, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Dec 10, 2021
@bzbarsky-apple
Fix some nonsensical code/comments in CommandSender/CommandHandler.
19925e6 
project-chip#12716 copies some
bits without modifying them, but they don't make sense in the new
places.  Some of the code can go, and the comments need adjusting.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Dec 10, 2021
Merged
andy31415 pushed a commit that referenced this pull request Dec 10, 2021
@bzbarsky-apple
Fix some nonsensical code/comments in CommandSender/CommandHandler. (#…
163b932 
…12874)

#12716 copies some
bits without modifying them, but they don't make sense in the new
places.  Some of the code can go, and the comments need adjusting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @yufengwangca @chrisdecenzo @jmartinez-silabs