Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QPG] Replace Nvm_Init with KvsInit #12476

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[QPG] Replace Nvm_Init with KvsInit #12476

merged 1 commit into from
Jan 4, 2022

Conversation

michalbudzon-q
Copy link
Contributor

@michalbudzon-q michalbudzon-q commented Dec 2, 2021 •
edited by tima-q
Loading

Problem

NVM implementation reworked to use QPG KVS implementation underneath

Change overview

Function call replacement

Testing

How was this tested? (at least one bullet point required)

  • Sanity test

@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12476: Size comparison from dc10c82 to c956dec

Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section dc10c823 c956dec change % change
efr32 lighting-app BRD4161A (read only) 730064 730064 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730056 0 0.0
BRD4161A+rpc (read only) 758704 758704 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758696 0 0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
esp32 all-clusters-app c3devkit (read only) 839114 839114 0 0.0
(read/write) 1225090 1225090 0 0.0
.dram0.bss 58824 58824 0 0.0
.dram0.data 14036 14036 0 0.0
.flash.rodata 166968 166968 0 0.0
.flash.text 839114 839114 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910791 910791 0 0.0
(read/write) 424312 424312 0 0.0
.dram0.bss 64224 64224 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194808 194808 0 0.0
.flash.text 905407 905407 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616916 0 0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539856 0 0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1797065 0 0.0
(read/write) 125992 125992 0 0.0
.bss 53456 53456 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510818 1510818 0 0.0
bridge-app debug+rpc (read only) 1367285 1367285 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1147589 0 0.0
chip-tool debug (read only) 6528285 6528285 0 0.0
(read/write) 199760 199760 0 0.0
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 304984 0 0.0
.text 5816693 5816693 0 0.0
lighting-app debug+rpc (read only) 1651097 1651097 0 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1373906 0 0.0
ota-provider-app debug (read only) 1327881 1327881 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1106514 0 0.0
ota-requestor-app debug (read only) 1427937 1427937 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1191186 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944817 1944817 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1626946 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299376 2299376 0 0.0
.bss 181892 181892 0 0.0
.data 5168 5168 0 0.0
.heap 849384 849384 0 0.0
.text 1261976 1261976 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284104 2284104 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246704 1246704 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257200 2257200 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219800 1219800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 880507 880507 0 0.0
bss 113396 113396 0 0.0
rodata 98540 98540 0 0.0
text 593036 593036 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 843883 843883 0 0.0
bss 109744 109744 0 0.0
rodata 89900 89900 0 0.0
text 568032 568032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806422 806422 0 0.0
bss 114768 114768 0 0.0
rodata 93800 93800 0 0.0
text 523376 523376 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 851335 851335 0 0.0
bss 110432 110432 0 0.0
rodata 94280 94280 0 0.0
text 571288 571288 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 777518 777518 0 0.0
bss 111844 111844 0 0.0
rodata 89568 89568 0 0.0
text 501720 501720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 857379 857379 0 0.0
bss 110568 110568 0 0.0
rodata 96012 96012 0 0.0
text 575356 575356 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 850459 850459 0 0.0
bss 110448 110448 0 0.0
rodata 94148 94148 0 0.0
text 570416 570416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779903 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521924 521924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694946 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442528 442528 0 0.0
p6 all-clusters-app default (read/write) 2320840 2320840 0 0.0
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1279104 1279104 0 0.0
light-app default (read/write) 2256624 2256624 0 0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214888 1214888 0 0.0
lock-app default (read/write) 2231984 2231984 0 0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1190248 1190248 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@michalbudzon-q michalbudzon-q force-pushed the qvCHIP_API branch 2 times, most recently from 1ab055f to 27a7260 Compare December 3, 2021 12:01
@stale
Copy link

stale bot commented Dec 10, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 10, 2021
@stale stale bot removed the stale Stale issue or PR label Dec 10, 2021
@michalbudzon-q michalbudzon-q marked this pull request as ready for review December 10, 2021 15:31
@stale
Copy link

stale bot commented Dec 17, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 17, 2021
@stale stale bot removed the stale Stale issue or PR label Dec 18, 2021
@bzbarsky-apple
Copy link
Contributor

@michalbudzon-q please resolve the merge conflict?

@restyled-io restyled-io bot mentioned this pull request Dec 22, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 22, 2021 •
edited
Loading

PR #12476: Size comparison from fcbcac2 to 6680aaa

Increases (2 builds for qpg)
platform target config section fcbcac2 6680aaa change % change
qpg lighting-app qpg6105+debug (read only) 531192 531200 8 0.0
.text 525872 525880 8 0.0
lock-app qpg6105+debug (read only) 502860 502868 8 0.0
.text 497540 497548 8 0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fcbcac2 6680aaa change % change
efr32 lighting-app BRD4161A (read only) 828908 828908 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828900 828900 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
esp32 all-clusters-app c3devkit (read only) 882588 882588 0 0.0
(read/write) 1312402 1312402 0 0.0
.dram0.bss 69072 69072 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 176056 176056 0 0.0
.flash.text 882588 882588 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 942807 942807 0 0.0
(read/write) 441512 441512 0 0.0
.dram0.bss 73568 73568 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202880 202880 0 0.0
.flash.text 937423 937423 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647520 647520 0 0.0
.bss 76184 76184 0 0.0
.data 1904 1904 0 0.0
.text 563632 563632 0 0.0
lock k32w061+release (read/write) 632248 632248 0 0.0
.bss 75896 75896 0 0.0
.data 1860 1860 0 0.0
.text 548692 548692 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6997268 6997268 0 0.0
(read/write) 325841 325841 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 210056 210056 0 0.0
.dynamic 560 560 0 0.0
.got 56776 56776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383884 383884 0 0.0
.text 5920004 5920004 0 0.0
thermostat-no-ble arm64 (read only) 2011508 2011508 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128468 128468 0 0.0
.text 1670512 1670512 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338880 2338880 0 0.0
.bss 188332 188332 0 0.0
.data 5272 5272 0 0.0
.text 1301456 1301456 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329160 2329160 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291760 1291760 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302192 2302192 0 0.0
.bss 179656 179656 0 0.0
.data 5544 5544 0 0.0
.text 1264792 1264792 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935343 935343 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631620 631620 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921747 921747 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626932 626932 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859110 859110 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 559060 559060 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907491 907491 0 0.0
bss 117360 117360 0 0.0
rodata 103304 103304 0 0.0
text 609448 609448 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831406 831406 0 0.0
bss 115672 115672 0 0.0
rodata 98268 98268 0 0.0
text 536924 536924 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908755 908755 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610684 610684 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905571 905571 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608196 608196 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2390792 2390792 0 0.0
.bss 116532 116532 0 0.0
.data 2552 2552 0 0.0
.text 1349056 1349056 0 0.0
light-app default (read/write) 2323648 2323648 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281912 1281912 0 0.0
lock-app default (read/write) 2295864 2295864 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254128 1254128 0 0.0
qpg lighting-app qpg6105+debug (read only) 531192 531200 8 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525872 525880 8 0.0
lock-app qpg6105+debug (read only) 502860 502868 8 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497540 497548 8 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831682 831682 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580162 580162 0 0.0

@tima-q tima-q changed the title Replace Nvm_Init with KvsInit [QPG] Replace Nvm_Init with KvsInit Dec 23, 2021
@tima-q tima-q added the qpg QPG6xxx platform label Dec 23, 2021
@stale
Copy link

stale bot commented Dec 31, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 31, 2021
@andy31415 andy31415 merged commit 4ffeeb3 into project-chip:master Jan 4, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@michalbudzon-q @step0035
Replace Nvm_Init with KvsInit. Update qvCHIP API. (project-chip#12476)
af2ce95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
platform qpg QPG6xxx platform review - approved stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalbudzon-q @bzbarsky-apple @msandstedt @andy31415 @tima-q