-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding IsSleepyDevice() and related tests #12447
Adding IsSleepyDevice() and related tests #12447
Conversation
PR #12447: Size comparison from 7cba51d to 794b660 Full report (24 builds for efr32, k32w, linux, mbed, p6, telink)
|
Dummy function to be removed once BDX downloader is implemented and can return a real instanceconnectedhomeip/examples/ota-requestor-app/linux/LinuxOTAImageProcessor.cpp Lines 25 to 35 in 3b7b231
This comment was generated by todo based on a
|
Process block header if anyconnectedhomeip/examples/ota-requestor-app/linux/LinuxOTAImageProcessor.cpp Lines 152 to 162 in 3b7b231
This comment was generated by todo based on a
|
Log SoftwareFault eventconnectedhomeip/src/app/clusters/software_diagnostics_server/software_diagnostics_server.cpp Lines 143 to 150 in 3b7b231
This comment was generated by todo based on a
|
@woody-apple , @pan-apple , @ifyall , I was having trouble pushing commits to this PR. I don't know if I did something wrong, or if is has something to do with Woody's "/rebase" earlier today. I was able to do this...
...and then I was able to push. But now there are additional commits associated with this PR that I had nothing to do with. Should I abandon this PR and create a new one? This one has become a bit of a mess for such a "simple" update. |
3b7b231
to
7092d1f
Compare
Rebasing the PR can cause this. It might be best to create a new branch (on tip of master), and cherry pick your commits to the new branch, and push as a new PR. |
PR #12447: Size comparison from a484e4c to 7092d1f Full report (26 builds for efr32, esp32, k32w, linux, mbed, p6, telink)
|
PR #12447: Size comparison from a484e4c to 7053a31 Increases above 0.2%:
Increases (19 builds for efr32, k32w, linux, p6, telink)
Decreases (6 builds for k32w, linux, p6)
Full report (19 builds for efr32, k32w, linux, p6, telink)
|
7053a31
to
0406b46
Compare
PR #12447: Size comparison from fc07dcf to 0406b46 Full report (29 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
PR #12447: Size comparison from fc07dcf to 63d66db Increases above 0.2%:
Increases (15 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (9 builds for esp32, linux, mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Need to identify a peer device as a sleepy device
see #11502
Change overview
Added functions to identify a peer device as a sleepy device. Also added related unit tests.
Testing
Unit testing was added and is part of this pull request.