Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename StatusResponse::SendStatusResponse to StatusResponse::Send. #12440

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Rename StatusResponse::SendStatusResponse to StatusResponse::Send. #12440

merged 1 commit into from
Dec 1, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Shorter, and just as clear.

Problem

Existing name is pretty redundant.

Change overview

Shorter, but still clear, name.

Testing

Tree compiles.

@boring-cyborg boring-cyborg bot added the app label Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #12440: Size comparison from ffee2a9 to d1e0357

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ffee2a9f d1e0357 change % change
efr32 lighting-app BRD4161A (read only) 729080 729080 0 0.0
(read/write) 119580 119580 0 0.0
.bss 117764 117764 0 0.0
.data 1812 1812 0 0.0
.text 729072 729072 0 0.0
BRD4161A+rpc (read only) 757720 757720 0 0.0
(read/write) 137884 137884 0 0.0
.bss 135964 135964 0 0.0
.data 1920 1920 0 0.0
.text 757712 757712 0 0.0
lock-app BRD4161A (read only) 702924 702924 0 0.0
(read/write) 117284 117284 0 0.0
.bss 115516 115516 0 0.0
.data 1768 1768 0 0.0
.text 702916 702916 0 0.0
window-app BRD4161A (read only) 706052 706052 0 0.0
(read/write) 117708 117708 0 0.0
.bss 115932 115932 0 0.0
.data 1776 1776 0 0.0
.text 706044 706044 0 0.0
esp32 all-clusters-app c3devkit (read only) 838994 838994 0 0.0
(read/write) 1224810 1224810 0 0.0
.dram0.bss 58720 58720 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166816 166816 0 0.0
.flash.text 838994 838994 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910427 910427 0 0.0
(read/write) 424056 424056 0 0.0
.dram0.bss 64120 64120 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194656 194656 0 0.0
.flash.text 905043 905043 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 726628 726628 0 0.0
.bss 78956 78956 0 0.0
.data 1844 1844 0 0.0
.text 640028 640028 0 0.0
lock-app k32w061+debug (read/write) 615632 615632 0 0.0
.bss 69396 69396 0 0.0
.data 1808 1808 0 0.0
.text 538628 538628 0 0.0
shell k32w061+debug (read/write) 681432 681432 0 0.0
.bss 80996 80996 0 0.0
.data 1780 1780 0 0.0
.text 592856 592856 0 0.0
linux all-clusters-app debug (read only) 1795177 1795177 0 0.0
(read/write) 125800 125800 0 0.0
.bss 53360 53360 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66032 66032 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145685 145685 0 0.0
.text 1509250 1509250 0 0.0
bridge-app debug+rpc (read only) 1365149 1365149 0 0.0
(read/write) 71888 71888 0 0.0
.bss 35408 35408 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118724 118724 0 0.0
.text 1145589 1145589 0 0.0
chip-tool debug (read only) 6434997 6434997 0 0.0
(read/write) 198512 198512 0 0.0
.bss 33704 33704 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 158216 158216 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 301176 301176 0 0.0
.text 5729989 5729989 0 0.0
lighting-app debug+rpc (read only) 1648985 1648985 0 0.0
(read/write) 104944 104944 0 0.0
.bss 41072 41072 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138417 138417 0 0.0
.text 1371986 1371986 0 0.0
ota-provider-app debug (read only) 1325801 1325801 0 0.0
(read/write) 70344 70344 0 0.0
.bss 37984 37984 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120136 120136 0 0.0
.text 1104594 1104594 0 0.0
ota-requestor-app debug (read only) 1425873 1425873 0 0.0
(read/write) 74240 74240 0 0.0
.bss 40096 40096 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132048 132048 0 0.0
.text 1189314 1189314 0 0.0
shell debug (read only) 814361 814361 0 0.0
(read/write) 60232 60232 0 0.0
.bss 16872 16872 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83538 83538 0 0.0
.text 624738 624738 0 0.0
tv-app debug (read only) 1942161 1942161 0 0.0
(read/write) 314608 314608 0 0.0
.bss 245464 245464 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 167944 167944 0 0.0
.text 1625058 1625058 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298528 2298528 0 0.0
.bss 181788 181788 0 0.0
.data 5168 5168 0 0.0
.heap 849488 849488 0 0.0
.text 1261128 1261128 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283280 2283280 0 0.0
.bss 172816 172816 0 0.0
.data 5480 5480 0 0.0
.heap 858152 858152 0 0.0
.text 1245880 1245880 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2256312 2256312 0 0.0
.bss 171632 171632 0 0.0
.data 5480 5480 0 0.0
.heap 859336 859336 0 0.0
.text 1218912 1218912 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046056 2046056 0 0.0
.bss 156624 156624 0 0.0
.data 4864 4864 0 0.0
.heap 874960 874960 0 0.0
.text 1008656 1008656 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 878759 878759 0 0.0
bss 113316 113316 0 0.0
rodata 97928 97928 0 0.0
text 591956 591956 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 841207 841207 0 0.0
bss 109664 109664 0 0.0
rodata 89288 89288 0 0.0
text 566056 566056 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803746 803746 0 0.0
bss 114688 114688 0 0.0
rodata 93188 93188 0 0.0
text 521412 521412 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 849587 849587 0 0.0
bss 110352 110352 0 0.0
rodata 93668 93668 0 0.0
text 570204 570204 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 774842 774842 0 0.0
bss 111764 111764 0 0.0
rodata 88956 88956 0 0.0
text 499752 499752 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 855599 855599 0 0.0
bss 110488 110488 0 0.0
rodata 95400 95400 0 0.0
text 574272 574272 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 848663 848663 0 0.0
bss 110368 110368 0 0.0
rodata 93536 93536 0 0.0
text 569332 569332 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779359 779359 0 0.0
bss 109616 109616 0 0.0
rodata 73284 73284 0 0.0
text 521952 521952 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694406 694406 0 0.0
bss 110600 110600 0 0.0
rodata 67928 67928 0 0.0
text 442560 442560 0 0.0
p6 all-clusters-app default (read/write) 2320248 2320248 0 0.0
.bss 109872 109872 0 0.0
.data 2464 2464 0 0.0
.heap 921008 921008 0 0.0
.text 1278512 1278512 0 0.0
light-app default (read/write) 2255960 2255960 0 0.0
.bss 97936 97936 0 0.0
.data 2328 2328 0 0.0
.heap 933080 933080 0 0.0
.text 1214224 1214224 0 0.0
lock-app default (read/write) 2231320 2231320 0 0.0
.bss 96592 96592 0 0.0
.data 2288 2288 0 0.0
.heap 934464 934464 0 0.0
.text 1189584 1189584 0 0.0
qpg lighting-app qpg6100+debug (read only) 498508 498508 0 0.0
(read/write) 114144 114144 0 0.0
.bss 79848 79848 0 0.0
.data 944 944 0 0.0
.text 493188 493188 0 0.0
lock-app qpg6100+debug (read only) 471112 471112 0 0.0
(read/write) 114144 114144 0 0.0
.bss 78760 78760 0 0.0
.data 896 896 0 0.0
.text 465792 465792 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 780778 780778 0 0.0
bss 79896 79896 0 0.0
noinit 37160 37160 0 0.0
text 542808 542808 0 0.0

@andy31415 andy31415 merged commit a02bce4 into project-chip:master Dec 1, 2021
@bzbarsky-apple bzbarsky-apple deleted the status-response-shorter branch December 1, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @yunhanw-google @andy31415