Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template function in TagBoundEncoder #12273

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Fix template function in TagBoundEncoder #12273

merged 1 commit into from
Nov 25, 2021

Conversation

mlepage-google
Copy link
Contributor

Should take argument with perfect forwarding, otherwise non-copyable
arguments don't work.

Problem

Can't encode non-copyable/non-movable type.

Change overview

Fix template function signature.

Testing

Built, ran cert tests.

@mlepage-google
Fix template function in TagBoundEncoder
0c0d012 
Should take argument with perfect forwarding, otherwise non-copyable
arguments don't work.
@boring-cyborg boring-cyborg bot added the app label Nov 25, 2021
@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12273: Size comparison from 15929eb to 0c0d012

Increases (3 builds for linux)
platform target config section 15929eb 0c0d012 change % change
linux bridge-app debug+rpc (read only) 1346365 1346893 528 0.0
.text 1133189 1133717 528 0.0
lighting-app debug+rpc (read only) 1619433 1619945 512 0.0
.text 1350338 1350850 512 0.0
tv-app debug (read only) 1916225 1916721 496 0.0
.text 1608594 1609090 496 0.0
Decreases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 15929eb 0c0d012 change % change
efr32 lighting-app BRD4161A (read only) 759568 759312 -256 -0.0
.text 759560 759304 -256 -0.0
BRD4161A+rpc (read only) 747236 746980 -256 -0.0
.text 747228 746972 -256 -0.0
lock-app BRD4161A (read only) 735504 735248 -256 -0.0
.text 735496 735240 -256 -0.0
window-app BRD4161A (read only) 738960 738688 -272 -0.0
.text 738952 738680 -272 -0.0
esp32 all-clusters-app c3devkit (read only) 835796 835446 -350 -0.0
.flash.text 835796 835446 -350 -0.0
m5stack (read only) 907139 906859 -280 -0.0
.flash.text 901755 901475 -280 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 721348 721236 -112 -0.0
.text 635316 635204 -112 -0.0
lock-app k32w061+debug (read/write) 611668 611540 -128 -0.0
.text 535232 535104 -128 -0.0
shell k32w061+debug (read/write) 676972 676860 -112 -0.0
.text 589412 589300 -112 -0.0
linux all-clusters-app debug (read only) 1770537 1769177 -1360 -0.1
.text 1493714 1492354 -1360 -0.1
ota-requestor-app debug (read only) 1405849 1405801 -48 -0.0
.text 1176498 1176450 -48 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293680 2293360 -320 -0.0
.text 1256280 1255960 -320 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2277712 2277648 -64 -0.0
.text 1240312 1240248 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252096 2252032 -64 -0.0
.text 1214696 1214632 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873643 873547 -96 -0.0
text 588544 588448 -96 -0.0
nrf52840dk_nrf52840+rpc (read/write) 836203 836107 -96 -0.0
text 562844 562748 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 798666 798570 -96 -0.0
text 518004 517908 -96 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 845799 845703 -96 -0.0
text 567856 567760 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771070 770974 -96 -0.0
text 497412 497316 -96 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 851899 851803 -96 -0.0
text 572040 571944 -96 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845491 845395 -96 -0.0
text 567476 567380 -96 -0.0
p6 all-clusters-app default (read/write) 2310568 2309928 -640 -0.0
.text 1268832 1268192 -640 -0.1
lock-app default (read/write) 2222400 2222208 -192 -0.0
.text 1180664 1180472 -192 -0.0
qpg lighting-app qpg6100+debug (read only) 501148 501036 -112 -0.0
.text 495828 495716 -112 -0.0
lock-app qpg6100+debug (read only) 475116 474988 -128 -0.0
.text 469796 469668 -128 -0.0
telink lighting-app tlsr9518adk80d (read/write) 775246 775038 -208 -0.0
text 539022 538816 -206 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 15929eb 0c0d012 change % change
efr32 lighting-app BRD4161A (read only) 759568 759312 -256 -0.0
(read/write) 119812 119812 0 0.0
.bss 117988 117988 0 0.0
.data 1820 1820 0 0.0
.text 759560 759304 -256 -0.0
BRD4161A+rpc (read only) 747236 746980 -256 -0.0
(read/write) 136436 136436 0 0.0
.bss 134492 134492 0 0.0
.data 1944 1944 0 0.0
.text 747228 746972 -256 -0.0
lock-app BRD4161A (read only) 735504 735248 -256 -0.0
(read/write) 117524 117524 0 0.0
.bss 115748 115748 0 0.0
.data 1776 1776 0 0.0
.text 735496 735240 -256 -0.0
window-app BRD4161A (read only) 738960 738688 -272 -0.0
(read/write) 117884 117884 0 0.0
.bss 116100 116100 0 0.0
.data 1784 1784 0 0.0
.text 738952 738680 -272 -0.0
esp32 all-clusters-app c3devkit (read only) 835796 835446 -350 -0.0
(read/write) 1224250 1224250 0 0.0
.dram0.bss 59120 59120 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165776 165776 0 0.0
.flash.text 835796 835446 -350 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907139 906859 -280 -0.0
(read/write) 423492 423492 0 0.0
.dram0.bss 64512 64512 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193628 193628 0 0.0
.flash.text 901755 901475 -280 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 721348 721236 -112 -0.0
.bss 78276 78276 0 0.0
.data 1956 1956 0 0.0
.text 635316 635204 -112 -0.0
lock-app k32w061+debug (read/write) 611668 611540 -128 -0.0
.bss 68716 68716 0 0.0
.data 1920 1920 0 0.0
.text 535232 535104 -128 -0.0
shell k32w061+debug (read/write) 676972 676860 -112 -0.0
.bss 79868 79868 0 0.0
.data 1892 1892 0 0.0
.text 589412 589300 -112 -0.0
linux all-clusters-app debug (read only) 1770537 1769177 -1360 -0.1
(read/write) 131480 131480 0 0.0
.bss 60080 60080 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138453 138453 0 0.0
.text 1493714 1492354 -1360 -0.1
bridge-app debug+rpc (read only) 1346365 1346893 528 0.0
(read/write) 77824 77824 0 0.0
.bss 41712 41712 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113084 113084 0 0.0
.text 1133189 1133717 528 0.0
chip-tool debug (read only) 6070205 6070205 0 0.0
(read/write) 199728 199728 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151712 151712 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 290408 290408 0 0.0
.text 5391077 5391077 0 0.0
lighting-app debug+rpc (read only) 1619433 1619945 512 0.0
(read/write) 111072 111072 0 0.0
.bss 47408 47408 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131377 131377 0 0.0
.text 1350338 1350850 512 0.0
ota-provider-app debug (read only) 1309361 1309361 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114736 114736 0 0.0
.text 1094274 1094274 0 0.0
ota-requestor-app debug (read only) 1405849 1405801 -48 -0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126208 126208 0 0.0
.text 1176498 1176450 -48 -0.0
shell debug (read only) 820129 820129 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78927 78927 0 0.0
.text 634514 634514 0 0.0
tv-app debug (read only) 1916225 1916721 496 0.0
(read/write) 320088 320088 0 0.0
.bss 250168 250168 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159432 159432 0 0.0
.text 1608594 1609090 496 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293680 2293360 -320 -0.0
.bss 181668 181668 0 0.0
.data 5240 5240 0 0.0
.heap 849536 849536 0 0.0
.text 1256280 1255960 -320 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277712 2277648 -64 -0.0
.bss 172284 172284 0 0.0
.data 5600 5600 0 0.0
.heap 858560 858560 0 0.0
.text 1240312 1240248 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252096 2252032 -64 -0.0
.bss 171100 171100 0 0.0
.data 5584 5584 0 0.0
.heap 859760 859760 0 0.0
.text 1214696 1214632 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050584 2050584 0 0.0
.bss 156304 156304 0 0.0
.data 4984 4984 0 0.0
.heap 875160 875160 0 0.0
.text 1013184 1013184 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873643 873547 -96 -0.0
bss 112644 112644 0 0.0
rodata 96788 96788 0 0.0
text 588544 588448 -96 -0.0
nrf52840dk_nrf52840+rpc (read/write) 836203 836107 -96 -0.0
bss 108996 108996 0 0.0
rodata 88036 88036 0 0.0
text 562844 562748 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 798666 798570 -96 -0.0
bss 114020 114020 0 0.0
rodata 92044 92044 0 0.0
text 518004 517908 -96 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 845799 845703 -96 -0.0
bss 109680 109680 0 0.0
rodata 92792 92792 0 0.0
text 567856 567760 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771070 770974 -96 -0.0
bss 111088 111088 0 0.0
rodata 88080 88080 0 0.0
text 497412 497316 -96 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 851899 851803 -96 -0.0
bss 109816 109816 0 0.0
rodata 94500 94500 0 0.0
text 572040 571944 -96 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845491 845395 -96 -0.0
bss 109712 109712 0 0.0
rodata 92748 92748 0 0.0
text 567476 567380 -96 -0.0
shell nrf52840dk_nrf52840 (read/write) 778319 778319 0 0.0
bss 109180 109180 0 0.0
rodata 72988 72988 0 0.0
text 521552 521552 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693374 693374 0 0.0
bss 110164 110164 0 0.0
rodata 67632 67632 0 0.0
text 442160 442160 0 0.0
p6 all-clusters-app default (read/write) 2310568 2309928 -640 -0.0
.bss 114664 114664 0 0.0
.data 2544 2544 0 0.0
.heap 916136 916136 0 0.0
.text 1268832 1268192 -640 -0.1
lock-app default (read/write) 2222400 2222208 -192 -0.0
.bss 100960 100960 0 0.0
.data 2416 2416 0 0.0
.heap 929968 929968 0 0.0
.text 1180664 1180472 -192 -0.0
qpg lighting-app qpg6100+debug (read only) 501148 501036 -112 -0.0
(read/write) 114144 114144 0 0.0
.bss 50384 50384 0 0.0
.data 1024 1024 0 0.0
.text 495828 495716 -112 -0.0
lock-app qpg6100+debug (read only) 475116 474988 -128 -0.0
(read/write) 114140 114140 0 0.0
.bss 49256 49256 0 0.0
.data 980 980 0 0.0
.text 469796 469668 -128 -0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 775246 775038 -208 -0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 539022 538816 -206 -0.0

@andy31415
Copy link
Contributor

fast track: trivial fix

@andy31415 andy31415 merged commit 8a87578 into project-chip:master Nov 25, 2021
@mlepage-google mlepage-google deleted the fix-tag-bound-encoder branch January 12, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlepage-google @andy31415