Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event definitions for OTA Software Update Requestor cluster #12004

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add event definitions for OTA Software Update Requestor cluster #12004

merged 2 commits into from
Nov 22, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • The event definitions for OTA Software Update Requestor cluster are missing.

Change overview

Add event definitions for OTA Software Update Requestor cluster

Testing

How was this tested? (at least one bullet point required)

  • Only xml definitions, no logic change, covered by CI

@github-actions
Copy link

github-actions bot commented Nov 19, 2021 •
edited
Loading

PR #12004: Size comparison from ebadd33 to d09225c

Decreases (1 build for esp32)
platform target config section ebadd33 d09225c change % change
esp32 all-clusters-app m5stack (read only) 899595 899591 -4 -0.0
.flash.text 894211 894207 -4 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ebadd33 d09225c change % change
efr32 lighting-app BRD4161A (read only) 749960 749960 0 0.0
(read/write) 115540 115540 0 0.0
.bss 113740 113740 0 0.0
.data 1800 1800 0 0.0
.text 749952 749952 0 0.0
BRD4161A+rpc (read only) 737484 737484 0 0.0
(read/write) 132168 132168 0 0.0
.bss 130244 130244 0 0.0
.data 1924 1924 0 0.0
.text 737476 737476 0 0.0
lock-app BRD4161A (read only) 727016 727016 0 0.0
(read/write) 113324 113324 0 0.0
.bss 111564 111564 0 0.0
.data 1756 1756 0 0.0
.text 727008 727008 0 0.0
window-app BRD4161A (read only) 728000 728000 0 0.0
(read/write) 113644 113644 0 0.0
.bss 111884 111884 0 0.0
.data 1760 1760 0 0.0
.text 727992 727992 0 0.0
esp32 all-clusters-app c3devkit (read only) 828538 828538 0 0.0
(read/write) 1220178 1220178 0 0.0
.dram0.bss 56688 56688 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164152 164152 0 0.0
.flash.text 828538 828538 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899595 899591 -4 -0.0
(read/write) 419492 419492 0 0.0
.dram0.bss 62040 62040 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192116 192116 0 0.0
.flash.text 894211 894207 -4 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706872 706872 0 0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 621996 621996 0 0.0
lock-app k32w061+debug (read/write) 598312 598312 0 0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 522956 522956 0 0.0
shell k32w061+debug (read/write) 663656 663656 0 0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 577204 577204 0 0.0
linux all-clusters-app debug (read only) 1726153 1726153 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57392 57392 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136661 136661 0 0.0
.text 1455538 1455538 0 0.0
bridge-app debug+rpc (read only) 1321181 1321181 0 0.0
(read/write) 77008 77008 0 0.0
.bss 42096 42096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111932 111932 0 0.0
.text 1111845 1111845 0 0.0
chip-tool debug (read only) 4986061 4986061 0 0.0
(read/write) 166888 166888 0 0.0
.bss 40456 40456 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118672 118672 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268458 268458 0 0.0
.text 4407093 4407093 0 0.0
lighting-app debug+rpc (read only) 1590289 1590289 0 0.0
(read/write) 110224 110224 0 0.0
.bss 47760 47760 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129553 129553 0 0.0
.text 1325730 1325730 0 0.0
ota-provider-app debug (read only) 1268729 1268729 0 0.0
(read/write) 75656 75656 0 0.0
.bss 44704 44704 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113951 113951 0 0.0
.text 1057186 1057186 0 0.0
ota-requestor-app debug (read only) 1354465 1354465 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47168 47168 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124968 124968 0 0.0
.text 1129522 1129522 0 0.0
shell debug (read only) 798801 798801 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616082 616082 0 0.0
tv-app debug (read only) 1872785 1872785 0 0.0
(read/write) 318968 318968 0 0.0
.bss 250376 250376 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60144 60144 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157893 157893 0 0.0
.text 1569762 1569762 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287616 2287616 0 0.0
.bss 179284 179284 0 0.0
.data 5216 5216 0 0.0
.heap 851944 851944 0 0.0
.text 1250216 1250216 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273552 2273552 0 0.0
.bss 172148 172148 0 0.0
.data 5576 5576 0 0.0
.heap 858720 858720 0 0.0
.text 1236152 1236152 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249456 2249456 0 0.0
.bss 171036 171036 0 0.0
.data 5568 5568 0 0.0
.heap 859840 859840 0 0.0
.text 1212056 1212056 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864595 864595 0 0.0
bss 110560 110560 0 0.0
rodata 95828 95828 0 0.0
text 582604 582604 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 826995 826995 0 0.0
bss 106916 106916 0 0.0
rodata 87012 87012 0 0.0
text 556772 556772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789650 789650 0 0.0
bss 111936 111936 0 0.0
rodata 91084 91084 0 0.0
text 512076 512076 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840027 840027 0 0.0
bss 109584 109584 0 0.0
rodata 92300 92300 0 0.0
text 562696 562696 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765330 765330 0 0.0
bss 110996 110996 0 0.0
rodata 87604 87604 0 0.0
text 492260 492260 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846135 846135 0 0.0
bss 109724 109724 0 0.0
rodata 94008 94008 0 0.0
text 566880 566880 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839727 839727 0 0.0
bss 109620 109620 0 0.0
rodata 92256 92256 0 0.0
text 562316 562316 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777971 777971 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521236 521236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693026 693026 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441848 441848 0 0.0
p6 all-clusters-app default (read/write) 2297968 2297968 0 0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1256232 1256232 0 0.0
lock-app default (read/write) 2215456 2215456 0 0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1173720 1173720 0 0.0
qpg lighting-app qpg6100+debug (read only) 493688 493688 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488368 488368 0 0.0
lock-app qpg6100+debug (read only) 468652 468652 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463332 463332 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768010 768010 0 0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 533194 533194 0 0.0

@andy31415
Copy link
Contributor

fast track - small change in definition of clusters only.

@yufengwangca - could your resolve conflicts?

@github-actions
Copy link

github-actions bot commented Nov 22, 2021 •
edited
Loading

PR #12004: Size comparison from aa8a6d0 to 5d4c4d2

Increases (1 build for esp32)
platform target config section aa8a6d0 5d4c4d2 change % change
esp32 all-clusters-app m5stack (read only) 904403 904431 28 0.0
.flash.text 899019 899047 28 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section aa8a6d0 5d4c4d2 change % change
efr32 lighting-app BRD4161A (read only) 750736 750736 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750728 750728 0 0.0
BRD4161A+rpc (read only) 738276 738276 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 738268 738268 0 0.0
lock-app BRD4161A (read only) 727808 727808 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727800 727800 0 0.0
window-app BRD4161A (read only) 728792 728792 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728784 728784 0 0.0
esp32 all-clusters-app c3devkit (read only) 833410 833410 0 0.0
(read/write) 1221938 1221938 0 0.0
.dram0.bss 57752 57752 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 164840 164840 0 0.0
.flash.text 833410 833410 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904403 904431 28 0.0
(read/write) 421232 421232 0 0.0
.dram0.bss 63112 63112 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192784 192784 0 0.0
.flash.text 899019 899047 28 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707528 707528 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622604 622604 0 0.0
lock-app k32w061+debug (read/write) 598960 598960 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523564 523564 0 0.0
shell k32w061+debug (read/write) 664336 664336 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577812 577812 0 0.0
linux all-clusters-app debug (read only) 1746601 1746601 0 0.0
(read/write) 128392 128392 0 0.0
.bss 58544 58544 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63504 63504 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 137781 137781 0 0.0
.text 1473186 1473186 0 0.0
bridge-app debug+rpc (read only) 1326413 1326413 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112316 112316 0 0.0
.text 1116693 1116693 0 0.0
chip-tool debug (read only) 5867301 5867301 0 0.0
(read/write) 195496 195496 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 147872 147872 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 278122 278122 0 0.0
.text 5210149 5210149 0 0.0
lighting-app debug+rpc (read only) 1595521 1595521 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129937 129937 0 0.0
.text 1330578 1330578 0 0.0
ota-provider-app debug (read only) 1273961 1273961 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114335 114335 0 0.0
.text 1062034 1062034 0 0.0
ota-requestor-app debug (read only) 1370209 1370209 0 0.0
(read/write) 78912 78912 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26408 26408 0 0.0
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125736 125736 0 0.0
.text 1144098 1144098 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1888137 1888137 0 0.0
(read/write) 318520 318520 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158629 158629 0 0.0
.text 1584066 1584066 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290256 2290256 0 0.0
.bss 180308 180308 0 0.0
.data 5224 5224 0 0.0
.heap 850912 850912 0 0.0
.text 1252856 1252856 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274384 2274384 0 0.0
.bss 172204 172204 0 0.0
.data 5576 5576 0 0.0
.heap 858664 858664 0 0.0
.text 1236984 1236984 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250224 2250224 0 0.0
.bss 171092 171092 0 0.0
.data 5568 5568 0 0.0
.heap 859784 859784 0 0.0
.text 1212824 1212824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050544 2050544 0 0.0
.bss 156280 156280 0 0.0
.data 4968 4968 0 0.0
.heap 875200 875200 0 0.0
.text 1013144 1013144 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865267 865267 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 583200 583200 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827635 827635 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557368 557368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790306 790306 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512672 512672 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840651 840651 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563296 563296 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765954 765954 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492856 492856 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846791 846791 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567476 567476 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840351 840351 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562916 562916 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2303032 2303032 0 0.0
.bss 113280 113280 0 0.0
.data 2528 2528 0 0.0
.heap 917536 917536 0 0.0
.text 1261296 1261296 0 0.0
lock-app default (read/write) 2216232 2216232 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174496 1174496 0 0.0
qpg lighting-app qpg6100+debug (read only) 494312 494312 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488992 488992 0 0.0
lock-app qpg6100+debug (read only) 469268 469268 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463948 463948 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768682 768682 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533824 533824 0 0.0

@yufengwangca yufengwangca merged commit 9a6c97b into project-chip:master Nov 22, 2021
@yufengwangca yufengwangca deleted the pr/event/ota branch November 22, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @andy31415 @yunhanw-google