-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send cluster specific errors from AdministratorCommissioning server #11883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #11883: Size comparison from 4d4c4a0 to 5304b15 Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Fixes #10678 |
src/app/clusters/administrator-commissioning-server/administrator-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/administrator-commissioning-server/administrator-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
PR #11883: Size comparison from e568d70 to ee79abb Increases (3 builds for qpg, telink)
Full report (4 builds for qpg, telink)
|
PR #11883: Size comparison from e568d70 to 8944688 Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 18, 2021
src/app/clusters/administrator-commissioning-server/administrator-commissioning-server.cpp
Show resolved
Hide resolved
Damian-Nordic
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Use cluster specific error codes on command failures in AdministratorCommissioning cluster.
Testing
Tested using all-cluster-app and chip-tool. The following conditions were tested.
EMBER_ZCL_STATUS_CODE_WINDOW_NOT_OPEN
was returned.EMBER_ZCL_STATUS_CODE_BUSY
was returned.EMBER_ZCL_STATUS_CODE_PAKE_PARAMETER_ERROR
was returned.