-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Add a prompt command to the LogCommands cluster #11852
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_PromptCommand
Nov 30, 2021
Merged
[YAML] Add a prompt command to the LogCommands cluster #11852
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_PromptCommand
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
changed the title
Yaml prompt command
[YAML] Add a prompt command to the LogCommands cluster
Nov 16, 2021
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
November 16, 2021 17:00
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
wbschiller,
woody-apple and
yunhanw-google
November 16, 2021 17:00
trombadore-google
suggested changes
Nov 16, 2021
src/app/zap-templates/common/simulated-clusters/TestLogCommands.js
Outdated
Show resolved
Hide resolved
PR #11852: Size comparison from 09f9837 to 9c4e597 Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 17, 2021
vivien-apple
force-pushed
the
YAML_PromptCommand
branch
from
November 17, 2021 09:02
9c4e597
to
00f5a8a
Compare
PR #11852: Size comparison from cbd3e95 to 00f5a8a Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 17, 2021
trombadore-google
approved these changes
Nov 17, 2021
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
vivien-apple
force-pushed
the
YAML_PromptCommand
branch
from
November 25, 2021 08:59
00f5a8a
to
3fdeb99
Compare
PR #11852: Size comparison from c79b67b to 3fdeb99 Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
woody-apple
approved these changes
Nov 30, 2021
vivien-apple
force-pushed
the
YAML_PromptCommand
branch
from
November 30, 2021 14:17
3fdeb99
to
796833f
Compare
PR #11852: Size comparison from 7e99454 to 796833f Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fast tracking given this enables tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Needs a log command with a prefix that is always the same.
Change overview
prompt
command toLogCommands
Testing
It has been added to
TestLogCommands.yaml
#fixes #11853