-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing param when compiling simulator #11819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
929ad17
to
d988c82
Compare
PR #11819: Size comparison from 1903401 to d988c82 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Nov 16, 2021
what is this simulator for? |
yunhanw-google
approved these changes
Nov 16, 2021
bzbarsky-apple
approved these changes
Nov 16, 2021
bzbarsky-apple
requested changes
Nov 16, 2021
03bac00
to
a2c53b9
Compare
vivien-apple
approved these changes
Nov 16, 2021
Thanks for fixing it! |
bzbarsky-apple
approved these changes
Nov 16, 2021
PR #11819: Size comparison from 09f9837 to a2c53b9 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 18, 2021
* Resolve missing param when compiling simulator and add simulator build to workflow. * Revert github workflows.
raqbit
pushed a commit
to raqbit/connectedhomeip
that referenced
this pull request
Nov 19, 2021
* Resolve missing param when compiling simulator and add simulator build to workflow. * Revert github workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #11761 was filed. Compiling fails on the simulator app.
Change overview
Add missing argument.
Add GitHub workflow.
Testing
Compiled without change verified issue, compiled with the change and verified that issue was resolved.