Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIPCert: Update to Support Single CASE Authenticated Tag OID. #11697

Merged
merged 1 commit into from
Nov 12, 2021
Merged

CHIPCert: Update to Support Single CASE Authenticated Tag OID. #11697

merged 1 commit into from
Nov 12, 2021

Conversation

emargolis
Copy link
Contributor

Problem

Spec is updated to support single CAT type.

Change overview

-- Support single CAT OID to match spec changes.
-- Added Utility function to Extract OID array from the subject of OpCert.
-- Updated test vectors to match the change. Added new test vector which
includes 3 CAT OIDs in its subject.

Testing

Unit tested. Added new tests.

@emargolis
CHIPCert: Update to Support Single CASE Authenticated Tag OID.
85c2bf0 
  -- Support single CAT OID to match spec changes.
  -- Added Utility function to Extract OID array from the subject of OpCert.
  -- Updated test vectors to match the change. Added new test vector which
     includes 3 CAT OIDs in its subject.
@boring-cyborg boring-cyborg bot added the lib label Nov 11, 2021
@github-actions
Copy link

PR #11697: Size comparison from 60ffc53 to 85c2bf0

Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 60ffc53 85c2bf0 change % change
efr32 lighting-app BRD4161A (read only) 745240 745216 -24 -0.0
.text 745232 745208 -24 -0.0
lock-app BRD4161A (read only) 722064 722040 -24 -0.0
.text 722056 722032 -24 -0.0
window-app BRD4161A (read only) 722992 722952 -40 -0.0
.text 722984 722944 -40 -0.0
lighting-app BRD4161A+rpc (read only) 732788 732748 -40 -0.0
.text 732780 732740 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 821852 821810 -42 -0.0
(read/write) 1221906 1221882 -24 -0.0
.flash.rodata 166728 166704 -24 -0.0
.flash.text 821852 821810 -42 -0.0
m5stack (read only) 892951 892907 -44 -0.0
(read/write) 420080 420056 -24 -0.0
.flash.rodata 193780 193756 -24 -0.0
.flash.text 887567 887523 -44 -0.0
k32w lock-app k32w061+debug (read/write) 591644 591608 -36 -0.0
.text 515972 515936 -36 -0.0
shell k32w061+debug (read/write) 657324 657272 -52 -0.0
.text 570892 570840 -52 -0.0
lighting-app k32w061+se05x+release (read/write) 700424 700372 -52 -0.0
.text 615240 615188 -52 -0.0
linux all-clusters-app debug (read only) 1699113 1699041 -72 -0.0
(read/write) 125856 125824 -32 -0.0
.data.rel.ro 62256 62224 -32 -0.1
.rodata 139125 139093 -32 -0.0
.text 1426498 1426482 -16 -0.0
chip-tool debug (read only) 4813261 4813221 -40 -0.0
(read/write) 136448 136416 -32 -0.0
.data.rel.ro 103336 103320 -16 -0.0
.text 4288629 4288613 -16 -0.0
ota-provider-app debug (read only) 1260153 1260097 -56 -0.0
(read/write) 75048 75016 -32 -0.0
.data.rel.ro 24776 24760 -16 -0.1
.text 1050706 1050674 -32 -0.0
ota-requestor-app debug (read only) 1345225 1345169 -56 -0.0
(read/write) 78816 78784 -32 -0.0
.data.rel.ro 26040 26008 -32 -0.1
.text 1122114 1122082 -32 -0.0
tv-app debug (read only) 1843097 1843057 -40 -0.0
(read/write) 407640 407608 -32 -0.0
.data.rel.ro 59600 59568 -32 -0.1
.text 1542802 1542786 -16 -0.0
bridge-app debug+rpc (read only) 1298741 1298669 -72 -0.0
(read/write) 77264 77232 -32 -0.0
.data.rel.ro 27928 27896 -32 -0.1
.rodata 110932 110900 -32 -0.0
.text 1091365 1091349 -16 -0.0
lighting-app debug+rpc (read only) 1565401 1565329 -72 -0.0
(read/write) 109936 109904 -32 -0.0
.data.rel.ro 55456 55424 -32 -0.1
.rodata 128849 128817 -32 -0.0
.text 1302322 1302306 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2289256 2289240 -16 -0.0
.text 1251856 1251840 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272728 2272704 -24 -0.0
.text 1235328 1235304 -24 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248352 2248328 -24 -0.0
.text 1210952 1210928 -24 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862919 862879 -40 -0.0
rodata 96856 96832 -24 -0.0
text 579516 579492 -24 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838151 838099 -52 -0.0
rodata 92920 92900 -20 -0.0
text 559816 559792 -24 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844247 844191 -56 -0.0
rodata 94632 94608 -24 -0.0
text 563980 563956 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838007 837971 -36 -0.0
rodata 92920 92900 -20 -0.0
text 559552 559528 -24 -0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 825307 825255 -52 -0.0
rodata 88044 88024 -20 -0.0
text 553688 553664 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787974 787922 -52 -0.0
rodata 92112 92092 -20 -0.0
text 508984 508960 -24 -0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 763450 763410 -40 -0.0
rodata 88228 88204 -24 -0.0
text 489376 489352 -24 -0.0
p6 all-clusters-app default (read/write) 2297144 2297104 -40 -0.0
.text 1255408 1255368 -40 -0.0
lock-app default (read/write) 2211752 2211728 -24 -0.0
.text 1170016 1169992 -24 -0.0
qpg lighting-app qpg6100+debug (read only) 492240 492196 -44 -0.0
.text 486920 486876 -44 -0.0
lock-app qpg6100+debug (read only) 466976 466932 -44 -0.0
.text 461656 461612 -44 -0.0
telink lighting-app tlsr9518adk80d (read/write) 665114 665066 -48 -0.0
text 459996 459976 -20 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 60ffc53 85c2bf0 change % change
efr32 lighting-app BRD4161A (read only) 745240 745216 -24 -0.0
(read/write) 115764 115764 0 0.0
.bss 113980 113980 0 0.0
.data 1784 1784 0 0.0
.text 745232 745208 -24 -0.0
lock-app BRD4161A (read only) 722064 722040 -24 -0.0
(read/write) 113548 113548 0 0.0
.bss 111804 111804 0 0.0
.data 1740 1740 0 0.0
.text 722056 722032 -24 -0.0
window-app BRD4161A (read only) 722992 722952 -40 -0.0
(read/write) 113868 113868 0 0.0
.bss 112124 112124 0 0.0
.data 1744 1744 0 0.0
.text 722984 722944 -40 -0.0
lighting-app BRD4161A+rpc (read only) 732788 732748 -40 -0.0
(read/write) 132392 132392 0 0.0
.bss 130484 130484 0 0.0
.data 1908 1908 0 0.0
.text 732780 732740 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 821852 821810 -42 -0.0
(read/write) 1221906 1221882 -24 -0.0
.dram0.bss 55832 55832 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 166728 166704 -24 -0.0
.flash.text 821852 821810 -42 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 892951 892907 -44 -0.0
(read/write) 420080 420056 -24 -0.0
.dram0.bss 60920 60920 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 193780 193756 -24 -0.0
.flash.text 887567 887523 -44 -0.0
.iram0.text 122987 122987 0 0.0
k32w lock-app k32w061+debug (read/write) 591644 591608 -36 -0.0
.bss 67996 67996 0 0.0
.data 1876 1876 0 0.0
.text 515972 515936 -36 -0.0
shell k32w061+debug (read/write) 657324 657272 -52 -0.0
.bss 78788 78788 0 0.0
.data 1844 1844 0 0.0
.text 570892 570840 -52 -0.0
lighting-app k32w061+se05x+release (read/write) 700424 700372 -52 -0.0
.bss 77476 77476 0 0.0
.data 1908 1908 0 0.0
.text 615240 615188 -52 -0.0
linux all-clusters-app debug (read only) 1699113 1699041 -72 -0.0
(read/write) 125856 125824 -32 -0.0
.bss 57328 57328 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62224 -32 -0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139125 139093 -32 -0.0
.text 1426498 1426482 -16 -0.0
chip-tool debug (read only) 4813261 4813221 -40 -0.0
(read/write) 136448 136416 -32 -0.0
.bss 25416 25416 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 103336 103320 -16 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 248298 248298 0 0.0
.text 4288629 4288613 -16 -0.0
ota-provider-app debug (read only) 1260153 1260097 -56 -0.0
(read/write) 75048 75016 -32 -0.0
.bss 44416 44416 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24760 -16 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112647 112647 0 0.0
.text 1050706 1050674 -32 -0.0
ota-requestor-app debug (read only) 1345225 1345169 -56 -0.0
(read/write) 78816 78784 -32 -0.0
.bss 46880 46880 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26008 -32 -0.1
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123760 123760 0 0.0
.text 1122114 1122082 -32 -0.0
shell debug (read only) 788665 788665 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77615 77615 0 0.0
.text 609154 609154 0 0.0
tv-app debug (read only) 1843097 1843057 -40 -0.0
(read/write) 407640 407608 -32 -0.0
.bss 339656 339656 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59568 -32 -0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155821 155821 0 0.0
.text 1542802 1542786 -16 -0.0
bridge-app debug+rpc (read only) 1298741 1298669 -72 -0.0
(read/write) 77264 77232 -32 -0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27896 -32 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110900 -32 -0.0
.text 1091365 1091349 -16 -0.0
lighting-app debug+rpc (read only) 1565401 1565329 -72 -0.0
(read/write) 109936 109904 -32 -0.0
.bss 47984 47984 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55456 55424 -32 -0.1
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128849 128817 -32 -0.0
.text 1302322 1302306 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289256 2289240 -16 -0.0
.bss 179412 179412 0 0.0
.data 5216 5216 0 0.0
.heap 851816 851816 0 0.0
.text 1251856 1251840 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272704 -24 -0.0
.bss 172524 172524 0 0.0
.data 5576 5576 0 0.0
.heap 858344 858344 0 0.0
.text 1235328 1235304 -24 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248352 2248328 -24 -0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1210952 1210928 -24 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862919 862879 -40 -0.0
bss 110932 110932 0 0.0
rodata 96856 96832 -24 -0.0
text 579516 579492 -24 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838151 838099 -52 -0.0
bss 109956 109956 0 0.0
rodata 92920 92900 -20 -0.0
text 559816 559792 -24 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844247 844191 -56 -0.0
bss 110096 110096 0 0.0
rodata 94632 94608 -24 -0.0
text 563980 563956 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838007 837971 -36 -0.0
bss 109992 109992 0 0.0
rodata 92920 92900 -20 -0.0
text 559552 559528 -24 -0.0
shell nrf52840dk_nrf52840 (read/write) 775483 775483 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520008 520008 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 825307 825255 -52 -0.0
bss 107284 107284 0 0.0
rodata 88044 88024 -20 -0.0
text 553688 553664 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787974 787922 -52 -0.0
bss 112304 112304 0 0.0
rodata 92112 92092 -20 -0.0
text 508984 508960 -24 -0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 763450 763410 -40 -0.0
bss 111368 111368 0 0.0
rodata 88228 88204 -24 -0.0
text 489376 489352 -24 -0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 690538 690538 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440616 440616 0 0.0
p6 all-clusters-app default (read/write) 2297144 2297104 -40 -0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255408 1255368 -40 -0.0
lock-app default (read/write) 2211752 2211728 -24 -0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170016 1169992 -24 -0.0
qpg lighting-app qpg6100+debug (read only) 492240 492196 -44 -0.0
(read/write) 114144 114144 0 0.0
.bss 50624 50624 0 0.0
.data 1008 1008 0 0.0
.text 486920 486876 -44 -0.0
lock-app qpg6100+debug (read only) 466976 466932 -44 -0.0
(read/write) 114140 114140 0 0.0
.bss 49560 49560 0 0.0
.data 964 964 0 0.0
.text 461656 461612 -44 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665114 665066 -48 -0.0
bss 69304 69304 0 0.0
noinit 33216 33216 0 0.0
text 459996 459976 -20 -0.0

@andy31415
Copy link
Contributor

1day fast track: several review checkmarks, unit tested PR, written by a domain owner.

@andy31415 andy31415 merged commit 3838790 into project-chip:master Nov 12, 2021
@mlepage-google mlepage-google mentioned this pull request Nov 16, 2021
Closed
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@emargolis
CHIPCert: Update to Support Single CASE Authenticated Tag OID. (proje…
1ab43ff 
…ct-chip#11697)

-- Support single CAT OID to match spec changes.
  -- Added Utility function to Extract OID array from the subject of OpCert.
  -- Updated test vectors to match the change. Added new test vector which
     includes 3 CAT OIDs in its subject.
@emargolis emargolis deleted the emargolis/feature/update-case-authenticated-tag branch December 14, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emargolis @andy31415 @tcarmelveilleux @yufengwangca @woody-apple @bzbarsky-apple