Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request unicast responses for resolving nodes when using minmdns #11635

Merged
merged 22 commits into from
Nov 15, 2021
Merged

Request unicast responses for resolving nodes when using minmdns #11635

Changes from 8 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1f948d8
Request unicast responses for resolving nodes when using minmdns
andy31415 Nov 10, 2021
fc0bac5
Set unicast answer to true in browse nodes as well
andy31415 Nov 10, 2021
1f9873b
Make unit tests use platform mdns: chip tool and all clusters all nee…
andy31415 Nov 10, 2021
18004e1
Set the chip_mdns value as a string
andy31415 Nov 10, 2021
4152962
Escape quotes for platform mdns build
andy31415 Nov 10, 2021
697dc95
Merge branch 'master' into unicast_mdns_resolve
andy31415 Nov 10, 2021
09d690d
Revert platform mdns usage in tests: avahi does not properly work for…
andy31415 Nov 11, 2021
0c1417d
Merge branch 'master' into unicast_mdns_resolve
andy31415 Nov 11, 2021
17d8283
Add support for using netns namespaces for unit test runs - check to …
andy31415 Nov 11, 2021
f30680d
Do not restyle test_suites.sh
andy31415 Nov 11, 2021
24164f4
Merge branch 'master' into unicast_mdns_resolve
andy31415 Nov 11, 2021
ee6d5ca
Some script cleanup
andy31415 Nov 11, 2021
9736f34
Temporarely run the tests on ipv4 only until I figure out ipv6 multic…
andy31415 Nov 11, 2021
fe6c438
Cleanup netns as a final step, just in case
andy31415 Nov 11, 2021
759c86f
Move cleanup again - cleanup is added again post-netns setup
andy31415 Nov 11, 2021
205e937
Code review comments, enable ipv6 back
andy31415 Nov 11, 2021
0d3dfe3
Add note on why we stop restuling testsuites.sh
andy31415 Nov 12, 2021
1ff5185
Use unshare instead of sudo to run unit tests in namespaces
andy31415 Nov 12, 2021
ea74977
Update remount logic to only apply for unshare environments
andy31415 Nov 12, 2021
506036a
Updated messaging logic
andy31415 Nov 12, 2021
a3ccf5c
Merge branch 'master' into unicast_mdns_resolve
andy31415 Nov 15, 2021
03f4d6a
Added a sleep for IPv6 and a comment as to why
andy31415 Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/lib/dnssd/Resolver_ImplMinimalMdns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,7 @@ CHIP_ERROR MinMdnsResolver::SendQuery(mdns::Minimal::FullQName qname, mdns::Mini

mdns::Minimal::Query query(qname);
query.SetType(type).SetClass(mdns::Minimal::QClass::IN);
// TODO(cecille): Not sure why unicast response isn't working - fix.
query.SetAnswerViaUnicast(false);
query.SetAnswerViaUnicast(true);

builder.AddQuery(query);

Expand Down Expand Up @@ -555,9 +554,9 @@ CHIP_ERROR MinMdnsResolver::SendPendingResolveQueries()
Query query(instanceQName);

query
.SetClass(QClass::IN) //
.SetType(QType::ANY) //
.SetAnswerViaUnicast(false) //
.SetClass(QClass::IN) //
.SetType(QType::ANY) //
.SetAnswerViaUnicast(true) //
;

// NOTE: type above is NOT A or AAAA because the name searched for is
Expand Down