-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BLE shutdown, make linux free up scanning upon shutdown #11437
Merged
bzbarsky-apple
merged 5 commits into
project-chip:master
from
andy31415:fix_ble_shutdown
Nov 5, 2021
Merged
Add BLE shutdown, make linux free up scanning upon shutdown #11437
bzbarsky-apple
merged 5 commits into
project-chip:master
from
andy31415:fix_ble_shutdown
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
November 4, 2021 16:30
pullapprove
bot
requested review from
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
November 4, 2021 16:30
PR #11437: Size comparison from d91ff7c to 29f2262 Increases (8 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
commented
Nov 4, 2021
PR #11437: Size comparison from 29747a2 to 260c161 Increases (8 builds for linux)
Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 4, 2021
LuDuda
approved these changes
Nov 4, 2021
msandstedt
approved these changes
Nov 5, 2021
bzbarsky-apple
approved these changes
Nov 5, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…chip#11437) * Add BLE shutdown, make linux free up scanning upon shutdown * Add shutdown method for ameba as well * Revert change to copyright date in gn.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Crash on succesful wifi pairing:
From what I can tell, the order of operations is:
Change overview
add a BLE layer shutdown, that allows for device scanner to be freed properly
Testing
Paired via BLE, no crash