Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size reports: Improved comments #10982

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Size reports: Improved comments #10982

merged 1 commit into from
Oct 26, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

It's hard to pick out actual size changes, beyond those called out in
the large-increase tables.

Report information can be distributed across multiple collapsed tables,
since the generator often runs before all builds are complete.

Change overview

Read back any existing comment and merge in new reports.

Comments now contain:

  1. An open table highlighting large increases, if any.
  2. A collapsed table of all increases, if any.
  3. A collapsed table of all decreases, if any.
  4. A collapsed table of all data.

Testing

Tested with manual runs:
#10979 (comment)

@kpschoedel
Size reports: Improved comments
34c74e2 
#### Problem

It's hard to pick out actual size changes, beyond those called out in
the large-increase tables.

Report information can be distributed across multiple collapsed tables,
since the generator often runs before all builds are complete.

#### Change overview

Read back any existing comment and merge in new reports.

Comments now contain:

1. An open table highlighting large increases, if any.
2. A collapsed table of all increases, if any.
3. A collapsed table of all decreases, if any.
4. A collapsed table of all data.

#### Testing

Tested with manual runs:
project-chip#10979 (comment)
@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Oct 26, 2021 •
edited
Loading

PR #10982: Size comparison from 6e1709c to 34c74e2

4 builds (for qpg, telink)
platform target config section 6e1709c 34c74e2b change % change
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485240 485240 0 0.0
lock-app qpg6100+debug .bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 461460 461460 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 457772 457772 0 0.0
12 builds (for k32w, linux, p6)
platform target config section 6e1709c 34c74e2b change % change
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515336 515336 0 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 613972 613972 0 0.0
linux all-clusters-app debug .bss 50160 50160 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60800 60800 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134517 134517 0 0.0
.text 1357522 1357522 0 0.0
chip-tool debug .bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94896 94896 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 208068 208068 0 0.0
.text 3653045 3653045 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110344 110344 0 0.0
.text 1024306 1024306 0 0.0
ota-requestor-app debug .bss 208320 208320 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 129000 129000 0 0.0
.text 1146258 1146258 0 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599458 599458 0 0.0
tv-app debug .bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152072 152072 0 0.0
.text 1455010 1455010 0 0.0
bridge-app debug+rpc .bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109740 109740 0 0.0
.text 1064885 1064885 0 0.0
lighting-app debug+rpc .bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 126897 0 0.0
.text 1262770 1262770 0 0.0
p6 lock-app default .bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1126288 1126288 0 0.0
4 builds (for mbed)
platform target config section 6e1709c 34c74e2b change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179604 0 0.0
.data 5192 5192 0 0.0
.heap 851648 851648 0 0.0
.text 1251712 1251712 0 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219416 1219416 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1197448 1197448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
16 builds (for efr32, esp32, nrfconnect)
platform target config section 6e1709c 34c74e2b change % change
efr32 lighting-app BRD4161A .bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 736008 736008 0 0.0
lock-app BRD4161A .bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 715272 715272 0 0.0
window-app BRD4161A .bss 111860 111860 0 0.0
.data 1716 1716 0 0.0
.text 716172 716172 0 0.0
lighting-app BRD4161A+rpc .bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 723432 723432 0 0.0
esp32 all-clusters-app c3devkit .dram0.bss 58232 58232 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198176 198176 0 0.0
.flash.text 874842 874842 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206928 206928 0 0.0
.flash.text 905919 905919 0 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112136 0 0.0
rodata 97200 97200 0 0.0
text 577296 577296 0 0.0
lock-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93600 93600 0 0.0
text 558856 558856 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111308 0 0.0
rodata 94800 94800 0 0.0
text 561960 561960 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93576 93576 0 0.0
text 558600 558600 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108380 108380 0 0.0
rodata 87976 87976 0 0.0
text 550488 550488 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113512 113512 0 0.0
rodata 92440 92440 0 0.0
text 506768 506768 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112584 112584 0 0.0
rodata 88860 88860 0 0.0
text 488320 488320 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0

@andy31415
Copy link
Contributor

fast track rationale: helper script change

@woody-apple woody-apple merged commit 5213452 into project-chip:master Oct 26, 2021
@kpschoedel kpschoedel deleted the nubloat-report-9-edit branch October 27, 2021 13:52
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@kpschoedel @JasonLiuZhuoCheng
Size reports: Improved comments (project-chip#10982)
f06e56c 
#### Problem

It's hard to pick out actual size changes, beyond those called out in
the large-increase tables.

Report information can be distributed across multiple collapsed tables,
since the generator often runs before all builds are complete.

#### Change overview

Read back any existing comment and merge in new reports.

Comments now contain:

1. An open table highlighting large increases, if any.
2. A collapsed table of all increases, if any.
3. A collapsed table of all decreases, if any.
4. A collapsed table of all data.

#### Testing

Tested with manual runs:
project-chip#10979 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpschoedel @woody-apple @andy31415