Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Move ReadClient callbacks to separate callback class #10963

Merged
merged 1 commit into from
Nov 1, 2021
Merged

[IM] Move ReadClient callbacks to separate callback class #10963

merged 1 commit into from
Nov 1, 2021

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Oct 26, 2021 •
edited
Loading

Problem

Fixes #10573

Move read / subscribe related callbacks to seperate class.

Change overview

  • Move Read / Subscribe related callbacks to seperate class.

Testing

  • This should be covered by existing test cases.

@restyled-io restyled-io bot mentioned this pull request Oct 26, 2021
Closed
@erjiaqing erjiaqing force-pushed the im/read-callback-handler branch from 445f090 to 88dfae4 Compare October 26, 2021 11:47
@github-actions
Copy link

github-actions bot commented Oct 26, 2021 •
edited
Loading

PR #10963: Size comparison from 4ab05ae to 88dfae4

16 builds (for k32w, linux, p6, qpg, telink)
platform target config section 4ab05ae 88dfae4 change % change
k32w lock-app k32w061+debug .bss 69196 69164 -32 -0.0
.data 1864 1864 0 0.0
.text 515240 515304 64 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78720 78688 -32 -0.0
.data 1900 1900 0 0.0
.text 613876 613924 48 0.0
linux all-clusters-app debug .bss 50160 50128 -32 -0.1
.data 978 978 0 0.0
.data.rel.ro 60800 60800 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134517 134517 0 0.0
.text 1356946 1357042 96 0.0
chip-tool debug .bss 17680 17648 -32 -0.2
.data 1584 1584 0 0.0
.data.rel.ro 94896 94864 -32 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 208068 208036 -32 -0.0
.text 3642741 3641989 -752 -0.0
ota-provider-app debug .bss 37440 37408 -32 -0.1
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110344 110344 0 0.0
.text 1023714 1023810 96 0.0
ota-requestor-app debug .bss 208320 208288 -32 -0.0
.data 752 752 0 0.0
.data.rel.ro 25928 25944 16 0.1
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 129000 128968 -32 -0.0
.text 1145602 1145410 -192 -0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599458 599458 0 0.0
tv-app debug .bss 215568 215536 -32 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58144 -48 -0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152072 152040 -32 -0.0
.text 1454338 1455122 784 0.1
bridge-app debug+rpc .bss 51856 51824 -32 -0.1
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109740 109740 0 0.0
.text 1064293 1064389 96 0.0
lighting-app debug+rpc .bss 41176 41144 -32 -0.1
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 126897 0 0.0
.text 1262178 1262274 96 0.0
p6 lock-app default .bss 67184 67152 -32 -0.0
.data 2416 2416 0 0.0
.heap 963744 963776 32 0.0
.text 1126192 1126240 48 0.0
qpg lighting-app qpg6100+debug .bss 52416 52384 -32 -0.1
.data 1000 1000 0 0.0
.text 485144 485184 40 0.0
lock-app qpg6100+debug .bss 51368 51336 -32 -0.1
.data 956 956 0 0.0
.text 461364 461404 40 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69944 69912 -32 -0.0
noinit 33216 33216 0 0.0
text 457672 457720 48 0.0
4 builds (for efr32)
platform target config section 4ab05ae 88dfae4 change % change
efr32 lighting-app BRD4161A .bss 113692 113660 -32 -0.0
.data 1752 1752 0 0.0
.text 735912 735960 48 0.0
lock-app BRD4161A .bss 111548 111516 -32 -0.0
.data 1712 1712 0 0.0
.text 715176 715224 48 0.0
window-app BRD4161A .bss 111860 111828 -32 -0.0
.data 1716 1716 0 0.0
.text 716076 716124 48 0.0
lighting-app BRD4161A+rpc .bss 130196 130164 -32 -0.0
.data 1852 1852 0 0.0
.text 723336 723384 48 0.0
4 builds (for mbed)
platform target config section 4ab05ae 88dfae4 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179572 -32 -0.0
.data 5192 5192 0 0.0
.heap 851648 851680 32 0.0
.text 1251648 1251648 0 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171028 -32 -0.0
.data 5464 5464 0 0.0
.heap 859920 859952 32 0.0
.text 1219352 1219416 64 0.0
lock-app CY8CPROTO_062_4343W+release .bss 169988 169956 -32 -0.0
.data 5432 5432 0 0.0
.heap 861024 861056 32 0.0
.text 1197384 1197384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
12 builds (for esp32, nrfconnect)
platform target config section 4ab05ae 88dfae4 change % change
esp32 all-clusters-app c3devkit .dram0.bss 58232 58200 -32 -0.1
.dram0.data 16464 16464 0 0.0
.flash.rodata 198176 198176 0 0.0
.flash.text 874742 874786 44 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60712 -32 -0.1
.dram0.data 32084 32084 0 0.0
.flash.rodata 206928 206928 0 0.0
.flash.text 905807 905899 92 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112104 -32 -0.0
rodata 97200 97200 0 0.0
text 577204 577252 48 0.0
lock-app nrf52840dk_nrf52840 bss 111208 111176 -32 -0.0
rodata 93600 93600 0 0.0
text 558764 558812 48 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111276 -32 -0.0
rodata 94800 94800 0 0.0
text 561868 561916 48 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111208 111176 -32 -0.0
rodata 93576 93576 0 0.0
text 558508 558556 48 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108380 108348 -32 -0.0
rodata 87976 87976 0 0.0
text 550396 550444 48 0.0
nrf5340dk_nrf5340_cpuapp bss 113512 113480 -32 -0.0
rodata 92440 92440 0 0.0
text 506676 506724 48 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112584 112552 -32 -0.0
rodata 88860 88860 0 0.0
text 488228 488276 48 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 4ab05ae

File Section File VM
chip-qpg6100-lighting-example.out .text 40 40
chip-qpg6100-lighting-example.out .heap 0 32
chip-qpg6100-lighting-example.out .bss 0 -32
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,1909
.debug_line,0,175
.debug_loc,0,118
.debug_abbrev,0,89
.debug_ranges,0,64
.text,40,40
.heap,32,0
.bss,-32,0
.debug_frame,0,-40
[Unmapped],0,-40
.debug_str,0,-283

@github-actions
Copy link

Size increase report for "esp32-example-build" from 4ab05ae

File Section File VM
chip-all-clusters-app.elf .flash.text 44 44
chip-all-clusters-app.elf .dram0.bss 0 -32
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,1519
.debug_loc,0,124
.debug_line,0,73
.debug_abbrev,0,53
.flash.text,44,44
.riscv.attributes,0,-1
.debug_frame,0,-8
.debug_ranges,0,-16
.dram0.bss,-32,0
[Unmapped],0,-44
.debug_str,0,-312

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 4ab05ae

File Section File VM
chip-lock.elf text 48 48
chip-lock.elf bss 0 -32
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,1720
.debug_loc,0,264
.debug_line,0,148
.debug_abbrev,0,72
.debug_ranges,0,56
text,48,48
.symtab,0,16
.shstrtab,0,3
.strtab,0,-11
.debug_frame,0,-28
bss,-32,0
.debug_str,0,-312

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

@erjiaqing erjiaqing marked this pull request as ready for review October 26, 2021 13:52
bzbarsky-apple
bzbarsky-apple requested changes Oct 27, 2021
View reviewed changes
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/controller/CHIPDevice.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple requested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and please fix the typo in the commit message (not just in the PR title); should be "separate".

@erjiaqing erjiaqing changed the title [IM] Move ReadClient callbacks to seperate callback class [IM] Move ReadClient callbacks to separate callback class Oct 28, 2021
@erjiaqing erjiaqing force-pushed the im/read-callback-handler branch from 88dfae4 to 8872e58 Compare October 28, 2021 07:20
@github-actions
Copy link

github-actions bot commented Oct 28, 2021 •
edited
Loading

PR #10963: Size comparison from 36329e1 to 8872e58

Increases (24 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 36329e1 8872e58 change % change
efr32 lighting-app BRD4161A (read only) 737476 737492 16 0.0
.text 737468 737484 16 0.0
BRD4161A+rpc (read only) 724916 724932 16 0.0
.text 724908 724924 16 0.0
lock-app BRD4161A (read only) 716756 716788 32 0.0
.text 716748 716780 32 0.0
window-app BRD4161A (read only) 717660 717676 16 0.0
.text 717652 717668 16 0.0
esp32 all-clusters-app c3devkit (read only) 875926 875974 48 0.0
.flash.text 875926 875974 48 0.0
m5stack (read only) 907187 907291 104 0.0
.flash.text 907187 907291 104 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701024 701040 16 0.0
.text 614636 614684 48 0.0
lock-app k32w061+debug (read/write) 592980 592996 16 0.0
.text 516144 516192 48 0.0
linux ota-requestor-app debug (read/write) 76648 76680 32 0.0
.data.rel.ro 25496 25544 48 0.2
tv-app debug (read only) 1774529 1774993 464 0.0
.text 1477442 1478226 784 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290664 2290728 64 0.0
.heap 850632 850664 32 0.0
.text 1253264 1253328 64 0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858056 858088 32 0.0
lock-app CY8CPROTO_062_4343W+release .heap 859168 859200 32 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862911 862927 16 0.0
text 577624 577672 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 823735 823751 16 0.0
text 550800 550844 44 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787902 787918 16 0.0
text 507092 507140 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839583 839599 16 0.0
text 559108 559156 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764882 764898 16 0.0
text 488668 488716 48 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844287 844303 16 0.0
text 562320 562364 44 0.0
pump-controller-app nrf52840dk_nrf52840 text 558952 558996 44 0.0
p6 lock-app default (read/write) 2169096 2169112 16 0.0
.heap 963760 963792 32 0.0
.text 1127360 1127376 16 0.0
qpg lighting-app qpg6100+debug (read only) 491240 491272 32 0.0
.text 485920 485952 32 0.0
lock-app qpg6100+debug (read only) 467580 467612 32 0.0
.text 462260 462292 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 664518 664534 16 0.0
text 458068 458120 52 0.0
Decreases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 36329e1 8872e58 change % change
efr32 lighting-app BRD4161A (read/write) 115428 115396 -32 -0.0
.bss 113676 113644 -32 -0.0
BRD4161A+rpc (read/write) 132032 132000 -32 -0.0
.bss 130180 130148 -32 -0.0
lock-app BRD4161A (read/write) 113244 113212 -32 -0.0
.bss 111532 111500 -32 -0.0
window-app BRD4161A (read/write) 113568 113536 -32 -0.0
.bss 111852 111820 -32 -0.0
esp32 all-clusters-app c3devkit (read/write) 1308672 1308640 -32 -0.0
.dram0.bss 59248 59216 -32 -0.1
m5stack (read/write) 428460 428428 -32 -0.0
.dram0.bss 61744 61712 -32 -0.1
k32w lighting-app k32w061+se05x+release .bss 78688 78656 -32 -0.0
lock-app k32w061+debug .bss 69172 69140 -32 -0.0
linux all-clusters-app debug (read only) 1653505 1653489 -16 -0.0
(read/write) 119136 119104 -32 -0.0
.bss 51376 51344 -32 -0.1
.text 1383346 1383330 -16 -0.0
bridge-app debug+rpc (read only) 1282421 1282405 -16 -0.0
(read/write) 85192 85160 -32 -0.0
.bss 51856 51824 -32 -0.1
.text 1076245 1076229 -16 -0.0
chip-tool debug (read only) 4262469 4261317 -1152 -0.0
(read/write) 122208 122144 -64 -0.1
.bss 17680 17648 -32 -0.2
.data.rel.ro 97536 97488 -48 -0.0
.rodata 214032 214000 -32 -0.0
.text 3785589 3784757 -832 -0.0
lighting-app debug+rpc (read only) 1541401 1541385 -16 -0.0
(read/write) 102032 102000 -32 -0.0
.bss 41208 41176 -32 -0.1
.text 1279922 1279906 -16 -0.0
ota-provider-app debug (read only) 1238937 1238921 -16 -0.0
(read/write) 67904 67872 -32 -0.0
.bss 37440 37408 -32 -0.1
.text 1031730 1031714 -16 -0.0
ota-requestor-app debug (read only) 1301033 1295465 -5568 -0.4
.bss 45216 45184 -32 -0.1
.rodata 127680 122304 -5376 -4.2
.text 1075490 1075298 -192 -0.0
tv-app debug (read/write) 289656 289592 -64 -0.0
.bss 223280 223248 -32 -0.0
.data.rel.ro 58704 58672 -32 -0.1
.rodata 154776 154744 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 180620 180588 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release .bss 172820 172788 -32 -0.0
lock-app CY8CPROTO_062_4343W+release .bss 171724 171692 -32 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112132 112100 -32 -0.0
nrf52840dk_nrf52840+rpc bss 108372 108340 -32 -0.0
nrf5340dk_nrf5340_cpuapp bss 113504 113472 -32 -0.0
lock-app nrf52840dk_nrf52840 bss 111168 111136 -32 -0.0
nrf5340dk_nrf5340_cpuapp bss 112576 112544 -32 -0.0
pump-app nrf52840dk_nrf52840 bss 111304 111272 -32 -0.0
pump-controller-app nrf52840dk_nrf52840 bss 111200 111168 -32 -0.0
p6 lock-app default .bss 67168 67136 -32 -0.0
qpg lighting-app qpg6100+debug .bss 52400 52368 -32 -0.1
lock-app qpg6100+debug .bss 51352 51320 -32 -0.1
telink lighting-app tlsr9518adk80d bss 69944 69912 -32 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 36329e1 8872e58 change % change
efr32 lighting-app BRD4161A (read only) 737476 737492 16 0.0
(read/write) 115428 115396 -32 -0.0
.bss 113676 113644 -32 -0.0
.data 1752 1752 0 0.0
.text 737468 737484 16 0.0
BRD4161A+rpc (read only) 724916 724932 16 0.0
(read/write) 132032 132000 -32 -0.0
.bss 130180 130148 -32 -0.0
.data 1852 1852 0 0.0
.text 724908 724924 16 0.0
lock-app BRD4161A (read only) 716756 716788 32 0.0
(read/write) 113244 113212 -32 -0.0
.bss 111532 111500 -32 -0.0
.data 1712 1712 0 0.0
.text 716748 716780 32 0.0
window-app BRD4161A (read only) 717660 717676 16 0.0
(read/write) 113568 113536 -32 -0.0
.bss 111852 111820 -32 -0.0
.data 1716 1716 0 0.0
.text 717652 717668 16 0.0
esp32 all-clusters-app c3devkit (read only) 875926 875974 48 0.0
(read/write) 1308672 1308640 -32 -0.0
.dram0.bss 59248 59216 -32 -0.1
.dram0.data 16448 16448 0 0.0
.flash.rodata 199744 199744 0 0.0
.flash.text 875926 875974 48 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907187 907291 104 0.0
(read/write) 428460 428428 -32 -0.0
.dram0.bss 61744 61712 -32 -0.1
.dram0.data 32084 32084 0 0.0
.flash.rodata 208468 208468 0 0.0
.flash.text 907187 907291 104 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701024 701040 16 0.0
.bss 78688 78656 -32 -0.0
.data 1900 1900 0 0.0
.text 614636 614684 48 0.0
lock-app k32w061+debug (read/write) 592980 592996 16 0.0
.bss 69172 69140 -32 -0.0
.data 1864 1864 0 0.0
.text 516144 516192 48 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1653505 1653489 -16 -0.0
(read/write) 119136 119104 -32 -0.0
.bss 51376 51344 -32 -0.1
.data 978 978 0 0.0
.data.rel.ro 61536 61536 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 137845 137845 0 0.0
.text 1383346 1383330 -16 -0.0
bridge-app debug+rpc (read only) 1282421 1282405 -16 -0.0
(read/write) 85192 85160 -32 -0.0
.bss 51856 51824 -32 -0.1
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110812 110812 0 0.0
.text 1076245 1076229 -16 -0.0
chip-tool debug (read only) 4262469 4261317 -1152 -0.0
(read/write) 122208 122144 -64 -0.1
.bss 17680 17648 -32 -0.2
.data 1584 1584 0 0.0
.data.rel.ro 97536 97488 -48 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214032 214000 -32 -0.0
.text 3785589 3784757 -832 -0.0
lighting-app debug+rpc (read only) 1541401 1541385 -16 -0.0
(read/write) 102032 102000 -32 -0.0
.bss 41208 41176 -32 -0.1
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1279922 1279906 -16 -0.0
ota-provider-app debug (read only) 1238937 1238921 -16 -0.0
(read/write) 67904 67872 -32 -0.0
.bss 37440 37408 -32 -0.1
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110984 0 0.0
.text 1031730 1031714 -16 -0.0
ota-requestor-app debug (read only) 1301033 1295465 -5568 -0.4
(read/write) 76648 76680 32 0.0
.bss 45216 45184 -32 -0.1
.data 816 816 0 0.0
.data.rel.ro 25496 25544 48 0.2
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127680 122304 -5376 -4.2
.text 1075490 1075298 -192 -0.0
shell debug (read only) 787361 787361 0 0.0
(read/write) 57792 57792 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36880 36880 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77519 0 0.0
.text 608258 608258 0 0.0
tv-app debug (read only) 1774529 1774993 464 0.0
(read/write) 289656 289592 -64 -0.0
.bss 223280 223248 -32 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58672 -32 -0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154776 154744 -32 -0.0
.text 1477442 1478226 784 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290664 2290728 64 0.0
.bss 180620 180588 -32 -0.0
.data 5192 5192 0 0.0
.heap 850632 850664 32 0.0
.text 1253264 1253328 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274992 2274992 0 0.0
.bss 172820 172788 -32 -0.0
.data 5568 5568 0 0.0
.heap 858056 858088 32 0.0
.text 1237592 1237592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252712 2252712 0 0.0
.bss 171724 171692 -32 -0.0
.data 5552 5552 0 0.0
.heap 859168 859200 32 0.0
.text 1215312 1215312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048984 2048984 0 0.0
.bss 156208 156208 0 0.0
.data 4968 4968 0 0.0
.heap 875272 875272 0 0.0
.text 1011584 1011584 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862911 862927 16 0.0
bss 112132 112100 -32 -0.0
rodata 97528 97528 0 0.0
text 577624 577672 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 823735 823751 16 0.0
bss 108372 108340 -32 -0.0
rodata 88304 88304 0 0.0
text 550800 550844 44 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787902 787918 16 0.0
bss 113504 113472 -32 -0.0
rodata 92768 92768 0 0.0
text 507092 507140 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839583 839599 16 0.0
bss 111168 111136 -32 -0.0
rodata 93880 93880 0 0.0
text 559108 559156 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764882 764898 16 0.0
bss 112576 112544 -32 -0.0
rodata 89188 89188 0 0.0
text 488668 488716 48 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844287 844303 16 0.0
bss 111304 111272 -32 -0.0
rodata 95128 95128 0 0.0
text 562320 562364 44 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839575 839575 0 0.0
bss 111200 111168 -32 -0.0
rodata 93904 93904 0 0.0
text 558952 558996 44 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520236 520236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440848 440848 0 0.0
p6 lock-app default (read/write) 2169096 2169112 16 0.0
.bss 67168 67136 -32 -0.0
.data 2416 2416 0 0.0
.heap 963760 963792 32 0.0
.text 1127360 1127376 16 0.0
qpg lighting-app qpg6100+debug (read only) 491240 491272 32 0.0
(read/write) 114144 114144 0 0.0
.bss 52400 52368 -32 -0.1
.data 1000 1000 0 0.0
.text 485920 485952 32 0.0
lock-app qpg6100+debug (read only) 467580 467612 32 0.0
(read/write) 114140 114140 0 0.0
.bss 51352 51320 -32 -0.1
.data 956 956 0 0.0
.text 462260 462292 32 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664518 664534 16 0.0
bss 69944 69912 -32 -0.0
noinit 33216 33216 0 0.0
text 458068 458120 52 0.0

@erjiaqing
Copy link
Contributor Author

@Damian-Nordic @saurabhst @msandstedt PTAL thanks

@andy31415
Copy link
Contributor

fast track: several day old PR, created by domain owner with separate approval from another domain owner. General refactor of code.

@andy31415 andy31415 merged commit 68e4b18 into project-chip:master Nov 1, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@erjiaqing
[IM] Move ReadClient callbacks to separate callback class (project-ch…
654d7bf 
…ip#10963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create interaction-specific delegates and delete InteractionModelDelegate
4 participants
@erjiaqing @andy31415 @yunhanw-google @bzbarsky-apple