Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CHIPDevice class to Operational and Commissionee device proxy #10808

Merged
merged 8 commits into from
Nov 8, 2021
Merged

Refactor CHIPDevice class to Operational and Commissionee device proxy #10808

merged 8 commits into from
Nov 8, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

Change overview

Refactor chip::Device into

  1. DeviceProxy base class
  2. Derive CommissioneeDeviceProxy class for devices that are being commissioned
  3. Derive OperationalDeviceProxy class for operational devices

Update the controller and cluster code to use the base class, or specialized class based on the use case.

Testing

Ran commissioning tests, and tests to control commissioned devices using all-cluster-app, chip-tool, Python controller, iOS controller, and m5stack.
CI would run existing unit and integration tests to ensure the existing functionality is intact.

@restyled-io restyled-io bot mentioned this pull request Oct 21, 2021
Closed
@github-actions
Copy link

PR #10808: Size comparison from 0c16976 to 7156bce

14 builds (for efr32, k32w, mbed, p6, qpg, telink)
platform target config section 0c16976 7156bce change % change
efr32 lighting-app BRD4161A .bss 118028 118028 0 0.0
.data 1800 1800 0 0.0
.text 784328 784332 4 0.0
lock-app BRD4161A .bss 115884 115884 0 0.0
.data 1760 1760 0 0.0
.text 763456 763456 0 0.0
window-app BRD4161A .bss 116204 116204 0 0.0
.data 1764 1764 0 0.0
.text 764380 764380 0 0.0
lighting-app BRD4161A+rpc .bss 131356 131356 0 0.0
.data 1852 1852 0 0.0
.text 764028 764024 -4 -0.0
k32w lock-app k32w061+debug .bss 69060 69060 0 0.0
.data 1864 1864 0 0.0
.text 516068 516068 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 359544 359544 0 0.0
lighting-app k32w061+se05x+release .bss 78592 78596 4 0.0
.data 1900 1900 0 0.0
.text 614836 614836 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172100 172100 0 0.0
.data 5464 5464 0 0.0
.heap 858880 858880 0 0.0
.text 1220088 1220088 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171020 171020 0 0.0
.data 5432 5432 0 0.0
.heap 859992 859992 0 0.0
.text 1197984 1197984 0 0.0
p6 lock-app default .bss 68216 68216 0 0.0
.data 2416 2416 0 0.0
.heap 962712 962712 0 0.0
.text 1126688 1126688 0 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 1004 1004 0 0.0
.text 485972 485980 8 0.0
lock-app qpg6100+debug .bss 52496 52496 0 0.0
.data 960 960 0 0.0
.text 462060 462060 0 0.0
persistent-storage-app qpg6100+debug .bss 27840 27840 0 0.0
.data 372 372 0 0.0
.text 149896 149896 0 0.0
telink lighting-app tlsr9518adk80d bss 70996 70996 0 0.0
noinit 33216 33216 0 0.0
text 457630 457630 0 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch from 7156bce to f46ccb7 Compare October 22, 2021 00:24
@github-actions
Copy link

github-actions bot commented Oct 22, 2021 •
edited
Loading

PR #10808: Size comparison from 0c16976 to f46ccb7

8 builds (for k32w, p6, qpg, telink)
platform target config section 0c16976 f46ccb7 change % change
k32w lock-app k32w061+debug .bss 69060 69060 0 0.0
.data 1864 1864 0 0.0
.text 516068 516068 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 359544 359544 0 0.0
lighting-app k32w061+se05x+release .bss 78592 78596 4 0.0
.data 1900 1900 0 0.0
.text 614836 614836 0 0.0
p6 lock-app default .bss 68216 68216 0 0.0
.data 2416 2416 0 0.0
.heap 962712 962712 0 0.0
.text 1126688 1126688 0 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 1004 1004 0 0.0
.text 485972 485980 8 0.0
lock-app qpg6100+debug .bss 52496 52496 0 0.0
.data 960 960 0 0.0
.text 462060 462060 0 0.0
persistent-storage-app qpg6100+debug .bss 27840 27840 0 0.0
.data 372 372 0 0.0
.text 149896 149896 0 0.0
telink lighting-app tlsr9518adk80d bss 70996 70996 0 0.0
noinit 33216 33216 0 0.0
text 457630 457630 0 0.0
6 builds (for efr32, mbed)
platform target config section 0c16976 f46ccb7 change % change
efr32 lighting-app BRD4161A .bss 118028 118028 0 0.0
.data 1800 1800 0 0.0
.text 784328 784332 4 0.0
lock-app BRD4161A .bss 115884 115884 0 0.0
.data 1760 1760 0 0.0
.text 763456 763456 0 0.0
window-app BRD4161A .bss 116204 116204 0 0.0
.data 1764 1764 0 0.0
.text 764380 764380 0 0.0
lighting-app BRD4161A+rpc .bss 131356 131356 0 0.0
.data 1852 1852 0 0.0
.text 764028 764024 -4 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172100 172100 0 0.0
.data 5464 5464 0 0.0
.heap 858880 858880 0 0.0
.text 1220088 1220088 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171020 171020 0 0.0
.data 5432 5432 0 0.0
.heap 859992 859992 0 0.0
.text 1197984 1197984 0 0.0
12 builds (for esp32, nrfconnect)
platform target config section 0c16976 f46ccb7 change % change
esp32 all-clusters-app c3devkit .dram0.bss 60296 60296 0 0.0
.dram0.data 16440 16440 0 0.0
.flash.rodata 199864 199864 0 0.0
.flash.text 874330 874330 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 62800 62800 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208600 208600 0 0.0
.flash.text 905263 905263 0 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 113176 113176 0 0.0
rodata 98076 98076 0 0.0
text 577104 577104 0 0.0
lock-app nrf52840dk_nrf52840 bss 112244 112244 0 0.0
rodata 94412 94412 0 0.0
text 558592 558592 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 112312 112312 0 0.0
rodata 95396 95396 0 0.0
text 561744 561744 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 112252 112252 0 0.0
rodata 94472 94472 0 0.0
text 558384 558384 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72524 72524 0 0.0
text 520208 520208 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 109420 109420 0 0.0
rodata 88856 88856 0 0.0
text 550296 550296 0 0.0
nrf5340dk_nrf5340_cpuapp bss 114552 114552 0 0.0
rodata 93316 93316 0 0.0
text 506572 506572 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 113616 113616 0 0.0
rodata 89672 89672 0 0.0
text 488056 488056 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67168 67168 0 0.0
text 440816 440816 0 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch from f46ccb7 to b91f5f6 Compare October 22, 2021 18:23
@github-actions
Copy link

PR #10808: Size comparison from e282eec to b91f5f6

27 builds (for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section e282eec b91f5f6 change % change
efr32 lighting-app BRD4161A .bss 118036 118036 0 0.0
.data 1800 1800 0 0.0
.text 784296 784300 4 0.0
lock-app BRD4161A .bss 115884 115884 0 0.0
.data 1760 1760 0 0.0
.text 763440 763440 0 0.0
window-app BRD4161A .bss 116204 116204 0 0.0
.data 1764 1764 0 0.0
.text 764356 764356 0 0.0
lighting-app BRD4161A+rpc .bss 131364 131364 0 0.0
.data 1852 1852 0 0.0
.text 764012 763992 -20 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 60296 60296 0 0.0
.dram0.data 16440 16440 0 0.0
.flash.rodata 199912 199912 0 0.0
.flash.text 874326 874326 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 62808 62808 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208648 208648 0 0.0
.flash.text 905335 905335 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lock-app k32w061+debug .bss 69068 69068 0 0.0
.data 1864 1864 0 0.0
.text 516024 516024 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 359480 359480 0 0.0
lighting-app k32w061+se05x+release .bss 78592 78596 4 0.0
.data 1900 1900 0 0.0
.text 614788 614788 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172100 172100 0 0.0
.data 5464 5464 0 0.0
.heap 858880 858880 0 0.0
.text 1220088 1220088 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171020 171020 0 0.0
.data 5432 5432 0 0.0
.heap 859992 859992 0 0.0
.text 1197992 1197992 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 113180 113180 0 0.0
rodata 98080 98080 0 0.0
text 577104 577104 0 0.0
lock-app nrf52840dk_nrf52840 bss 112244 112244 0 0.0
rodata 94416 94416 0 0.0
text 558592 558592 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 112316 112316 0 0.0
rodata 95396 95396 0 0.0
text 561744 561744 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 112252 112252 0 0.0
rodata 94476 94476 0 0.0
text 558384 558384 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72524 72524 0 0.0
text 520208 520208 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 109420 109420 0 0.0
rodata 88856 88856 0 0.0
text 550296 550296 0 0.0
nrf5340dk_nrf5340_cpuapp bss 114552 114552 0 0.0
rodata 93320 93320 0 0.0
text 506572 506572 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 113620 113620 0 0.0
rodata 89676 89676 0 0.0
text 488056 488056 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67168 67168 0 0.0
text 440816 440816 0 0.0
p6 lock-app default .bss 68216 68216 0 0.0
.data 2416 2416 0 0.0
.heap 962712 962712 0 0.0
.text 1126688 1126688 0 0.0
qpg lighting-app qpg6100+debug .bss 53464 53464 0 0.0
.data 1004 1004 0 0.0
.text 486036 486036 0 0.0
lock-app qpg6100+debug .bss 52408 52408 0 0.0
.data 960 960 0 0.0
.text 462120 462120 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149896 149896 0 0.0
telink lighting-app tlsr9518adk80d bss 71000 71000 0 0.0
noinit 33216 33216 0 0.0
text 457612 457612 0 0.0

@github-actions
Copy link

PR #10808: Size comparison from e282eec to 597d90b

Increases above 1.0% from e282eec to 597d90b:

platform target config section e282eec 597d90b change % change
k32w lock-app k32w061+debug .bss 69068 70244 1176 1.7
shell k32w061+debug .bss 55080 63256 8176 14.8
lighting-app k32w061+se05x+release .bss 78592 79764 1172 1.5
8 builds (for k32w, p6, qpg, telink)
platform target config section e282eec 597d90b change % change
k32w lock-app k32w061+debug .bss 69068 70244 1176 1.7
.data 1864 1864 0 0.0
.text 516024 516076 52 0.0
shell k32w061+debug .bss 55080 63256 8176 14.8
.data 672 672 0 0.0
.text 359480 359544 64 0.0
lighting-app k32w061+se05x+release .bss 78592 79764 1172 1.5
.data 1900 1900 0 0.0
.text 614788 614776 -12 -0.0
p6 lock-app default .bss 68216 68224 8 0.0
.data 2416 2416 0 0.0
.heap 962712 962704 -8 -0.0
.text 1126688 1127016 328 0.0
qpg lighting-app qpg6100+debug .bss 53464 53472 8 0.0
.data 1004 1004 0 0.0
.text 486036 486040 4 0.0
lock-app qpg6100+debug .bss 52408 52416 8 0.0
.data 960 960 0 0.0
.text 462120 462188 68 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149896 149896 0 0.0
telink lighting-app tlsr9518adk80d bss 71000 71004 4 0.0
noinit 33216 33216 0 0.0
text 457612 457664 52 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch from 597d90b to b68b331 Compare October 22, 2021 22:23
@github-actions
Copy link

github-actions bot commented Oct 22, 2021 •
edited
Loading

PR #10808: Size comparison from 736dc81 to b68b331

17 builds (for efr32, esp32, k32w, mbed, p6, qpg, telink)
platform target config section 736dc81 b68b331 change % change
efr32 lighting-app BRD4161A .bss 113716 113716 0 0.0
.data 1752 1752 0 0.0
.text 735748 735752 4 0.0
lock-app BRD4161A .bss 111572 111572 0 0.0
.data 1712 1712 0 0.0
.text 714948 714948 0 0.0
window-app BRD4161A .bss 111884 111884 0 0.0
.data 1716 1716 0 0.0
.text 715792 715792 0 0.0
lighting-app BRD4161A+rpc .bss 130220 130220 0 0.0
.data 1852 1852 0 0.0
.text 723172 723152 -20 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 58272 58272 0 0.0
.dram0.data 16440 16440 0 0.0
.flash.rodata 197936 197936 0 0.0
.flash.text 874294 874294 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60776 60776 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206672 206672 0 0.0
.flash.text 905323 905411 88 0.0
.iram0.text 125115 125115 0 0.0
k32w lock-app k32w061+debug .bss 69228 69228 0 0.0
.data 1864 1864 0 0.0
.text 515060 515060 0 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359528 359528 0 0.0
lighting-app k32w061+se05x+release .bss 78744 78748 4 0.0
.data 1900 1900 0 0.0
.text 613760 613760 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 171092 171092 0 0.0
.data 5464 5464 0 0.0
.heap 859888 859888 0 0.0
.text 1219096 1219096 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 170012 170012 0 0.0
.data 5432 5432 0 0.0
.heap 861000 861000 0 0.0
.text 1196992 1196992 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
p6 lock-app default .bss 67208 67208 0 0.0
.data 2416 2416 0 0.0
.heap 963720 963720 0 0.0
.text 1125984 1125984 0 0.0
qpg lighting-app qpg6100+debug .bss 52456 52456 0 0.0
.data 1004 1004 0 0.0
.text 485008 485016 8 0.0
lock-app qpg6100+debug .bss 51400 51400 0 0.0
.data 960 960 0 0.0
.text 461164 461164 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149896 149896 0 0.0
telink lighting-app tlsr9518adk80d bss 69988 69988 0 0.0
noinit 33216 33216 0 0.0
text 457664 457664 0 0.0
10 builds (for nrfconnect)
platform target config section 736dc81 b68b331 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112168 112168 0 0.0
rodata 97084 97084 0 0.0
text 577196 577196 0 0.0
lock-app nrf52840dk_nrf52840 bss 111240 111240 0 0.0
rodata 93484 93484 0 0.0
text 558684 558684 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111300 111300 0 0.0
rodata 94380 94380 0 0.0
text 561836 561836 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111236 111236 0 0.0
rodata 93460 93460 0 0.0
text 558476 558476 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72524 72524 0 0.0
text 520300 520300 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108408 108408 0 0.0
rodata 87860 87860 0 0.0
text 550388 550388 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113540 113540 0 0.0
rodata 92324 92324 0 0.0
text 506664 506664 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112612 112612 0 0.0
rodata 88744 88744 0 0.0
text 488148 488148 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67168 67168 0 0.0
text 440908 440908 0 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch 2 times, most recently from 28eda31 to b6d5c2c Compare October 26, 2021 17:49
@github-actions
Copy link

PR #10808: Size comparison from 5213452 to b6d5c2c

5 builds (for p6, qpg, telink)
platform target config section 5213452 b6d5c2c change % change
p6 lock-app default .bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1126784 1126784 0 0.0
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485440 485440 0 0.0
lock-app qpg6100+debug .bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 461660 461660 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 457976 457976 0 0.0

@github-actions
Copy link

PR #10808: Size comparison from 5213452 to b6d5c2c

Increases (2 builds for efr32, k32w)
platform target config section 5213452 b6d5c2c change % change
efr32 lighting-app BRD4161A .text 736504 736508 4 0.0
k32w lighting-app k32w061+se05x+release .bss 78720 78724 4 0.0
Decreases (1 build for efr32)
platform target config section 5213452 b6d5c2c change % change
efr32 lighting-app BRD4161A+rpc .text 723928 723924 -4 -0.0
Full report (7 builds for efr32, k32w)
platform target config section 5213452 b6d5c2c change % change
efr32 lighting-app BRD4161A .bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 736504 736508 4 0.0
lock-app BRD4161A .bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 715768 715768 0 0.0
window-app BRD4161A .bss 111860 111860 0 0.0
.data 1716 1716 0 0.0
.text 716668 716668 0 0.0
lighting-app BRD4161A+rpc .bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 723928 723924 -4 -0.0
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515544 515544 0 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78720 78724 4 0.0
.data 1900 1900 0 0.0
.text 614180 614180 0 0.0

@github-actions
Copy link

PR #10808: Size comparison from 5213452 to b6d5c2c

Full report (4 builds for mbed)
platform target config section 5213452 b6d5c2c change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179604 0 0.0
.data 5192 5192 0 0.0
.heap 851648 851648 0 0.0
.text 1251904 1251904 0 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219672 1219672 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1197704 1197704 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0

@github-actions
Copy link

PR #10808: Size comparison from 5213452 to b6d5c2c

Increases (1 build for esp32)
platform target config section 5213452 b6d5c2c change % change
esp32 all-clusters-app m5stack .flash.text 906131 906219 88 0.0
Full report (12 builds for esp32, nrfconnect)
platform target config section 5213452 b6d5c2c change % change
esp32 all-clusters-app c3devkit .dram0.bss 58232 58232 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198176 198176 0 0.0
.flash.text 875002 875002 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206928 206928 0 0.0
.flash.text 906131 906219 88 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112136 0 0.0
rodata 97200 97200 0 0.0
text 577512 577512 0 0.0
lock-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93600 93600 0 0.0
text 559072 559072 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111308 0 0.0
rodata 94800 94800 0 0.0
text 562176 562176 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93576 93576 0 0.0
text 558816 558816 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108380 108380 0 0.0
rodata 87976 87976 0 0.0
text 550704 550704 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113512 113512 0 0.0
rodata 92440 92440 0 0.0
text 506984 506984 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112584 112584 0 0.0
rodata 88860 88860 0 0.0
text 488536 488536 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch from b6d5c2c to dd1b21e Compare October 26, 2021 21:29
@github-actions
Copy link

github-actions bot commented Oct 26, 2021 •
edited
Loading

PR #10808: Size comparison from 7b14930 to dd1b21e

Increases (3 builds for efr32, esp32, k32w)
platform target config section 7b14930 dd1b21e change % change
efr32 lighting-app BRD4161A (read only) 736512 736516 4 0.0
.text 736504 736508 4 0.0
esp32 all-clusters-app m5stack (read only) 906131 906219 88 0.0
.flash.text 906131 906219 88 0.0
k32w lighting-app k32w061+se05x+release (read/write) 700600 700604 4 0.0
.bss 78720 78724 4 0.0
Decreases (1 build for efr32)
platform target config section 7b14930 dd1b21e change % change
efr32 lighting-app BRD4161A+rpc (read only) 723936 723932 -4 -0.0
(read/write) 132052 132048 -4 -0.0
.text 723928 723924 -4 -0.0
Full report (28 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7b14930 dd1b21e change % change
efr32 lighting-app BRD4161A (read only) 736512 736516 4 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 736504 736508 4 0.0
BRD4161A+rpc (read only) 723936 723932 -4 -0.0
(read/write) 132052 132048 -4 -0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 723928 723924 -4 -0.0
lock-app BRD4161A (read only) 715792 715792 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 715784 715784 0 0.0
window-app BRD4161A (read only) 716676 716676 0 0.0
(read/write) 113576 113576 0 0.0
.bss 111860 111860 0 0.0
.data 1716 1716 0 0.0
.text 716668 716668 0 0.0
esp32 all-clusters-app c3devkit (read only) 875002 875002 0 0.0
(read/write) 1306112 1306112 0 0.0
.dram0.bss 58232 58232 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198176 198176 0 0.0
.flash.text 875002 875002 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906131 906219 88 0.0
(read/write) 425920 425920 0 0.0
.dram0.bss 60744 60744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206928 206928 0 0.0
.flash.text 906131 906219 88 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 700600 700604 4 0.0
.bss 78720 78724 4 0.0
.data 1900 1900 0 0.0
.text 614180 614180 0 0.0
lock-app k32w061+debug (read/write) 592404 592404 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515544 515544 0 0.0
shell k32w061+debug (read/write) 425204 425204 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289304 2289304 0 0.0
.bss 179604 179604 0 0.0
.data 5192 5192 0 0.0
.heap 851648 851648 0 0.0
.text 1251904 1251904 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257072 2257072 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219672 1219672 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2235104 2235104 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1197704 1197704 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862471 862471 0 0.0
bss 112136 112136 0 0.0
rodata 97200 97200 0 0.0
text 577512 577512 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823311 823311 0 0.0
bss 108380 108380 0 0.0
rodata 87976 87976 0 0.0
text 550704 550704 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787510 787510 0 0.0
bss 113512 113512 0 0.0
rodata 92440 92440 0 0.0
text 506984 506984 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839415 839415 0 0.0
bss 111208 111208 0 0.0
rodata 93600 93600 0 0.0
text 559072 559072 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764458 764458 0 0.0
bss 112584 112584 0 0.0
rodata 88860 88860 0 0.0
text 488536 488536 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843815 843815 0 0.0
bss 111308 111308 0 0.0
rodata 94800 94800 0 0.0
text 562176 562176 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839135 839135 0 0.0
bss 111208 111208 0 0.0
rodata 93576 93576 0 0.0
text 558816 558816 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776531 776531 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691586 691586 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0
p6 lock-app default (read/write) 2168520 2168520 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1126784 1126784 0 0.0
qpg lighting-app qpg6100+debug (read only) 490760 490760 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485440 485440 0 0.0
lock-app qpg6100+debug (read only) 466980 466980 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 461660 461660 0 0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664066 664066 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 457976 457976 0 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch 3 times, most recently from dd01d08 to 627cc87 Compare October 28, 2021 16:02
@github-actions
Copy link

PR #10808: Size comparison from 3948f4f to 627cc87

Increases (4 builds for k32w, qpg, telink)
platform target config section 3948f4f 627cc87 change % change
k32w lighting-app k32w061+se05x+release (read/write) 701024 701140 116 0.0
.bss 78688 78692 4 0.0
.text 614636 614748 112 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491328 104 0.0
.text 485904 486008 104 0.0
lock-app qpg6100+debug (read only) 467556 467564 8 0.0
.text 462236 462244 8 0.0
telink lighting-app tlsr9518adk80d text 458068 458072 4 0.0
Full report (8 builds for k32w, p6, qpg, telink)
platform target config section 3948f4f 627cc87 change % change
k32w lock-app k32w061+debug (read/write) 592980 592980 0 0.0
.bss 69172 69172 0 0.0
.data 1864 1864 0 0.0
.text 516144 516144 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
lighting-app k32w061+se05x+release (read/write) 701024 701140 116 0.0
.bss 78688 78692 4 0.0
.data 1900 1900 0 0.0
.text 614636 614748 112 0.0
p6 lock-app default (read/write) 2169096 2169096 0 0.0
.bss 67168 67168 0 0.0
.data 2416 2416 0 0.0
.heap 963760 963760 0 0.0
.text 1127360 1127360 0 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491328 104 0.0
(read/write) 114144 114144 0 0.0
.bss 51288 51288 0 0.0
.data 1000 1000 0 0.0
.text 485904 486008 104 0.0
lock-app qpg6100+debug (read only) 467556 467564 8 0.0
(read/write) 114140 114140 0 0.0
.bss 50240 50240 0 0.0
.data 956 956 0 0.0
.text 462236 462244 8 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664518 664518 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458068 458072 4 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch from 627cc87 to feb0786 Compare October 28, 2021 16:28
@github-actions
Copy link

github-actions bot commented Oct 28, 2021 •
edited
Loading

PR #10808: Size comparison from 149e582 to feb0786

Increases above 0.2%:

platform target config section 149e582 feb0786 change % change
linux chip-tool debug (read/write) 122208 122744 536 0.4
.data 1584 1616 32 2.0
.data.rel.ro 97536 98048 512 0.5
lighting-app debug+rpc .data 1106 1138 32 2.9
ota-requestor-app debug .data.rel.ro 25496 25704 208 0.8
.text 1075490 1080786 5296 0.5
tv-app debug (read only) 1774529 1795929 21400 1.2
.data 2032 2064 32 1.6
.data.rel.ro 58704 59264 560 1.0
.text 1477442 1497042 19600 1.3
Increases (19 builds for esp32, k32w, linux, nrfconnect, qpg, telink)
platform target config section 149e582 feb0786 change % change
esp32 all-clusters-app c3devkit (read only) 875926 875930 4 0.0
.flash.text 875926 875930 4 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701024 701140 116 0.0
.bss 78688 78692 4 0.0
.text 614636 614748 112 0.0
linux all-clusters-app debug (read only) 1653505 1653521 16 0.0
.text 1383346 1383362 16 0.0
bridge-app debug+rpc (read only) 1282421 1282437 16 0.0
.text 1076245 1076261 16 0.0
chip-tool debug (read only) 4262469 4262653 184 0.0
(read/write) 122208 122744 536 0.4
.data 1584 1616 32 2.0
.data.rel.ro 97536 98048 512 0.5
lighting-app debug+rpc (read/write) 102032 102080 48 0.0
.bss 41208 41232 24 0.1
.data 1106 1138 32 2.9
ota-provider-app debug (read only) 1238937 1238953 16 0.0
(read/write) 67904 67936 32 0.0
.bss 37440 37472 32 0.1
.text 1031730 1031746 16 0.0
ota-requestor-app debug (read only) 1301033 1301105 72 0.0
.data.rel.ro 25496 25704 208 0.8
.text 1075490 1080786 5296 0.5
tv-app debug (read only) 1774529 1795929 21400 1.2
.data 2032 2064 32 1.6
.data.rel.ro 58704 59264 560 1.0
.rodata 154776 155160 384 0.2
.text 1477442 1497042 19600 1.3
nrfconnect lighting-app nrf52840dk_nrf52840 text 577624 577628 4 0.0
nrf52840dk_nrf52840+rpc text 550800 550804 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787902 787918 16 0.0
text 507092 507096 4 0.0
lock-app nrf52840dk_nrf52840 text 559108 559112 4 0.0
nrf5340dk_nrf5340_cpuapp text 488668 488672 4 0.0
pump-app nrf52840dk_nrf52840 text 562320 562324 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 558952 558956 4 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491328 104 0.0
.text 485904 486008 104 0.0
lock-app qpg6100+debug (read only) 467556 467564 8 0.0
.text 462236 462244 8 0.0
telink lighting-app tlsr9518adk80d text 458068 458072 4 0.0
Decreases (4 builds for linux)
platform target config section 149e582 feb0786 change % change
linux chip-tool debug .init_array 424 416 -8 -1.9
.rodata 214032 213872 -160 -0.1
.text 3785589 3784613 -976 -0.0
lighting-app debug+rpc (read only) 1541401 1540017 -1384 -0.1
.init_array 528 520 -8 -1.5
.rodata 128977 127697 -1280 -1.0
.text 1279922 1279842 -80 -0.0
ota-requestor-app debug (read/write) 76648 71224 -5424 -7.1
.bss 45216 39616 -5600 -12.4
.init_array 512 464 -48 -9.4
.rodata 127680 121952 -5728 -4.5
tv-app debug (read/write) 289656 285496 -4160 -1.4
.bss 223280 218512 -4768 -2.1
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 149e582 feb0786 change % change
efr32 lighting-app BRD4161A (read only) 737476 737476 0 0.0
(read/write) 115428 115428 0 0.0
.bss 113676 113676 0 0.0
.data 1752 1752 0 0.0
.text 737468 737468 0 0.0
BRD4161A+rpc (read only) 724916 724916 0 0.0
(read/write) 132032 132032 0 0.0
.bss 130180 130180 0 0.0
.data 1852 1852 0 0.0
.text 724908 724908 0 0.0
lock-app BRD4161A (read only) 716756 716756 0 0.0
(read/write) 113244 113244 0 0.0
.bss 111532 111532 0 0.0
.data 1712 1712 0 0.0
.text 716748 716748 0 0.0
window-app BRD4161A (read only) 717660 717660 0 0.0
(read/write) 113568 113568 0 0.0
.bss 111852 111852 0 0.0
.data 1716 1716 0 0.0
.text 717652 717652 0 0.0
esp32 all-clusters-app c3devkit (read only) 875926 875930 4 0.0
(read/write) 1308672 1308672 0 0.0
.dram0.bss 59248 59248 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 199744 199744 0 0.0
.flash.text 875926 875930 4 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907275 907275 0 0.0
(read/write) 428460 428460 0 0.0
.dram0.bss 61744 61744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208468 208468 0 0.0
.flash.text 907275 907275 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701024 701140 116 0.0
.bss 78688 78692 4 0.0
.data 1900 1900 0 0.0
.text 614636 614748 112 0.0
lock-app k32w061+debug (read/write) 592980 592980 0 0.0
.bss 69172 69172 0 0.0
.data 1864 1864 0 0.0
.text 516144 516144 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1653505 1653521 16 0.0
(read/write) 119136 119136 0 0.0
.bss 51376 51376 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61536 61536 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 137845 137845 0 0.0
.text 1383346 1383362 16 0.0
bridge-app debug+rpc (read only) 1282421 1282437 16 0.0
(read/write) 85192 85192 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110812 110812 0 0.0
.text 1076245 1076261 16 0.0
chip-tool debug (read only) 4262469 4262653 184 0.0
(read/write) 122208 122744 536 0.4
.bss 17680 17680 0 0.0
.data 1584 1616 32 2.0
.data.rel.ro 97536 98048 512 0.5
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 416 -8 -1.9
.rodata 214032 213872 -160 -0.1
.text 3785589 3784613 -976 -0.0
lighting-app debug+rpc (read only) 1541401 1540017 -1384 -0.1
(read/write) 102032 102080 48 0.0
.bss 41208 41232 24 0.1
.data 1106 1138 32 2.9
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 520 -8 -1.5
.rodata 128977 127697 -1280 -1.0
.text 1279922 1279842 -80 -0.0
ota-provider-app debug (read only) 1238937 1238953 16 0.0
(read/write) 67904 67936 32 0.0
.bss 37440 37472 32 0.1
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110984 0 0.0
.text 1031730 1031746 16 0.0
ota-requestor-app debug (read only) 1301033 1301105 72 0.0
(read/write) 76648 71224 -5424 -7.1
.bss 45216 39616 -5600 -12.4
.data 816 816 0 0.0
.data.rel.ro 25496 25704 208 0.8
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 464 -48 -9.4
.rodata 127680 121952 -5728 -4.5
.text 1075490 1080786 5296 0.5
shell debug (read only) 787361 787361 0 0.0
(read/write) 57792 57792 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36880 36880 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77519 0 0.0
.text 608258 608258 0 0.0
tv-app debug (read only) 1774529 1795929 21400 1.2
(read/write) 289656 285496 -4160 -1.4
.bss 223280 218512 -4768 -2.1
.data 2032 2064 32 1.6
.data.rel.ro 58704 59264 560 1.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154776 155160 384 0.2
.text 1477442 1497042 19600 1.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290664 2290664 0 0.0
.bss 180620 180620 0 0.0
.data 5192 5192 0 0.0
.heap 850632 850632 0 0.0
.text 1253264 1253264 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274992 2274992 0 0.0
.bss 172820 172820 0 0.0
.data 5568 5568 0 0.0
.heap 858056 858056 0 0.0
.text 1237592 1237592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252712 2252712 0 0.0
.bss 171724 171724 0 0.0
.data 5552 5552 0 0.0
.heap 859168 859168 0 0.0
.text 1215312 1215312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048984 2048984 0 0.0
.bss 156208 156208 0 0.0
.data 4968 4968 0 0.0
.heap 875272 875272 0 0.0
.text 1011584 1011584 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862911 862911 0 0.0
bss 112132 112132 0 0.0
rodata 97528 97528 0 0.0
text 577624 577628 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 823735 823735 0 0.0
bss 108372 108372 0 0.0
rodata 88304 88304 0 0.0
text 550800 550804 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787902 787918 16 0.0
bss 113504 113504 0 0.0
rodata 92768 92768 0 0.0
text 507092 507096 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839583 839583 0 0.0
bss 111168 111168 0 0.0
rodata 93880 93880 0 0.0
text 559108 559112 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764882 764882 0 0.0
bss 112576 112576 0 0.0
rodata 89188 89188 0 0.0
text 488668 488672 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844287 844287 0 0.0
bss 111304 111304 0 0.0
rodata 95128 95128 0 0.0
text 562320 562324 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839575 839575 0 0.0
bss 111200 111200 0 0.0
rodata 93904 93904 0 0.0
text 558952 558956 4 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520236 520236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440848 440848 0 0.0
p6 lock-app default (read/write) 2169096 2169096 0 0.0
.bss 67168 67168 0 0.0
.data 2416 2416 0 0.0
.heap 963760 963760 0 0.0
.text 1127360 1127360 0 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491328 104 0.0
(read/write) 114144 114144 0 0.0
.bss 51288 51288 0 0.0
.data 1000 1000 0 0.0
.text 485904 486008 104 0.0
lock-app qpg6100+debug (read only) 467556 467564 8 0.0
(read/write) 114140 114140 0 0.0
.bss 50240 50240 0 0.0
.data 956 956 0 0.0
.text 462236 462244 8 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664518 664518 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458068 458072 4 0.0

@pan-apple pan-apple marked this pull request as ready for review October 28, 2021 17:13
@pullapprove pullapprove bot requested a review from andy31415 October 28, 2021 17:13
@cecille cecille mentioned this pull request Nov 5, 2021
Merged
@woody-apple
Copy link
Contributor

Looks like comments have been addressed, nothing pending, and has had > 3 days for review. Tagging fast track.

@woody-apple
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

@pan-apple Build failures :(

@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #10808: Size comparison from 3f82de1 to 14408ec

Increases (14 builds for efr32, k32w, nrfconnect, p6, qpg, telink)
platform target config section 3f82de1 14408ec change % change
efr32 lighting-app BRD4161A+rpc (read only) 733384 733400 16 0.0
.text 733376 733392 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699560 699656 96 0.0
.bss 77808 77812 4 0.0
.text 614044 614136 92 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861635 861651 16 0.0
text 577804 577808 4 0.0
nrf52840dk_nrf52840+rpc text 551952 551956 4 0.0
nrf5340dk_nrf5340_cpuapp text 507264 507268 4 0.0
lock-app nrf52840dk_nrf52840 text 559284 559288 4 0.0
nrf5340dk_nrf5340_cpuapp text 488836 488840 4 0.0
pump-app nrf52840dk_nrf52840 text 563448 563452 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 559020 559024 4 0.0
p6 all-clusters-app default (read/write) 2301136 2301152 16 0.0
.text 1259400 1259416 16 0.0
lock-app default (read/write) 2213848 2213864 16 0.0
.text 1172112 1172128 16 0.0
qpg lighting-app qpg6100+debug (read only) 490896 491008 112 0.0
.text 485576 485688 112 0.0
lock-app qpg6100+debug (read only) 467236 467244 8 0.0
.text 461916 461924 8 0.0
telink lighting-app tlsr9518adk80d text 458250 458254 4 0.0
Full report (28 builds for efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3f82de1 14408ec change % change
efr32 lighting-app BRD4161A (read only) 745848 745848 0 0.0
(read/write) 115740 115740 0 0.0
.bss 113964 113964 0 0.0
.data 1776 1776 0 0.0
.text 745840 745840 0 0.0
BRD4161A+rpc (read only) 733384 733400 16 0.0
(read/write) 132364 132364 0 0.0
.bss 130468 130468 0 0.0
.data 1892 1892 0 0.0
.text 733376 733392 16 0.0
lock-app BRD4161A (read only) 725136 725136 0 0.0
(read/write) 113556 113556 0 0.0
.bss 111820 111820 0 0.0
.data 1736 1736 0 0.0
.text 725128 725128 0 0.0
window-app BRD4161A (read only) 726032 726032 0 0.0
(read/write) 113884 113884 0 0.0
.bss 112140 112140 0 0.0
.data 1740 1740 0 0.0
.text 726024 726024 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699560 699656 96 0.0
.bss 77808 77812 4 0.0
.data 1908 1908 0 0.0
.text 614044 614136 92 0.0
lock-app k32w061+debug (read/write) 592364 592364 0 0.0
.bss 68340 68340 0 0.0
.data 1876 1876 0 0.0
.text 516348 516348 0 0.0
shell k32w061+debug (read/write) 657860 657860 0 0.0
.bss 78980 78980 0 0.0
.data 1844 1844 0 0.0
.text 571236 571236 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291640 2291640 0 0.0
.bss 178924 178924 0 0.0
.data 5224 5224 0 0.0
.heap 852296 852296 0 0.0
.text 1254240 1254240 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271800 2271800 0 0.0
.bss 171980 171980 0 0.0
.data 5576 5576 0 0.0
.heap 858888 858888 0 0.0
.text 1234400 1234400 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249456 2249456 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1212056 1212056 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048912 2048912 0 0.0
.bss 156256 156256 0 0.0
.data 4968 4968 0 0.0
.heap 875224 875224 0 0.0
.text 1011512 1011512 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861635 861651 16 0.0
bss 111280 111280 0 0.0
rodata 96932 96932 0 0.0
text 577804 577808 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 823983 823983 0 0.0
bss 107632 107632 0 0.0
rodata 88112 88112 0 0.0
text 551952 551956 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786678 786678 0 0.0
bss 112652 112652 0 0.0
rodata 92192 92192 0 0.0
text 507264 507268 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838359 838359 0 0.0
bss 110312 110312 0 0.0
rodata 93304 93304 0 0.0
text 559284 559288 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763654 763654 0 0.0
bss 111724 111724 0 0.0
rodata 88608 88608 0 0.0
text 488836 488840 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844451 844451 0 0.0
bss 110452 110452 0 0.0
rodata 95012 95012 0 0.0
text 563448 563452 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838215 838215 0 0.0
bss 110348 110348 0 0.0
rodata 93304 93304 0 0.0
text 559020 559024 4 0.0
shell nrf52840dk_nrf52840 (read/write) 776231 776231 0 0.0
bss 109100 109100 0 0.0
rodata 72540 72540 0 0.0
text 519988 519988 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691270 691270 0 0.0
bss 110084 110084 0 0.0
rodata 67184 67184 0 0.0
text 440584 440584 0 0.0
p6 all-clusters-app default (read/write) 2301136 2301152 16 0.0
.bss 106872 106872 0 0.0
.data 2528 2528 0 0.0
.heap 923944 923944 0 0.0
.text 1259400 1259416 16 0.0
lock-app default (read/write) 2213848 2213864 16 0.0
.bss 95680 95680 0 0.0
.data 2400 2400 0 0.0
.heap 935264 935264 0 0.0
.text 1172112 1172128 16 0.0
qpg lighting-app qpg6100+debug (read only) 490896 491008 112 0.0
(read/write) 114144 114144 0 0.0
.bss 50968 50968 0 0.0
.data 1008 1008 0 0.0
.text 485576 485688 112 0.0
lock-app qpg6100+debug (read only) 467236 467244 8 0.0
(read/write) 114140 114140 0 0.0
.bss 49912 49912 0 0.0
.data 964 964 0 0.0
.text 461916 461924 8 0.0
persistent-storage-app qpg6100+debug (read only) 153316 153316 0 0.0
(read/write) 114144 114144 0 0.0
.bss 19448 19448 0 0.0
.data 360 360 0 0.0
.text 147996 147996 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663242 663242 0 0.0
bss 69092 69092 0 0.0
noinit 33216 33216 0 0.0
text 458250 458254 4 0.0

@pan-apple
Copy link
Contributor Author

@pan-apple Build failures :(

I'll take a look at it today. Last CI run was clean, not sure what changed..

@pan-apple pan-apple force-pushed the controller-refactor branch from 14408ec to df01aa9 Compare November 8, 2021 16:18
@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #10808: Size comparison from 6b422ee to df01aa9

Increases above 0.2%:

platform target config section 6b422ee df01aa9 change % change
linux chip-tool debug (read/write) 126664 127296 632 0.5
.data 2224 2256 32 1.4
.data.rel.ro 100288 100872 584 0.6
lighting-app debug+rpc .data 1170 1202 32 2.7
ota-requestor-app debug (read only) 1329761 1336025 6264 0.5
.data.rel.ro 25544 25800 256 1.0
.text 1107522 1114178 6656 0.6
tv-app debug (read only) 1817233 1836001 18768 1.0
(read/write) 290400 399648 109248 37.6
.bss 223248 331824 108576 48.6
.data 2704 2736 32 1.2
.data.rel.ro 58792 59424 632 1.1
.rodata 155304 155976 672 0.4
.text 1519666 1536130 16464 1.1
Increases (22 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 6b422ee df01aa9 change % change
efr32 lighting-app BRD4161A+rpc (read only) 733384 733400 16 0.0
.text 733376 733392 16 0.0
esp32 all-clusters-app c3devkit (read only) 882786 882790 4 0.0
.flash.text 882786 882790 4 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699560 699656 96 0.0
.bss 77808 77812 4 0.0
.text 614044 614136 92 0.0
linux all-clusters-app debug (read only) 1704225 1704241 16 0.0
.text 1431586 1431602 16 0.0
bridge-app debug+rpc (read only) 1292261 1292277 16 0.0
.text 1085365 1085381 16 0.0
chip-tool debug (read/write) 126664 127296 632 0.5
.data 2224 2256 32 1.4
.data.rel.ro 100288 100872 584 0.6
.rodata 233488 233584 96 0.0
lighting-app debug+rpc (read/write) 102776 102792 16 0.0
.data 1170 1202 32 2.7
ota-provider-app debug (read only) 1251465 1251481 16 0.0
.text 1043154 1043170 16 0.0
ota-requestor-app debug (read only) 1329761 1336025 6264 0.5
.data.rel.ro 25544 25800 256 1.0
.text 1107522 1114178 6656 0.6
tv-app debug (read only) 1817233 1836001 18768 1.0
(read/write) 290400 399648 109248 37.6
.bss 223248 331824 108576 48.6
.data 2704 2736 32 1.2
.data.rel.ro 58792 59424 632 1.1
.rodata 155304 155976 672 0.4
.text 1519666 1536130 16464 1.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861635 861651 16 0.0
text 577804 577808 4 0.0
nrf52840dk_nrf52840+rpc text 551952 551956 4 0.0
nrf5340dk_nrf5340_cpuapp text 507264 507268 4 0.0
lock-app nrf52840dk_nrf52840 text 559284 559288 4 0.0
nrf5340dk_nrf5340_cpuapp text 488836 488840 4 0.0
pump-app nrf52840dk_nrf52840 text 563448 563452 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 559020 559024 4 0.0
p6 all-clusters-app default (read/write) 2301136 2301152 16 0.0
.text 1259400 1259416 16 0.0
lock-app default (read/write) 2213848 2213864 16 0.0
.text 1172112 1172128 16 0.0
qpg lighting-app qpg6100+debug (read only) 490896 491008 112 0.0
.text 485576 485688 112 0.0
lock-app qpg6100+debug (read only) 467236 467244 8 0.0
.text 461916 461924 8 0.0
telink lighting-app tlsr9518adk80d text 458250 458254 4 0.0
Decreases (4 builds for esp32, linux)
platform target config section 6b422ee df01aa9 change % change
esp32 all-clusters-app m5stack (read only) 913639 913623 -16 -0.0
.flash.text 913639 913623 -16 -0.0
linux chip-tool debug (read only) 4931485 4921453 -10032 -0.2
.init_array 432 424 -8 -1.9
.text 4429077 4417413 -11664 -0.3
lighting-app debug+rpc (read only) 1553257 1552001 -1256 -0.1
.bss 41176 41168 -8 -0.0
.init_array 536 528 -8 -1.5
.rodata 129649 128497 -1152 -0.9
.text 1290050 1289970 -80 -0.0
ota-requestor-app debug (read/write) 77232 71776 -5456 -7.1
.bss 45728 40064 -5664 -12.4
.init_array 520 472 -48 -9.2
.rodata 124208 123216 -992 -0.8
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6b422ee df01aa9 change % change
efr32 lighting-app BRD4161A (read only) 745848 745848 0 0.0
(read/write) 115740 115740 0 0.0
.bss 113964 113964 0 0.0
.data 1776 1776 0 0.0
.text 745840 745840 0 0.0
BRD4161A+rpc (read only) 733384 733400 16 0.0
(read/write) 132364 132364 0 0.0
.bss 130468 130468 0 0.0
.data 1892 1892 0 0.0
.text 733376 733392 16 0.0
lock-app BRD4161A (read only) 725136 725136 0 0.0
(read/write) 113556 113556 0 0.0
.bss 111820 111820 0 0.0
.data 1736 1736 0 0.0
.text 725128 725128 0 0.0
window-app BRD4161A (read only) 726032 726032 0 0.0
(read/write) 113884 113884 0 0.0
.bss 112140 112140 0 0.0
.data 1740 1740 0 0.0
.text 726024 726024 0 0.0
esp32 all-clusters-app c3devkit (read only) 882786 882790 4 0.0
(read/write) 1306040 1306040 0 0.0
.dram0.bss 57608 57608 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198712 198712 0 0.0
.flash.text 882786 882790 4 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913639 913623 -16 -0.0
(read/write) 423336 423336 0 0.0
.dram0.bss 60112 60112 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204952 204952 0 0.0
.flash.text 913639 913623 -16 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699560 699656 96 0.0
.bss 77808 77812 4 0.0
.data 1908 1908 0 0.0
.text 614044 614136 92 0.0
lock-app k32w061+debug (read/write) 592364 592364 0 0.0
.bss 68340 68340 0 0.0
.data 1876 1876 0 0.0
.text 516348 516348 0 0.0
shell k32w061+debug (read/write) 657860 657860 0 0.0
.bss 78980 78980 0 0.0
.data 1844 1844 0 0.0
.text 571236 571236 0 0.0
linux all-clusters-app debug (read only) 1704225 1704241 16 0.0
(read/write) 119232 119232 0 0.0
.bss 50608 50608 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139221 139221 0 0.0
.text 1431586 1431602 16 0.0
bridge-app debug+rpc (read only) 1292261 1292277 16 0.0
(read/write) 69808 69808 0 0.0
.bss 35536 35536 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111028 111028 0 0.0
.text 1085365 1085381 16 0.0
chip-tool debug (read only) 4931485 4921453 -10032 -0.2
(read/write) 126664 127296 632 0.5
.bss 18736 18736 0 0.0
.data 2224 2256 32 1.4
.data.rel.ro 100288 100872 584 0.6
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 424 -8 -1.9
.rodata 233488 233584 96 0.0
.text 4429077 4417413 -11664 -0.3
lighting-app debug+rpc (read only) 1553257 1552001 -1256 -0.1
(read/write) 102776 102792 16 0.0
.bss 41176 41168 -8 -0.0
.data 1170 1202 32 2.7
.data.rel.ro 55136 55136 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 528 -8 -1.5
.rodata 129649 128497 -1152 -0.9
.text 1290050 1289970 -80 -0.0
ota-provider-app debug (read only) 1251465 1251481 16 0.0
(read/write) 67976 67976 0 0.0
.bss 37600 37600 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24536 24536 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112232 112232 0 0.0
.text 1043154 1043170 16 0.0
ota-requestor-app debug (read only) 1329761 1336025 6264 0.5
(read/write) 77232 71776 -5456 -7.1
.bss 45728 40064 -5664 -12.4
.data 816 816 0 0.0
.data.rel.ro 25544 25800 256 1.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 472 -48 -9.2
.rodata 124208 123216 -992 -0.8
.text 1107522 1114178 6656 0.6
shell debug (read only) 788041 788041 0 0.0
(read/write) 58184 58184 0 0.0
.bss 16648 16648 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36784 36784 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77935 77935 0 0.0
.text 608642 608642 0 0.0
tv-app debug (read only) 1817233 1836001 18768 1.0
(read/write) 290400 399648 109248 37.6
.bss 223248 331824 108576 48.6
.data 2704 2736 32 1.2
.data.rel.ro 58792 59424 632 1.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155304 155976 672 0.4
.text 1519666 1536130 16464 1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291640 2291640 0 0.0
.bss 178924 178924 0 0.0
.data 5224 5224 0 0.0
.heap 852296 852296 0 0.0
.text 1254240 1254240 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271800 2271800 0 0.0
.bss 171980 171980 0 0.0
.data 5576 5576 0 0.0
.heap 858888 858888 0 0.0
.text 1234400 1234400 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249456 2249456 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1212056 1212056 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048912 2048912 0 0.0
.bss 156256 156256 0 0.0
.data 4968 4968 0 0.0
.heap 875224 875224 0 0.0
.text 1011512 1011512 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861635 861651 16 0.0
bss 111280 111280 0 0.0
rodata 96932 96932 0 0.0
text 577804 577808 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 823983 823983 0 0.0
bss 107632 107632 0 0.0
rodata 88112 88112 0 0.0
text 551952 551956 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786678 786678 0 0.0
bss 112652 112652 0 0.0
rodata 92192 92192 0 0.0
text 507264 507268 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838359 838359 0 0.0
bss 110312 110312 0 0.0
rodata 93304 93304 0 0.0
text 559284 559288 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763654 763654 0 0.0
bss 111724 111724 0 0.0
rodata 88608 88608 0 0.0
text 488836 488840 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844451 844451 0 0.0
bss 110452 110452 0 0.0
rodata 95012 95012 0 0.0
text 563448 563452 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838215 838215 0 0.0
bss 110348 110348 0 0.0
rodata 93304 93304 0 0.0
text 559020 559024 4 0.0
shell nrf52840dk_nrf52840 (read/write) 776231 776231 0 0.0
bss 109100 109100 0 0.0
rodata 72540 72540 0 0.0
text 519988 519988 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691270 691270 0 0.0
bss 110084 110084 0 0.0
rodata 67184 67184 0 0.0
text 440584 440584 0 0.0
p6 all-clusters-app default (read/write) 2301136 2301152 16 0.0
.bss 106872 106872 0 0.0
.data 2528 2528 0 0.0
.heap 923944 923944 0 0.0
.text 1259400 1259416 16 0.0
lock-app default (read/write) 2213848 2213864 16 0.0
.bss 95680 95680 0 0.0
.data 2400 2400 0 0.0
.heap 935264 935264 0 0.0
.text 1172112 1172128 16 0.0
qpg lighting-app qpg6100+debug (read only) 490896 491008 112 0.0
(read/write) 114144 114144 0 0.0
.bss 50968 50968 0 0.0
.data 1008 1008 0 0.0
.text 485576 485688 112 0.0
lock-app qpg6100+debug (read only) 467236 467244 8 0.0
(read/write) 114140 114140 0 0.0
.bss 49912 49912 0 0.0
.data 964 964 0 0.0
.text 461916 461924 8 0.0
persistent-storage-app qpg6100+debug (read only) 153316 153316 0 0.0
(read/write) 114144 114144 0 0.0
.bss 19448 19448 0 0.0
.data 360 360 0 0.0
.text 147996 147996 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663242 663242 0 0.0
bss 69092 69092 0 0.0
noinit 33216 33216 0 0.0
text 458250 458254 4 0.0

@pan-apple pan-apple force-pushed the controller-refactor branch from df01aa9 to 5a7470b Compare November 8, 2021 19:57
@pan-apple pan-apple force-pushed the controller-refactor branch from 5a7470b to f042c2c Compare November 8, 2021 20:25
@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #10808: Size comparison from 86511a1 to f042c2c

Increases (8 builds for efr32, k32w, p6, qpg, telink)
platform target config section 86511a1 f042c2c change % change
efr32 window-app BRD4161A (read only) 722496 722512 16 0.0
.text 722488 722504 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699240 112 0.0
.bss 77976 77980 4 0.0
.text 613440 613548 108 0.0
shell k32w061+debug (read/write) 657608 657624 16 0.0
.text 570652 570668 16 0.0
p6 all-clusters-app default (read/write) 2298888 2298904 16 0.0
.text 1257152 1257168 16 0.0
lock-app default (read/write) 2211592 2211608 16 0.0
.text 1169856 1169872 16 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490396 120 0.0
.text 484956 485076 120 0.0
lock-app qpg6100+debug (read only) 466616 466624 8 0.0
.text 461296 461304 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663426 8 0.0
text 458266 458270 4 0.0
Decreases (1 build for efr32)
platform target config section 86511a1 f042c2c change % change
efr32 lighting-app BRD4161A (read only) 742336 742320 -16 -0.0
.text 742328 742312 -16 -0.0
Full report (13 builds for efr32, k32w, p6, qpg, telink)
platform target config section 86511a1 f042c2c change % change
efr32 lighting-app BRD4161A (read only) 742336 742320 -16 -0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742328 742312 -16 -0.0
BRD4161A+rpc (read only) 729864 729864 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 729856 729856 0 0.0
lock-app BRD4161A (read only) 721600 721600 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721592 721592 0 0.0
window-app BRD4161A (read only) 722496 722512 16 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722488 722504 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699240 112 0.0
.bss 77976 77980 4 0.0
.data 1912 1912 0 0.0
.text 613440 613548 108 0.0
lock-app k32w061+debug (read/write) 591952 591952 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 515764 515764 0 0.0
shell k32w061+debug (read/write) 657608 657624 16 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570652 570668 16 0.0
p6 all-clusters-app default (read/write) 2298888 2298904 16 0.0
.bss 111936 111936 0 0.0
.data 2536 2536 0 0.0
.heap 918872 918872 0 0.0
.text 1257152 1257168 16 0.0
lock-app default (read/write) 2211592 2211608 16 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1169856 1169872 16 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490396 120 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 484956 485076 120 0.0
lock-app qpg6100+debug (read only) 466616 466624 8 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461296 461304 8 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153396 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148076 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663426 8 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458266 458270 4 0.0

@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #10808: Size comparison from 86511a1 to 1eb303e

Increases above 0.2%:

platform target config section 86511a1 1eb303e change % change
linux chip-tool debug (read/write) 133160 133792 632 0.5
.data 2224 2256 32 1.4
.data.rel.ro 100192 100776 584 0.6
lighting-app debug+rpc .data 1170 1202 32 2.7
ota-requestor-app debug (read only) 1330305 1336217 5912 0.4
.data.rel.ro 25448 25704 256 1.0
.text 1107954 1114258 6304 0.6
tv-app debug (read only) 1818705 1836465 17760 1.0
(read/write) 297568 407328 109760 36.9
.bss 230512 339600 109088 47.3
.data 2704 2736 32 1.2
.data.rel.ro 58696 59328 632 1.1
.rodata 155528 156200 672 0.4
.text 1521058 1536514 15456 1.0
Increases (23 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 86511a1 1eb303e change % change
efr32 window-app BRD4161A (read only) 722496 722512 16 0.0
.text 722488 722504 16 0.0
esp32 all-clusters-app c3devkit (read only) 880266 880270 4 0.0
.flash.text 880266 880270 4 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699240 112 0.0
.bss 77976 77980 4 0.0
.text 613440 613548 108 0.0
shell k32w061+debug (read/write) 657608 657624 16 0.0
.text 570652 570668 16 0.0
linux all-clusters-app debug (read only) 1704545 1704561 16 0.0
.text 1431794 1431810 16 0.0
bridge-app debug+rpc (read only) 1292549 1292565 16 0.0
.text 1085573 1085589 16 0.0
chip-tool debug (read/write) 133160 133792 632 0.5
.data 2224 2256 32 1.4
.data.rel.ro 100192 100776 584 0.6
.rodata 233712 233808 96 0.0
lighting-app debug+rpc (read/write) 109432 109448 16 0.0
.data 1170 1202 32 2.7
ota-provider-app debug (read only) 1251785 1251801 16 0.0
.text 1043362 1043378 16 0.0
ota-requestor-app debug (read only) 1330305 1336217 5912 0.4
.data.rel.ro 25448 25704 256 1.0
.text 1107954 1114258 6304 0.6
tv-app debug (read only) 1818705 1836465 17760 1.0
(read/write) 297568 407328 109760 36.9
.bss 230512 339600 109088 47.3
.data 2704 2736 32 1.2
.data.rel.ro 58696 59328 632 1.1
.rodata 155528 156200 672 0.4
.text 1521058 1536514 15456 1.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 577776 577780 4 0.0
nrf52840dk_nrf52840+rpc text 551924 551928 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786822 786838 16 0.0
text 507248 507252 4 0.0
lock-app nrf52840dk_nrf52840 text 559256 559260 4 0.0
nrf5340dk_nrf5340_cpuapp text 488820 488824 4 0.0
pump-app nrf52840dk_nrf52840 text 563420 563424 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838343 838359 16 0.0
text 558992 558996 4 0.0
p6 all-clusters-app default (read/write) 2298888 2298904 16 0.0
.text 1257152 1257168 16 0.0
lock-app default (read/write) 2211592 2211608 16 0.0
.text 1169856 1169872 16 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490396 120 0.0
.text 484956 485076 120 0.0
lock-app qpg6100+debug (read only) 466616 466624 8 0.0
.text 461296 461304 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663426 8 0.0
text 458266 458270 4 0.0
Decreases (4 builds for efr32, linux)
platform target config section 86511a1 1eb303e change % change
efr32 lighting-app BRD4161A (read only) 742336 742320 -16 -0.0
.text 742328 742312 -16 -0.0
linux chip-tool debug (read only) 4921613 4911117 -10496 -0.2
.init_array 432 424 -8 -1.9
.text 4419125 4406997 -12128 -0.3
lighting-app debug+rpc (read only) 1553545 1552273 -1272 -0.1
.bss 47928 47920 -8 -0.0
.init_array 536 528 -8 -1.5
.rodata 129873 128721 -1152 -0.9
.text 1290258 1290162 -96 -0.0
ota-requestor-app debug (read/write) 83920 78432 -5488 -6.5
.bss 52512 46816 -5696 -10.8
.init_array 520 472 -48 -9.2
.rodata 124464 123472 -992 -0.8
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 86511a1 1eb303e change % change
efr32 lighting-app BRD4161A (read only) 742336 742320 -16 -0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742328 742312 -16 -0.0
BRD4161A+rpc (read only) 729864 729864 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 729856 729856 0 0.0
lock-app BRD4161A (read only) 721600 721600 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721592 721592 0 0.0
window-app BRD4161A (read only) 722496 722512 16 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722488 722504 16 0.0
esp32 all-clusters-app c3devkit (read only) 880266 880270 4 0.0
(read/write) 1306488 1306488 0 0.0
.dram0.bss 58400 58400 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198376 198376 0 0.0
.flash.text 880266 880270 4 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911395 911395 0 0.0
(read/write) 423808 423808 0 0.0
.dram0.bss 60904 60904 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204632 204632 0 0.0
.flash.text 911395 911395 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699240 112 0.0
.bss 77976 77980 4 0.0
.data 1912 1912 0 0.0
.text 613440 613548 108 0.0
lock-app k32w061+debug (read/write) 591952 591952 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 515764 515764 0 0.0
shell k32w061+debug (read/write) 657608 657624 16 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570652 570668 16 0.0
linux all-clusters-app debug (read only) 1704545 1704561 16 0.0
(read/write) 125888 125888 0 0.0
.bss 57360 57360 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62208 62208 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139477 139477 0 0.0
.text 1431794 1431810 16 0.0
bridge-app debug+rpc (read only) 1292549 1292565 16 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111252 111252 0 0.0
.text 1085573 1085589 16 0.0
chip-tool debug (read only) 4921613 4911117 -10496 -0.2
(read/write) 133160 133792 632 0.5
.bss 25328 25328 0 0.0
.data 2224 2256 32 1.4
.data.rel.ro 100192 100776 584 0.6
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 424 -8 -1.9
.rodata 233712 233808 96 0.0
.text 4419125 4406997 -12128 -0.3
lighting-app debug+rpc (read only) 1553545 1552273 -1272 -0.1
(read/write) 109432 109448 16 0.0
.bss 47928 47920 -8 -0.0
.data 1170 1202 32 2.7
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 528 -8 -1.5
.rodata 129873 128721 -1152 -0.9
.text 1290258 1290162 -96 -0.0
ota-provider-app debug (read only) 1251785 1251801 16 0.0
(read/write) 74632 74632 0 0.0
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24440 24440 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112488 112488 0 0.0
.text 1043362 1043378 16 0.0
ota-requestor-app debug (read only) 1330305 1336217 5912 0.4
(read/write) 83920 78432 -5488 -6.5
.bss 52512 46816 -5696 -10.8
.data 816 816 0 0.0
.data.rel.ro 25448 25704 256 1.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 472 -48 -9.2
.rodata 124464 123472 -992 -0.8
.text 1107954 1114258 6304 0.6
shell debug (read only) 788153 788153 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78127 78127 0 0.0
.text 608754 608754 0 0.0
tv-app debug (read only) 1818705 1836465 17760 1.0
(read/write) 297568 407328 109760 36.9
.bss 230512 339600 109088 47.3
.data 2704 2736 32 1.2
.data.rel.ro 58696 59328 632 1.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155528 156200 672 0.4
.text 1521058 1536514 15456 1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291552 2291552 0 0.0
.bss 179404 179404 0 0.0
.data 5232 5232 0 0.0
.heap 851808 851808 0 0.0
.text 1254152 1254152 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271648 2271648 0 0.0
.bss 172460 172460 0 0.0
.data 5584 5584 0 0.0
.heap 858400 858400 0 0.0
.text 1234248 1234248 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249368 2249368 0 0.0
.bss 171356 171356 0 0.0
.data 5568 5568 0 0.0
.heap 859520 859520 0 0.0
.text 1211968 1211968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861779 861779 0 0.0
bss 111444 111444 0 0.0
rodata 96932 96932 0 0.0
text 577776 577780 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 824127 824127 0 0.0
bss 107796 107796 0 0.0
rodata 88112 88112 0 0.0
text 551924 551928 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786822 786838 16 0.0
bss 112816 112816 0 0.0
rodata 92192 92192 0 0.0
text 507248 507252 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838487 838487 0 0.0
bss 110476 110476 0 0.0
rodata 93304 93304 0 0.0
text 559256 559260 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763798 763798 0 0.0
bss 111888 111888 0 0.0
rodata 88608 88608 0 0.0
text 488820 488824 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844579 844579 0 0.0
bss 110616 110616 0 0.0
rodata 95012 95012 0 0.0
text 563420 563424 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838343 838359 16 0.0
bss 110512 110512 0 0.0
rodata 93304 93304 0 0.0
text 558992 558996 4 0.0
shell nrf52840dk_nrf52840 (read/write) 776375 776375 0 0.0
bss 109264 109264 0 0.0
rodata 72540 72540 0 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2298888 2298904 16 0.0
.bss 111936 111936 0 0.0
.data 2536 2536 0 0.0
.heap 918872 918872 0 0.0
.text 1257152 1257168 16 0.0
lock-app default (read/write) 2211592 2211608 16 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1169856 1169872 16 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490396 120 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 484956 485076 120 0.0
lock-app qpg6100+debug (read only) 466616 466624 8 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461296 461304 8 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153396 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148076 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663426 8 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458266 458270 4 0.0

@pan-apple pan-apple merged commit a04576d into project-chip:master Nov 8, 2021
@pan-apple pan-apple deleted the controller-refactor branch November 8, 2021 23:04
@kghost kghost mentioned this pull request Nov 9, 2021
Merged
@carol-apple carol-apple mentioned this pull request Nov 9, 2021
Merged
@shubhamdp shubhamdp mentioned this pull request Nov 10, 2021
Merged
1 task
@andersbangGF andersbangGF mentioned this pull request Nov 11, 2021
Closed
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@pan-apple
Refactor CHIPDevice class to Operational and Commissionee device proxy (
6c457d1 
project-chip#10808)

* Refactor CHIPDevice class to Operational and Commissionee device proxy

* Remove use of storage and serializable in CommissioneeDeviceProxy

* address review comments

* fix build errors

* Fix build of ameba platform

* rebase and fixes

* fixes after rebase

* fix Linux build
@andy31415 andy31415 mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt left review comments

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@cecille cecille Awaiting requested review from cecille

Assignees
No one assigned
Labels
app controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Device/DeviceController/DeviceCommissioner
5 participants
@pan-apple @cecille @woody-apple @tcarmelveilleux @msandstedt