[ota-requestor-app] Reference implementation for AnnounceOTAProvider command #10434

holbrookt · 2021-10-13T01:51:03Z

Problem

ota-requestor-app does not currently implement the OTA Requestor cluster nor does it accept or handle the AnnounceOTAProvider command.

In addition, the current ota-requestor-app implementation starts the OTA process immediately, which is not realistic or feasible for all platforms and not useful for certification or testing. AnnounceOTAProvider can be used to trigger the beginning of the OTA process.

Fixes [ota-requestor-app] Handle AnnounceOTAProvider #9522

Change overview

change providerLocation in AnnounceOTAProvider to be type NODE_ID instead of BYTE_SPAN
add emberAf* callback for AnnounceOTAProvider and ExampleOTARequestor class for reusable application logic

Testing

Tested using an additional incoming PR which adds esp32 support. The linux ota-requestor-app cannot be used for testing because it cannot be commissioned and cannot receive commands from chip-tool.

todo · 2021-10-13T01:51:05Z

uncomment and fill in after #7976 is fixed

connectedhomeip/examples/ota-requestor-app/ota-requestor-common/ExampleRequestorDelegate.cpp

Lines 51 to 61 in 51a9052

    
               // TODO: uncomment and fill in after #7976 is fixed 
        
               // mProviderDevice.Init(mConnectParams, mProviderId.Value(), address, mProviderFabricIndex.Value()); 
        
               // mProviderDevice.EstablishConnectivity(); 
        
           } 
        
           EmberAfStatus ExampleRequestorDelegate::HandleAnnounceOTAProvider(chip::app::CommandHandler * commandObj, 
        
                                                                             chip::NodeId providerLocation, uint16_t vendorId, 
        
                                                                             uint8_t announcementReason, chip::ByteSpan metadataForNode) 
        
           { 
        
               mProviderId.SetValue(providerLocation);

This comment was generated by todo based on a `TODO` comment in `51a9052` in #10434. cc @holbrookt.

github-actions · 2021-10-19T17:59:41Z

PR #10434: Size comparison from 05c3a35 to d094004

8 builds (for k32w, p6, qpg, telink)

platform	target	config	section	`05c3a35`	`d094004`	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515344	515520	176
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357332	0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614128	614304	176
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126464	1126624	160
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486440	486616	176
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462512	462684	172
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0
			noinit	33216	33216	0
			text	458216	458304	88

github-actions · 2021-10-19T18:21:51Z

PR #10434: Size comparison from 05c3a35 to d84ef38

5 builds (for p6, qpg, telink)

platform	target	config	section	`05c3a35`	`d84ef38`	change
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126464	1126624	160
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486440	486616	176
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462512	462684	172
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0
			noinit	33216	33216	0
			text	458216	458304	88

5 builds (for k32w, mbed)

platform	target	config	section	`05c3a35`	`d84ef38`	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515344	515520	176
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357332	0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614128	614304	176
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0
			.data	5464	5464	0
			.heap	858816	858816	0
			.text	1219792	1219944	152
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0
			.data	5432	5432	0
			.heap	859928	859928	0
			.text	1197616	1197840	224

4 builds (for efr32)

platform	target	config	section	`05c3a35`	`d84ef38`	change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0
			.data	1800	1800	0
			.text	782788	782944	156
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	761924	762088	164
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	762840	763012	172
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0
			.data	1852	1852	0
			.text	762540	762700	160

12 builds (for esp32, nrfconnect)

platform	target	config	section	`05c3a35`	`d84ef38`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	198888	199008	120	0.1
			.flash.text	872530	872638	108	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62792	62792	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207312	207432	120	0.1
			.flash.text	902751	902831	80	0.0
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0	0.0
			rodata	97684	97776	92	0.1
			text	577572	577652	80	0.0
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0	0.0
			rodata	94020	94112	92	0.1
			text	559072	559152	80	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0	0.0
			rodata	45772	45772	0	0.0
			text	339392	339392	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0	0.0
			rodata	95000	95092	92	0.1
			text	562228	562308	80	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0	0.0
			rodata	94080	94172	92	0.1
			text	558864	558944	80	0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71640	71640	0	0.0
			text	519032	519032	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0	0.0
			rodata	88472	88560	88	0.1
			text	550776	550856	80	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0	0.0
			rodata	92924	93016	92	0.1
			text	507036	507116	80	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0	0.0
			rodata	89280	89372	92	0.1
			text	488532	488612	80	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66284	66284	0	0.0
			text	439632	439632	0	0.0

examples/ota-requestor-app/ota-requestor-common/ExampleRequestorDelegate.cpp

mrjerryjohns

Thanks for the quick turnaround!

github-actions · 2021-10-22T00:12:00Z

PR #10434: Size comparison from 0c16976 to c6249e6

Increases above 1.0% from 0c16976 to c6249e6:

platform	target	config	section	`0c16976`	`c6249e6`	change	% change
linux	ota-requestor-app	debug	.bss	205728	208352	2624	1.3
			.init_array	512	520	8	1.6

18 builds (for k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`0c16976`	`c6249e6`	change	% change
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	516068	516068	0	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	359544	359544	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78592	78592	0	0.0
			.data	1900	1900	0	0.0
			.text	614836	614836	0	0.0
linux	all-clusters-app	debug	.bss	52208	52208	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	60384	60384	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136405	136405	0	0.0
			.text	1352290	1352290	0	0.0
	chip-tool	debug	.bss	17712	17712	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	93504	93504	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	193860	193860	0	0.0
			.text	3502693	3502965	272	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110248	110248	0	0.0
			.text	`1022226`	`1022226`	0	0.0
	ota-requestor-app	debug	.bss	205728	208352	2624	1.3
			.data	752	752	0	0.0
			.data.rel.ro	25800	25896	96	0.4
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	512	520	8	1.6
			.rodata	128392	129000	608	0.5
			.text	1140786	1144386	3600	0.3
	shell	debug	.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76463	76463	0	0.0
			.text	597346	597346	0	0.0
	tv-app	debug	.bss	216592	216592	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	57408	57408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152904	152904	0	0.0
			.text	1452706	1452706	0	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27112	27112	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110748	110748	0	0.0
			.text	1063173	1063173	0	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53808	53808	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127921	127921	0	0.0
			.text	1261170	1261170	0	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172100	172100	0	0.0
			.data	5464	5464	0	0.0
			.heap	858880	858880	0	0.0
			.text	1220088	1220088	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171020	171020	0	0.0
			.data	5432	5432	0	0.0
			.heap	859992	859992	0	0.0
			.text	1197984	1197984	0	0.0
p6	lock-app	default	.bss	68216	68216	0	0.0
			.data	2416	2416	0	0.0
			.heap	962712	962712	0	0.0
			.text	`1126688`	`1126688`	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	1004	1004	0	0.0
			.text	485972	485972	0	0.0
	lock-app	qpg6100+debug	.bss	52496	52496	0	0.0
			.data	960	960	0	0.0
			.text	462060	462060	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	27840	27840	0	0.0
			.data	372	372	0	0.0
			.text	149896	149896	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70996	70996	0	0.0
			noinit	33216	33216	0	0.0
			text	457630	457630	0	0.0

4 builds (for efr32)

platform	target	config	section	`0c16976`	`c6249e6`
efr32	lighting-app	BRD4161A	.bss	118028	118028
			.data	1800	1800
			.text	784328	784328
	lock-app	BRD4161A	.bss	115884	115884
			.data	1760	1760
			.text	763456	763456
	window-app	BRD4161A	.bss	116204	116204
			.data	1764	1764
			.text	764380	764380
	lighting-app	BRD4161A+rpc	.bss	131356	131356
			.data	1852	1852
			.text	764028	764028

2 builds (for esp32)

platform	target	config	section	`0c16976`	`c6249e6`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0
			.dram0.data	16440	16440	0
			.flash.rodata	199864	199864	0
			.flash.text	874330	874330	0
			.iram0.text	57564	57564	0
		m5stack	.dram0.bss	62800	62800	0
			.dram0.data	32084	32084	0
			.flash.rodata	208600	208600	0
			.flash.text	905263	905351	88
			.iram0.text	125115	125115	0

10 builds (for nrfconnect)

platform	target	config	section	`0c16976`	`c6249e6`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113176	113176
			rodata	98076	98076
			text	577104	577104
	lock-app	nrf52840dk_nrf52840	bss	112244	112244
			rodata	94412	94412
			text	558592	558592
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824
			rodata	45776	45776
			text	339456	339456
	pump-app	nrf52840dk_nrf52840	bss	112312	112312
			rodata	95396	95396
			text	561744	561744
	pump-controller-app	nrf52840dk_nrf52840	bss	112252	112252
			rodata	94472	94472
			text	558384	558384
	shell	nrf52840dk_nrf52840	bss	109072	109072
			rodata	72524	72524
			text	520208	520208
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109420	109420
			rodata	88856	88856
			text	550296	550296
		nrf5340dk_nrf5340_cpuapp	bss	114552	114552
			rodata	93316	93316
			text	506572	506572
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113616	113616
			rodata	89672	89672
			text	488056	488056
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056
			rodata	67168	67168
			text	440816	440816

holbrookt · 2021-10-22T00:32:20Z

Currently blocked by #10818

woody-apple · 2021-10-22T16:25:30Z

@holbrookt I can fast track this, can you resolve the build failures?

examples/ota-requestor-app/linux/ExampleSelfCommissioning.h

examples/ota-requestor-app/linux/main.cpp

examples/ota-requestor-app/ota-requestor-common/BDXDownloader.cpp

examples/ota-requestor-app/ota-requestor-common/ExampleOTARequestor.cpp

holbrookt · 2021-10-25T20:32:30Z

@holbrookt I can fast track this, can you resolve the build failures?

@woody-apple #10888 needs to be merged first. Then it should be good to go after a rebase

github-actions · 2021-10-26T02:09:32Z

PR #10434: Size comparison from febbaa6 to b751b49

Increases above 1.0% from febbaa6 to b751b49:

platform	target	config	section	`febbaa6`	`b751b49`	change	% change
linux	ota-requestor-app	debug	.bss	205696	208320	2624	1.3
			.init_array	512	520	8	1.6

16 builds (for k32w, linux, p6, qpg, telink)

platform	target	config	section	`febbaa6`	`b751b49`	change	% change
k32w	lock-app	k32w061+debug	.bss	69196	69196	0	0.0
			.data	1864	1864	0	0.0
			.text	515140	515140	0	0.0
	shell	k32w061+debug	.bss	63256	63256	0	0.0
			.data	672	672	0	0.0
			.text	359572	359572	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78712	78712	0	0.0
			.data	1900	1900	0	0.0
			.text	613776	613776	0	0.0
linux	all-clusters-app	debug	.bss	50160	50160	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	60640	60640	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	134517	134517	0	0.0
			.text	1356946	1356946	0	0.0
	chip-tool	debug	.bss	17680	17680	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	94896	94896	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	208068	208068	0	0.0
			.text	3642741	3642741	0	0.0
	ota-provider-app	debug	.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110344	110344	0	0.0
			.text	`1023714`	`1023714`	0	0.0
	ota-requestor-app	debug	.bss	205696	208320	2624	1.3
			.data	752	752	0	0.0
			.data.rel.ro	25832	25928	96	0.4
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	512	520	8	1.6
			.rodata	128424	129000	576	0.4
			.text	1142146	1145602	3456	0.3
	shell	debug	.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76495	76495	0	0.0
			.text	599458	599458	0	0.0
	tv-app	debug	.bss	215536	215536	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	57424	57424	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152072	152072	0	0.0
			.text	1454338	1454338	0	0.0
	bridge-app	debug+rpc	.bss	51856	51856	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27112	27112	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	109740	109740	0	0.0
			.text	`1064293`	`1064293`	0	0.0
	lighting-app	debug+rpc	.bss	41176	41176	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53808	53808	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	126897	126897	0	0.0
			.text	1262178	1262178	0	0.0
p6	lock-app	default	.bss	67176	67176	0	0.0
			.data	2416	2416	0	0.0
			.heap	963752	963752	0	0.0
			.text	1126088	1126088	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	52416	52416	0	0.0
			.data	1000	1000	0	0.0
			.text	485044	485044	0	0.0
	lock-app	qpg6100+debug	.bss	51360	51360	0	0.0
			.data	956	956	0	0.0
			.text	461264	461264	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	27752	27752	0	0.0
			.data	372	372	0	0.0
			.text	149900	149900	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	69940	69940	0	0.0
			noinit	33216	33216	0	0.0
			text	457672	457672	0	0.0

4 builds (for efr32)

platform	target	config	section	`febbaa6`	`b751b49`
efr32	lighting-app	BRD4161A	.bss	113684	113684
			.data	1752	1752
			.text	735816	735816
	lock-app	BRD4161A	.bss	111540	111540
			.data	1712	1712
			.text	715080	715080
	window-app	BRD4161A	.bss	111852	111852
			.data	1716	1716
			.text	715876	715876
	lighting-app	BRD4161A+rpc	.bss	130188	130188
			.data	1852	1852
			.text	723232	723232

4 builds (for mbed)

platform	target	config	section	`febbaa6`	`b751b49`
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.bss	179604	179604
			.data	5192	5192
			.heap	851648	851648
			.text	1251552	1251552
	lighting-app	CY8CPROTO_062_4343W+release	.bss	171060	171060
			.data	5464	5464
			.heap	859920	859920
			.text	1219256	1219256
	lock-app	CY8CPROTO_062_4343W+release	.bss	169980	169980
			.data	5432	5432
			.heap	861032	861032
			.text	1197280	1197280
	pigweed-app	CY8CPROTO_062_4343W+release	.bss	11760	11760
			.data	4360	4360
			.heap	1020328	1020328
			.text	103064	103064

2 builds (for esp32)

platform	target	config	section	`febbaa6`	`b751b49`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	58232	58232	0
			.dram0.data	16464	16464	0
			.flash.rodata	198072	198072	0
			.flash.text	874742	874742	0
			.iram0.text	57564	57564	0
		m5stack	.dram0.bss	60744	60744	0
			.dram0.data	32084	32084	0
			.flash.rodata	206832	206832	0
			.flash.text	905879	905895	16
			.iram0.text	125115	125115	0

10 builds (for nrfconnect)

platform	target	config	section	`febbaa6`	`b751b49`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112136	112136
			rodata	97100	97100
			text	577204	577204
	lock-app	nrf52840dk_nrf52840	bss	111208	111208
			rodata	93500	93500
			text	558764	558764
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824
			rodata	45776	45776
			text	339456	339456
	pump-app	nrf52840dk_nrf52840	bss	111308	111308
			rodata	94700	94700
			text	561868	561868
	pump-controller-app	nrf52840dk_nrf52840	bss	111204	111204
			rodata	93476	93476
			text	558508	558508
	shell	nrf52840dk_nrf52840	bss	109072	109072
			rodata	72536	72536
			text	520324	520324
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108376	108376
			rodata	87876	87876
			text	550396	550396
		nrf5340dk_nrf5340_cpuapp	bss	113508	113508
			rodata	92340	92340
			text	506676	506676
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112580	112580
			rodata	88760	88760
			text	488228	488228
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056
			rodata	67180	67180
			text	440936	440936

…command (project-chip#10434) * implement ota-requestor command handlers and delegate class * fix ota requestor delegate comment * logging improvements from Tennessee's suggestions * logging improvements/fixes and some name changes * change AnnounceOTAProvider providerLocation field to chip::NodeID * suggestions from Sergei - handle default in announcementReason switch statement - use auto & in emberAf callback * use kUndefined values instead of Optional for FabricIndex and NodeId * remove accidental esp32 folder * restyling * use DecodeableType in OTA Requestor Delegate * regen with pep8 installed * move emberAf handler for AnnounceOtaProvider to application code * apply new timer argument fix * rename providerId to providerNodeId * remove ota-requestor directory (no longer used) * use CHIP_ERROR_FORMAT

project-chip#10953)

implement ota-requestor command handlers and delegate class

51a9052

boring-cyborg bot added app examples labels Oct 13, 2021

regen with pep8 installed

d84ef38

Merge branch 'master' into handle-announce-ota-provider

43ef8ae

This was referenced Oct 20, 2021

AddArgument for enum types (sending commands) #10677

Closed

Add templated AddArgument for enum types (like VendorID) #10721

Merged

carol-apple reviewed Oct 20, 2021

View reviewed changes

examples/ota-requestor-app/ota-requestor-common/ExampleRequestorDelegate.cpp Outdated Show resolved Hide resolved

carol-apple approved these changes Oct 20, 2021

View reviewed changes

holbrookt added 5 commits October 21, 2021 23:21

move emberAf handler for AnnounceOtaProvider to application code

2f32319

Merge branch 'master' into handle-announce-ota-provider

f6e4762

apply new timer argument fix

7467605

rename providerId to providerNodeId

85c0cf6

remove ota-requestor directory (no longer used)

c6249e6

mrjerryjohns approved these changes Oct 21, 2021

View reviewed changes

woody-apple added the fast track label Oct 22, 2021

bzbarsky-apple reviewed Oct 23, 2021

View reviewed changes

carol-apple mentioned this pull request Oct 25, 2021

Make a QueryImage command from OTA Requestor to OTA Provider #10875

Merged

use CHIP_ERROR_FORMAT

d7c9eaa

Merge branch 'master' into handle-announce-ota-provider

b751b49

holbrookt merged commit dff4066 into project-chip:master Oct 26, 2021

todo bot mentioned this pull request Oct 26, 2021

uncomment and fill in after #7976 is fixed #10945

Closed

kghost added a commit to kghost/connectedhomeip that referenced this pull request Oct 26, 2021

Hotfix: fix conflict between project-chip#10434 and project-chip#10909

b9c91d3

kghost added a commit that referenced this pull request Oct 26, 2021

Hotfix: fix conflict between #10434 and #10909 (#10953)

62a6f85

JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021

Hotfix: fix conflict between project-chip#10434 and project-chip#10909 (

649f1f1

project-chip#10953)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ota-requestor-app] Reference implementation for AnnounceOTAProvider command #10434

[ota-requestor-app] Reference implementation for AnnounceOTAProvider command #10434

holbrookt commented Oct 13, 2021 •

edited

Loading

todo bot commented Oct 13, 2021

github-actions bot commented Oct 19, 2021

github-actions bot commented Oct 19, 2021 •

edited

Loading

mrjerryjohns left a comment

github-actions bot commented Oct 22, 2021 •

edited

Loading

holbrookt commented Oct 22, 2021

woody-apple commented Oct 22, 2021

holbrookt commented Oct 25, 2021

github-actions bot commented Oct 26, 2021 •

edited

Loading

[ota-requestor-app] Reference implementation for AnnounceOTAProvider command #10434

[ota-requestor-app] Reference implementation for AnnounceOTAProvider command #10434

Conversation

holbrookt commented Oct 13, 2021 • edited Loading

Problem

Change overview

Testing

todo bot commented Oct 13, 2021

uncomment and fill in after #7976 is fixed

This comment was generated by todo based on a TODO comment in 51a9052 in #10434. cc @holbrookt.

github-actions bot commented Oct 19, 2021

github-actions bot commented Oct 19, 2021 • edited Loading

mrjerryjohns left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 22, 2021 • edited Loading

holbrookt commented Oct 22, 2021

woody-apple commented Oct 22, 2021

holbrookt commented Oct 25, 2021

github-actions bot commented Oct 26, 2021 • edited Loading

holbrookt commented Oct 13, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `51a9052` in #10434. cc @holbrookt.

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 26, 2021 •

edited

Loading