-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some code within src/inet files #10361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Code for different Inet implementations is scattered across many `#if`s. #### Change overview This is a step toward project-chip#7715 _Virtualize System and Inet interfaces_. - For the affected `.cpp` files, code is moved to a single `#if` section for each of the three implementations (LwIP, sockets, and Network Framework.) Some methods have internals split off into separate `…Impl` methods. - Method implementations are reordered to match their declarations. - Doxygen comments move to headers. Since comparing moved code in diff format is difficult, this change explicitly does NOT make any changes to function bodies, beyond any necessary `return` when splitting. #### Testing CI; no change to functionality.
Note to reviewers: this PR avoids changes to moved code, since it's impractical to identify and review such changes using GitHub. |
Size increase report for "esp32-example-build" from 8a4eefb
Full report output
|
Size increase report for "nrfconnect-example-build" from 8a4eefb
Full report output
|
woody-apple
approved these changes
Oct 11, 2021
andy31415
approved these changes
Oct 12, 2021
msandstedt
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code for different Inet implementations is scattered across many
#if
s.Change overview
This is a step toward #7715 Virtualize System and Inet interfaces.
For the affected
.cpp
files, code is moved to a single#if
sectionfor each of the three implementations (LwIP, sockets, and Network
Framework.) Some methods have internals split off into separate
…Impl
methods.
Method implementations are reordered to match their declarations.
Doxygen comments move to headers.
Since comparing moved code in diff format is difficult, this change
explicitly does NOT make any changes to function bodies, beyond any
necessary arguments and returns when splitting.
Testing
CI; no change to functionality.