Introduce a TLV::Tag for TLV tags. #10162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can work on converting various code to using that instead of raw uint64_t, and then make it a class to get some type-safety.
emargolis
approved these changes
Oct 2, 2021
|
@msandstedt @saurabhst @jmartinez-silabs @jepenven-silabs @LuDuda Please take a look? |
jmartinez-silabs
approved these changes
Oct 4, 2021
msandstedt
approved these changes
Oct 4, 2021
saurabhst
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can work on converting various code to using that instead of
raw uint64_t, and then make it a class to get some type-safety.
Problem
We use uint64_t for tlv tags, so it's easy to pass in an integer when a tag is meant.
Change overview
Introduce a named type for tags, so we can start switching to that and eventually get to type-safety.
Testing
No behavior changes.