Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support clang-format in PR #39

Closed
woody-apple opened this issue Mar 11, 2020 · 3 comments
Closed

Support clang-format in PR #39

woody-apple opened this issue Mar 11, 2020 · 3 comments
Assignees
@woody-apple
Labels
enhancement New feature or request
Milestone
M3.3

Comments

@woody-apple
Copy link
Contributor

You might find OpenThread's scripts around clang-format useful:

Originally posted by @jwhui in #2 (comment)
@woody-apple woody-apple self-assigned this Mar 11, 2020
@woody-apple woody-apple added the enhancement New feature or request label Mar 11, 2020
@turon
Copy link
Contributor

turon commented Mar 19, 2020

Addressed by #74?

@woody-apple
Copy link
Contributor Author

Possibly... does the pretty check fail if something doesn't pass? If not, then... it does it, but doesn't fail the PR check

@rwalker-apple
Copy link
Contributor

I've verified that pretty-check does what we want.

@rwalker-apple rwalker-apple added this to the M3.3 milestone Mar 20, 2020
fkjagodzinski pushed a commit to fkjagodzinski/connectedhomeip that referenced this issue Feb 11, 2021
Merge pull request project-chip#39 from pan-/demo-into-development
32397ae 
Demo into development
doublemis1 referenced this issue in doublemis1/connectedhomeip Jul 7, 2021
@nirav1911
Added Introspection for RPC methods (#39)
e0ae516 
* Added Introspection for RPC methods
doublemis1 referenced this issue in doublemis1/connectedhomeip Jul 26, 2021
@wahajsyed @Xiole-KKE
@nirav1911 @mikaelhm @SaileeG
Csg/test event 3.1 merge (#47)
7fe369e 
* Add simple xml rpc server to chip device controller

* Fix RPC Server address

* Remove message lowercasing on rpc

* Remove redundant code

* Place all rpc, csg changes at the bottom of the file

* Add todo comment

* Add extra newlines

* Move the csg additions to above the main method, cannot forward declare the methods

* Open qr_code_parse to dict api for RPC server

* Added development guide

* Added Setup and Testing guide for Real and Virtual BLE Accessories

* Updating Linux Lighting app docker file

* demarcator added in setup_payload, new line at the end

* Implemented Resolve method.

* Code review comments resolved.

* Implementation of ble-scan method with returning discovered devices (#18)

* Implemented ble_scan with peripheral list return.

* Update chip-device-ctrl.py

* Implementation of ZCL AddNetwork and EnableNetwork methods (#23)

RPC methods for Resolve and Zcl - AddNetwork and EnableNetwork implemented.

* Add the test_client sample program

* Updated Readme

* Added new lines

* Updated comments and readme

* Updated README

* Updated readme

* Update chip-device-ctrl.py

* Update chip-device-ctrl.py

* Csg/feature/get pase data (#30)

* Remove message lowercasing on rpc

* Remove redundant code

* Move the csg additions to above the main method, cannot forward declare the methods

* Remove message lowercasing on rpc

* Add debug prints and extra getpase command

* Add get pase session

* Initial PASE data fetch skeleton

* Add separate csg folder to hold constants and utils

* Add macros

* GetPaseData should return a yaml str.

* Add #defines, refactor into csg utilities, deserialize yaml

* Fix linter, comments, add copyright

* added get_pase_data RPC

* refactor methods and variables

* Add PASE Response parameters

* Debuggin additions

* Remove debugging additions

* Fix RPC to allow none values

* Remove pase from BLE call

* Added response, pake 1,2,3 parameters

* Remove merge artifact

* Remove unnecessary edits

* Add debug messages

* Remove debug messages

* Add todo

Co-authored-by: Mikael H. Moeller <mikaelhm@apple.com>

* Get fabric ID (#35)

* Get fabric ID

* Added Introspection for RPC methods (#39)

* Added Introspection for RPC methods

* Add pin code parsing

* Update setup payload return

* Remove extra spaces, extra newline

* Rename to pin_code_parse

* Add ble close

* Add build_sdk only script

* Remove extra space from argument assignment

* Add new line at the end

* Refactor test client build scripts

* Add new line

* Added resolve instruction and dockerfile fixes

* Implement a generic cluster RPC call

* Implement a generic cluster RPC call

* removing unwanted comment

* Addressing PR comments

* Addressing PR review comments

* correcting typing errors

* Update chip-device-ctrl.py

* Undo merge changes

Co-authored-by: Xiaolei Zhou <xiole@amazon.com>
Co-authored-by: SaileeG <SaileeG@github.com>
Co-authored-by: Nirav Shah <nirav_shah2@cable.comcast.com>
Co-authored-by: Nirav Shah <shah.niravk@gmail.com>
Co-authored-by: Mikael H. Moeller <mikaelhm@apple.com>
Co-authored-by: SaileeG <skorgaonkar@google.com>
Co-authored-by: SaileeG <69006439+SaileeG@users.noreply.github.com>
@yunhanw-google yunhanw-google mentioned this issue Dec 8, 2021
Closed
restyled-io bot pushed a commit that referenced this issue Jan 14, 2022
@hnnajh
Merge pull request #39 from project-chip/master
1f5293b 
update from master
@yunhanw-google yunhanw-google mentioned this issue Apr 28, 2022
Closed
@M201370367 M201370367 mentioned this issue Oct 25, 2023
Open
@JasonClark2 JasonClark2 mentioned this issue Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woody-apple woody-apple

Labels
enhancement New feature or request
Projects
None yet
Milestone
M3.3
Development

No branches or pull requests
3 participants
@turon @woody-apple @rwalker-apple