Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Implement arithmetic conformance checks #33422

Open
cecille opened this issue May 13, 2024 · 0 comments
Open

[Tooling] Implement arithmetic conformance checks #33422

cecille opened this issue May 13, 2024 · 0 comments
Assignees

Comments

@cecille
Copy link
Contributor

cecille commented May 13, 2024

Reproduction steps / Feature

We have one now. The time has come.

Requires switching the function API for the conformance checks since now we require a VALUE check rather than an existence check. First step is to match current behaviour using optional, then move over to proper checks.

Platform

python

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

@cecille cecille self-assigned this May 13, 2024
cecille added a commit to cecille/connectedhomeip that referenced this issue May 13, 2024
CHIP-Specifications/connectedhomeip-spec#7808
represents the first arithmetic conformance operation. Adding
a new conformance class to match this. Currently this just returns
optional to match the current behaviour, but this will be changed
in an upcoming PR (see
project-chip#33422)

However, thet change requires that we assess the conformance based
on the attribute values, which we do pass in right now. This
therefore requires a bit of an API change on the conformance classes
and I've opted to address this in a separate PR to keep the changes
compact.
mergify bot pushed a commit that referenced this issue May 21, 2024
* Conformance: add start of arithmetic conformance

CHIP-Specifications/connectedhomeip-spec#7808
represents the first arithmetic conformance operation. Adding
a new conformance class to match this. Currently this just returns
optional to match the current behaviour, but this will be changed
in an upcoming PR (see
#33422)

However, thet change requires that we assess the conformance based
on the attribute values, which we do pass in right now. This
therefore requires a bit of an API change on the conformance classes
and I've opted to address this in a separate PR to keep the changes
compact.

* linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant