Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] Need implementation of DiagnosticDataProviderImpl::GetRebootCount #29108

Closed
bzbarsky-apple opened this issue Sep 7, 2023 · 0 comments · Fixed by #29134
Closed

[Darwin] Need implementation of DiagnosticDataProviderImpl::GetRebootCount #29108

bzbarsky-apple opened this issue Sep 7, 2023 · 0 comments · Fixed by #29134
Labels
darwin needs triage platform

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 7, 2023 •
edited
Loading

Reproduction steps

This is causing Test_TC_DGGEN_2_1 to fail on darwin (when running with chip-tool), because the server always reports 0.

I tried adding the obvious impl, but for some reason this keeps returning increasing values even without reboots. So just filing this to track for now.

Once this is fixed, we should re-enable Test_TC_DGGEN_2_1 on Darwin.

Platform

darwin

Platform Version(s)

No response

Type

YAML tested

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@github-actions github-actions bot added the darwin label Sep 7, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 8, 2023
@bzbarsky-apple
Implement RebootCount storage on Darwin.
1dc414b 
Fixes project-chip#29108
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 8, 2023
Merged
@mergify mergify bot closed this as completed in #29134 Sep 11, 2023
mergify bot pushed a commit that referenced this issue Sep 11, 2023
@bzbarsky-apple
Implement RebootCount storage on Darwin. (#29134)
b274b9e 
* Implement RebootCount storage on Darwin.

Fixes #29108

* Address review comment.
@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin Sep 11, 2023
abpoth pushed a commit to abpoth/connectedhomeip that referenced this issue Sep 12, 2023
@bzbarsky-apple @abpoth
Implement RebootCount storage on Darwin. (project-chip#29134)
5f81692 
* Implement RebootCount storage on Darwin.

Fixes project-chip#29108

* Address review comment.
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Implement RebootCount storage on Darwin. (project-chip#29134)
9a4b925 
* Implement RebootCount storage on Darwin.

Fixes project-chip#29108

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
darwin needs triage platform
Projects
[Platform] Darwin
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement RebootCount storage on Darwin. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple