Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scenes] Fix CurrentGroup, CurrentScene, SceneValid and LastConfiguredBy attributes to be Endpoint and Fabric Scoped. #26900

Closed
lpbeliveau-silabs opened this issue May 26, 2023 · 2 comments · Fixed by #30038
Closed

[Scenes] Fix CurrentGroup, CurrentScene, SceneValid and LastConfiguredBy attributes to be Endpoint and Fabric Scoped. #26900

lpbeliveau-silabs opened this issue May 26, 2023 · 2 comments · Fixed by #30038
Labels
scenes

Comments

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented May 26, 2023 •
edited
Loading

Related to https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/7098. Need to determine and implement the desired behaviour.
@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue May 26, 2023
Merged
@bzbarsky-apple
Copy link
Contributor

@tcarmelveilleux says we need to maintain completely separate values of CurrentGroup/CurrentScene/SceneValid/LastConfiguredBy for each fabric. So we can't store those things in the attribute store, clearly.

@lpbeliveau-silabs
Copy link
Contributor Author

lpbeliveau-silabs commented Jun 7, 2023 •
edited
Loading

Basically, we need to add fabric scoping to those 4 attributes as mentionned in comment:
https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/7098#issuecomment-1579755740

@lpbeliveau-silabs lpbeliveau-silabs changed the title [Scenes] Investigate how to update CurrentGroup and CurrentScene attribute when working with multiple fabrics [Scenes] Fix CurrentGroup, CurrentScene, SceneValid and LastConfiguredBy attributes to be Endpoint and Fabric Scoped. Jun 7, 2023
@lpbeliveau-silabs lpbeliveau-silabs moved this from Todo to In Progress in [Feature] Scenes Oct 19, 2023
@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue Oct 30, 2023
Merged
@mergify mergify bot closed this as completed in #30038 Nov 16, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Feature] Scenes Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scenes
Projects
[Feature] Scenes
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Scenes] FabricSceneInfo lpbeliveau-silabs/connectedhomeip
3 participants
@woody-apple @bzbarsky-apple @lpbeliveau-silabs