Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scenes] Add support for enabling and disabling endpoints in SceneTable and Scenes Server #26877

Closed
lpbeliveau-silabs opened this issue May 26, 2023 · 2 comments · Fixed by #30391
Labels

Comments

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented May 26, 2023

Current implementation doesn't interact with dynamically generated endpoints, needs to properly handle creation and deletion of dynamically created endpoints as well as Enabling/disabling fixed endpoints.

Mentioned in this PR in comments:

@bzbarsky-apple
Copy link
Contributor

This is not just about dynamic endpoints. Enabling/disabling fixed endpoints is also broken with scenes as currently written.

@lpbeliveau-silabs lpbeliveau-silabs changed the title [Scenes] Add support for dynamical endpoint in SceneTable and Scenes Server [Scenes] Add support for enabling and disabling endpoints in SceneTable and Scenes Server May 30, 2023
@lpbeliveau-silabs
Copy link
Contributor Author

Also mentioned here:
https://github.com/project-chip/connectedhomeip/pull/29639/files#r1349474273

The feature map logic should be moved from the server init to the per-endpoint init.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants