Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onFailureCb in MTRBaseDevice's subscribeToAttributePaths #26076

Closed
bzbarsky-apple opened this issue Apr 13, 2023 · 0 comments · Fixed by #26168
Closed

Fix onFailureCb in MTRBaseDevice's subscribeToAttributePaths #26076

bzbarsky-apple opened this issue Apr 13, 2023 · 0 comments · Fixed by #26168
Assignees
@bzbarsky-apple
Labels
darwin v1.2

Comments

@bzbarsky-apple
Copy link
Contributor

See TODO comment being added in #25840: paths-specific failures are not handled correctly
@bzbarsky-apple bzbarsky-apple self-assigned this Apr 13, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 19, 2023
@bzbarsky-apple
Fix handling of path-specific errors in MTRBaseDevice subscribe code.
a61bb09 
1) Improve documentation for subcribeTo* functions on MTRBaseDevice.
2) Fix the implementation to not call the subscriptionEstablished handler when
   the subscription actually errors out before the subscribe is complete.
3) Fix the error handling in the implementation to report path-specific errors
   using the same mechanism as MTRDevice.

Fixes project-chip#26076
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 19, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 19, 2023
@bzbarsky-apple
Fix handling of path-specific errors in MTRBaseDevice subscribe code.
01495be 
1) Improve documentation for subcribeTo* functions on MTRBaseDevice.
2) Fix the implementation to not call the subscriptionEstablished handler when
   the subscription actually errors out before the subscribe is complete.
3) Fix the error handling in the implementation to report path-specific errors
   using the same mechanism as MTRDevice.

Fixes project-chip#26076
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 19, 2023
@bzbarsky-apple
Fix handling of path-specific errors in MTRBaseDevice subscribe code.
870d062 
1) Improve documentation for subcribeTo* functions on MTRBaseDevice.
2) Fix the implementation to not call the subscriptionEstablished handler when
   the subscription actually errors out before the subscribe is complete.
3) Fix the error handling in the implementation to report path-specific errors
   using the same mechanism as MTRDevice.

Fixes project-chip#26076
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 20, 2023
@bzbarsky-apple
Fix handling of path-specific errors in MTRBaseDevice subscribe code.
1f825de 
1) Improve documentation for subcribeTo* functions on MTRBaseDevice.
2) Fix the implementation to not call the subscriptionEstablished handler when
   the subscription actually errors out before the subscribe is complete.
3) Fix the error handling in the implementation to report path-specific errors
   using the same mechanism as MTRDevice.

Fixes project-chip#26076
bzbarsky-apple added a commit that referenced this issue Apr 20, 2023
@bzbarsky-apple
Fix handling of path-specific errors in MTRBaseDevice subscribe code. (…
b187c3e 
…#26168)

* Fix handling of path-specific errors in MTRBaseDevice subscribe code.

1) Improve documentation for subcribeTo* functions on MTRBaseDevice.
2) Fix the implementation to not call the subscriptionEstablished handler when
   the subscription actually errors out before the subscribe is complete.
3) Fix the error handling in the implementation to report path-specific errors
   using the same mechanism as MTRDevice.

Fixes #26076

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of path-specific errors in MTRBaseDevice subscribe code. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple