Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out what ReadFabricList should actually do with the node id #25403

Open
bzbarsky-apple opened this issue Mar 1, 2023 · 1 comment
Open

Figure out what ReadFabricList should actually do with the node id #25403

bzbarsky-apple opened this issue Mar 1, 2023 · 1 comment
Labels
java Issues in java-matter-controller

Comments

@bzbarsky-apple
Copy link
Contributor

Right now in src/app/server/java/ChipFabricProvider-JNI.cpp we do:

        env->SetLongField(jFabric, jnodeId, fabricInfo.GetNodeId());

but jlong is a signed 64-bit value, not an unsigned one...
@bzbarsky-apple bzbarsky-apple added the java Issues in java-matter-controller label Mar 1, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Mar 1, 2023
@bzbarsky-apple
Enable -Wconversion in the java server.
30d57ca 
Note project-chip#25403
tracking whether this is in fact the right fix.
@bzbarsky-apple bzbarsky-apple mentioned this issue Mar 1, 2023
Merged
andy31415 pushed a commit that referenced this issue Mar 2, 2023
@bzbarsky-apple
Enable -Wconversion in the java server. (#25405)
2240c70 
Note #25403
tracking whether this is in fact the right fix.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Enable -Wconversion in the java server. (#25405)
14fd788 
Note project-chip/connectedhomeip#25403
tracking whether this is in fact the right fix.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Enable -Wconversion in the java server. (project-chip#25405)
2b8b7df 
Note project-chip#25403
tracking whether this is in fact the right fix.
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
java Issues in java-matter-controller
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bzbarsky-apple