Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML] Update Power Source Cluster XML to match updated spec #25181

Closed
ReneJosefsen opened this issue Feb 20, 2023 · 1 comment · Fixed by #25233
Closed

[XML] Update Power Source Cluster XML to match updated spec #25181

ReneJosefsen opened this issue Feb 20, 2023 · 1 comment · Fixed by #25233

Comments

@ReneJosefsen
Copy link
Contributor

The data types names has been updated in Network Commissioning Cluster and must be updated in the XML as well.

Updated
WiredFault -> WiredFaultEnum
BatFault -> BatFaultEnum
BatChargeFault -> BatChargeFaultEnum
PowerSourceStatus -> PowerSourceStatusEnum

Added
WiredCurrentTypeEnum
BatChargeLevelEnum
BatReplaceabilityEnum
BatCommonDesignationEnum
BatApprovedChemistryEnum
BatChargeStateEnum

Not sure if this also requires change to the XML, but the names in BatApprovedChemistryEnum

Also, BatIECDesignation was used in attribute table, but BatIECType in description section, so in case XML uses BatIECType this needs to be updated as well.

Spec PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6211 (already merged)
@bzbarsky-apple
Copy link
Contributor

SDK did not have enums for BatApprovedChemistryEnum or BatApprovedChemistryEnum so the fact that names changed in BatApprovedChemistryEnum is not a problem. And the SDK used BatIECDesignation, so we are good there.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 21, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes.
8d76b83 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Mostly addresses project-chip#25181
except for BatCommonDesignationEnum and BatApprovedChemistryEnum which are
pending CHIP-Specifications/connectedhomeip-spec#6315.
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 21, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes.
c1664dd 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Mostly addresses project-chip#25181
except for BatCommonDesignationEnum and BatApprovedChemistryEnum which are
pending CHIP-Specifications/connectedhomeip-spec#6315.
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 21, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 23, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes.
5f462ac 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Mostly addresses project-chip#25181
except for BatCommonDesignationEnum and BatApprovedChemistryEnum which are
pending CHIP-Specifications/connectedhomeip-spec#6315.
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 23, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes.
97d0e5b 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Mostly addresses project-chip#25181
except for BatCommonDesignationEnum and BatApprovedChemistryEnum which are
pending CHIP-Specifications/connectedhomeip-spec#6315.
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 23, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes.
ad8474e 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Fixes project-chip#25181
jmartinez-silabs pushed a commit that referenced this issue Feb 23, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes. (#25233)
7775bec 
* Align Power Source cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Fixes #25181

* Auto-update ZAP files.

* Regenerate generated files.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Align Power Source cluster XML to spec changes. (#25233)
ef86408 
* Align Power Source cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Fixes project-chip/connectedhomeip#25181

* Auto-update ZAP files.

* Regenerate generated files.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Align Power Source cluster XML to spec changes. (#25233)
cfe930b 
* Align Power Source cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Fixes project-chip/connectedhomeip#25181

* Auto-update ZAP files.

* Regenerate generated files.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes. (project-chip#25233)
2528b1c 
* Align Power Source cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Fixes project-chip#25181

* Auto-update ZAP files.

* Regenerate generated files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align Power Source cluster XML to spec changes. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @ReneJosefsen