Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML] Update Network Commissioning Cluster XML to match updated spec #25008

Closed
ReneJosefsen opened this issue Feb 13, 2023 · 0 comments · Fixed by #26988
Closed

[XML] Update Network Commissioning Cluster XML to match updated spec #25008

ReneJosefsen opened this issue Feb 13, 2023 · 0 comments · Fixed by #26988
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@ReneJosefsen
Copy link
Contributor

The data types names has been updated in Network Commissioning Cluster and must be updated in the XML as well.

Updated
WiFiBand -> WiFiBandEnum
WiFiSecurity -> WiFiSecurityBitmap
NetworkCommissioningStatus -> NetworkCommissioningStatusEnum
NetworkInfo -> NetworkInfoStruct
WiFiInterfaceScanResult -> WiFiInterfaceScanResultStruct
ThreadInterfaceScanResult -> ThreadInterfaceScanResultStruct

Spec PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6193 (already merged)
@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Feb 13, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 31, 2023
@bzbarsky-apple
Update Network Commissioning cluster XML to match specification.
886675d 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6193

Fixes project-chip#25008
@bzbarsky-apple bzbarsky-apple mentioned this issue May 31, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 31, 2023
@bzbarsky-apple
Update Network Commissioning cluster XML to match specification.
217590c 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6193

Fixes project-chip#25008
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 31, 2023
@bzbarsky-apple
Update Network Commissioning cluster XML to match specification.
e06baae 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6193

Fixes project-chip#25008
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 1, 2023
@bzbarsky-apple
Update Network Commissioning cluster XML to match specification.
6d57231 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6193

Fixes project-chip#25008
andy31415 pushed a commit that referenced this issue Jun 1, 2023
@bzbarsky-apple
Update Network Commissioning cluster XML to match specification. (#26988
0dc592e 
)

* Update Network Commissioning cluster XML to match specification.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6193

Fixes #25008

* Auto-update ZAP files.

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Network Commissioning cluster XML to match specification. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @ReneJosefsen